kmulvey/bootstrap-builder

Preprocess LESS to compile overrides for twbs/bootstrap

I am a Go developer and the author of:

• Concurrenthash - Merkle tree for hashing large files
• Imageconvert - Convert and compress large libraries on images
• Imagedup - Find similar images in large image libraries with perceptual hashing
• Text2speech - Convert text to speech using AWS Polly.
• Humannumbers - Convert numbers in English text to float64
• Humantime - Convert English phrases to Go time.Time{}
• Path - A simple library to handle file path input

📈 GitHub Stats

bootstrap-builder's Issues

fontface

5 +@font-face{
6   font-family:'FranklinGothicMedium';
7   src: url(//:) format('no404'),
8   url('@{headingsFontPath}FranklinGothic-Med-webfont.woff') format('woff'),
9   url('@{headingsFontPath}FranklinGothic-Med-webfont.ttf') format('truetype'),

10 url('@{headingsFontPath}FranklinGothic-Med-webfont.svg') format('svg');
11 font-weight:400;
12 font-style:normal;
13 }

rename selector for mixins

basically this test needs to pass and does not currently, this is because the regex that tries to determine if a % is within () does not work well. This regex lives on line 28 of Block.java. When done it can probably be combined with line 27. The whole reason for this regex is to differentiate between and update of the selector and a % in a normal selector (i.e. defaulting % values in a mixin signature)

@test
public void renameMixin() {
Block b = new Block(".box-shadow(@shadow)%.box-shadow(@ShadowA, @ShadowB:X, ...)");
b.process();
Assert.assertEquals("update", b.getAction());
Assert.assertEquals(".box-shadow(@shadow)", b.getSelector());
Assert.assertEquals(".box-shadow(@ShadowA,@ShadowB:X,...)", b.updated_selector[1]);
}

sample LESS
.box-shadow(@shadow)
%
.box-shadow(@ShadowA, @ShadowB:X, ...){

btw, this is a blocker for v2.3.2

too much trim()ing going on in Block.java

why call trim() after substring() ? It was already called in the constructor

better exception capturing

we need to send better messages to the user when exception occur rather than printing a stack trace.

space at the end of lines breaks things

linear runner needed

we need a runner that compiles one file at a time i.e. in a for() loop

Main.java should be renamed to ThreadedRunner.java
new file should be LinearRunner.java

they should both be able to run LessRunner.java

change logging level via cli flags

need to be able to change the logging AppenderRef via cli args to the jar. The runners will need to read these args.

I think LoggerContext or LoggerConfig can be used to do this:
https://logging.apache.org/log4j/2.x/manual/architecture.html

comments in override files

this has gotten better for comments on their own line do not effect the next line however the following does not work:

• // z-index: 2;
  

in my opinion you should not do that, you should just delete the rule entirely

deleting blocks always deletes the first one it finds

would need to check some of the contents to be sure its the correct one

check path format in FileUtil.writeFile

File file = new File(dir + "/" + name);

this is unsafe as the "/" may have already been provided in dir or name

update selectors

need to be able to do this:

-.btn-link,
-.btn-link:active,
-.btn-link[disabled] {
+.btn.btn-link,
+.btn.btn-link:active,
+.btn.btn-link[disabled] {
background-color: transparent;
background-image: none;
.box-shadow(none);

• text-shadow: none;
  }

rewrite Merge class so it is readable

there is currently a lot of zen in that class, below is a new design that should simplify things a bit:

https://github.com/kmulvey/bootstrap-builder/wiki/Merge-rewrite