Comments (6)
I get lots of errors like this:
E: 9, 0: No name 'QHBoxLayout' in module 'PyQt5.QtWidgets' (no-name-in-module)
For gui.py:
Your code has been rated at 3.51/10 (previous run: 3.51/10, +0.00)
But this is actually a problem with pylint/PyQt cooperation, not with our programm.
from dotplot.
Am I missing something? ;)
python3 -m pylint dotplot.py
Your code has been rated at 8.42/10 (previous run: 8.42/10, +0.00)
python3 -m pylint gui.py
Your code has been rated at 9.36/10 (previous run: 9.36/10, +0.00)
Maybe you have used pylint for python2, not for python3?
Edit:
I tested with python2 -m pylint *.py
, it gives:
- '8.83/10' for gui and
- '6.84/10' for dotplot.
Is that right, @maciosz?
from dotplot.
Weird, I've used pylint for python3 for sure. I get 7.11 for dotplot and 3.51 for gui. I'll post some details later.
from dotplot.
Ok, my mistake with gui.py, thanks @kinga322 for noticing; I should have read the output... But for dotplot.py I get 7.11 (which of course is not that bad), I don't know why you get something else. I've cloned it just before posting the issue, so it's not because I have old version. Anyway, as I said it's not that bad, so if everyone agrees I will close this silly issue tomorrow.
from dotplot.
Could you paste the full output for dotplot.py
? I guess it's the same problem - we have one import from Qt5 in this file and it gets classified as 'E' (error) so it makes the score much lower. By the way, I wouldn't close this until we have some idea how to eliminate this strange behavior of pylint - it makes setting quality requirements impossible as we don't have common tool to measure it. Maybe we can migrate to flake8 or something like this.
from dotplot.
Again, you're right. The main error was because of the import. Unfortunately, I can't paste you the output I got yesterday, because I have the newest version now and it gives me different score... (Yeah, I know that with git I can go back to the previous version, but I don't know how). Anyway, now for dotplot.py I get:
************* Module dotplot
C: 41, 0: Unnecessary parens after 'print' keyword (superfluous-parens)
C: 1, 0: Missing module docstring (missing-docstring)
E: 5, 0: Unable to import 'drawer' (invalid syntax (<string>, line 26)) (import-error)
C: 10, 0: Missing class docstring (missing-docstring)
C: 18, 4: Missing method docstring (missing-docstring)
C: 21, 4: Missing method docstring (missing-docstring)
C: 36, 0: Missing function docstring (missing-docstring)
E: 44,12: Unable to import 'PyQt5.QtWidgets' (import-error)
W: 51,12: Unused variable 'main_window' (unused-variable)
W: 7, 0: Unused Sequence imported from sequence (unused-import)
(...)
Messages
--------
+-------------------+------------+
|message id |occurrences |
+===================+============+
|missing-docstring |5 |
+-------------------+------------+
|import-error |2 |
+-------------------+------------+
|unused-variable |1 |
+-------------------+------------+
|unused-import |1 |
+-------------------+------------+
|superfluous-parens |1 |
+-------------------+------------+
Global evaluation
-----------------
Your code has been rated at 5.26/10
from dotplot.
Related Issues (20)
- Add basic description to built-in help
- Eliminate repetitive fragments of code in 'plotter.py' HOT 1
- Show messages in status bar after file selection and plotting HOT 1
- Graphical and command-line interface for sequence retrieval HOT 1
- Add exemplar sequence identifiers to chooser
- Add help/tutorial window to GUI
- Save plot to file
- Add axes labels HOT 1
- "Undo" option
- Fetch sequence by gene
- Implement "window-size" for plotter HOT 1
- Add different substitution matrices for plotter HOT 1
- Increase tests coverage to at least 75%
- Use block elements from UTF-8 charset to display different shades of dotplot HOT 1
- Add options panel where a user can set parameters for plotter like "window size" or "stringency" HOT 1
- Add "stringency" parameter to CLI (argument_parser.py)
- Let user decide if sequence should be displayed HOT 1
- Sequence label in matplotilb does not work well with window_size option
- [proposition] Rewrite "readme" to rst HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dotplot.