Giter Site home page Giter Site logo

Comments (6)

maximilien avatar maximilien commented on July 21, 2024

Do you have an example @navidshaikh?

I asked because if I understood this request correctly, you would have the text moved to a different file or location from the command definition and have a constant in it's place in the definition.

While an interesting suggestion it would result in less readable code --- need to read text file or constant file and code for command.

I kind of like having the command into one place. I can see moving the runE(...) function out into it's own function or even file but the command definition should include all that is needed IMO.

from client.

navidshaikh avatar navidshaikh commented on July 21, 2024

I asked because if I understood this request correctly, you would have the text moved to a different file or location from the command definition and have a constant in it's place in the definition.

That's correct, but in an organized manner, not like a text-file as such.

This came after suggestion from @cppforlife during a PR review.

IMO, keeping the constants part separate from definitions helps being consistent in the help/example language/grammar used across commands.

I do not have an example right now, but I plan to work on this once we have the v0.1 issues sorted.

from client.

maximilien avatar maximilien commented on July 21, 2024

IMO, keeping the constants part separate from definitions helps being consistent in the help/example language/grammar used across commands.

I think we should avoid separating text to the code. Separating is premature optimization IMO.

from client.

cppforlife avatar cppforlife commented on July 21, 2024

This came after suggestion from @cppforlife during a PR review.

curious which suggestion?

from client.

navidshaikh avatar navidshaikh commented on July 21, 2024

curious which suggestion?

@cppforlife It's for aliases, here.

from client.

sixolet avatar sixolet commented on July 21, 2024

Let's keep text describing flags with the flags, and command usage with the command for now. It's more readable that way.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.