knoxell/certbot-dns-namecheap

Fork! Certbot plugin to provide dns-01 challenge support for namecheap.com

Hi there, I‘m Knoxell 👋

• 💬 Ask me about anything
• 📫 Reach me by carrier pigeon
• 😄 Pronouns: he/him, they/them

---

certbot-dns-namecheap's Issues

DNS lexicon 3.1.0 changes

From #10 :

As written in certbot pull request in dns-lexicon v3.1.0 the variable type parameter was renamed to rtype, which makes it incompatible with older certbot versions.

Solutions:

1. require dns-lexicon<3.1.0 only for NPM, maybe in NPM config?
2. implement create_record and delete_record and pass arguments without names as suggested here
3. (2.2) try and catch around a call with rtype and type and possibly use super(NamecheapClient,self).*_record(...)

One of these should still be done.

Compatibility with NginxProxyManager (certbot v0.31.0)

To integrate this plugin into https://github.com/NginxProxyManager/nginx-proxy-manager, we need the zope IPluginFactory, so some of the work from #5 can be undone.

source for clientip unavailable

1. In _NamecheapLexiconClient(dns_common_lexicon.LexiconClient).__init__ the site http://ip.42.pl/raw is used to get the client ip address, the service is unavailable.
2. Why is it used at all? LexiconClient uses the dns-lexicon python module, it's cli interface doesn't need me to provice my own ip address.

TODO

• cheap fix? find alternative service
  • "http://jsonip.com", t is provided by https://getjsonip.com (no Privacy Policy :-$)
• find out what lexicon does I recall reading that they get your ip address from namecheap. That would be ideal, cause not additional service provider is required.

Tell certbot we only do DNS01

example

Plugin legacy name should be changed

Running certbot brings up

Plugin legacy name certbot-dns-namecheap:dns-namecheap may be removed in a future version. Please use dns-namecheap instead.

get rid of docs

there is nothing in there and it only fills up the repo

DeprecationWarning during unittest

Unittest reveals DeprecationWarning

/opt/certbot/src/certbot-dns-namecheap/certbot_dns_namecheap/dns_namecheap.py:25: DeprecationWarning: IAuthenticator attribute in certbot.interfaces module is deprecated and will be removed soon.
  @zope.interface.implementer(interfaces.IAuthenticator)
/opt/certbot/src/certbot-dns-namecheap/certbot_dns_namecheap/dns_namecheap.py:26: DeprecationWarning: IPluginFactory attribute in certbot.interfaces module is deprecated and will be removed soon.
  @zope.interface.provider(interfaces.IPluginFactory)
...../usr/local/lib/python3.8/site-packages/lexicon/config.py:356: DeprecationWarning: Legacy configuration object has been used to load the ConfigResolver.
  warnings.warn(
.............
----------------------------------------------------------------------
Ran 18 tests in 1.792s

OK

Cleanup description and pypi description

using `--dry-run` and multiple domains gives namecheap._ApiError

When requesting a certificate for two domains with --dry-run I get

Saving debug log to /var/log/letsencrypt/letsencrypt.log
Simulating a certificate request for *.example.tld and example.tld
Remote: 3
To set: 4
Remote: 4
To set: 5
Waiting 60 seconds for DNS changes to propagate
Remote: 5
To set: 4
Encountered exception during recovery: lexicon.providers.namecheap._ApiError: 1 - Did not receive 200 (Ok) response
The dry run was successful.

I don't really know what I should do, both domains work individually, without error.

And the most bizarre thing without --dry-run there is no error! (--test-run is probably affected aswell)

I'll probably leave this alone because it doesn't effect requesting certificates.

If anyone wants to investigate, feel free to post your findings here. Pull requests are welcome aswell.

urllib2 not available in python3