knplabs/piwikclient

[UNMAINTAINED] Simple Piwik API client, written in PHP 5.3

piwikclient's Issues

Repository name

Regarding to the README from the KnpPiwikBundle, this bundle should be located at git://github.com/knplabs/KnpPiwikClient.git.

So maybe you should rename the repository or change the KnpPiwikBundle README?

Proposal > call arguments

Hi!

This is a proposal. If you accept it on the principle, I will make a PR with the updated code, tests & docs.

---

Could we cut the call() $method argument in two parts?

// For the moment
$client->call('API.getReportMetadata', array(), 'php');
$client->call('Plugin.method', $params, $format);
// Proposition
$client->call('API', 'getReportMetadata', array(), 'php');
$client->call($plugin, $method, $params, $format);

This could make a good abstraction of the Piwik API structure.

Cheers,
Thomas.

Proposal > adaptative Client constructor

Hi!

This is a proposal. If you accept it on the principle, I will make a PR with the updated code, tests & docs.

---

I propose to introduce more polymorphism in the Client instantiation:

use \Knp\PiwikClient\Client;

// Exactly what you want
new Client($connection, $apiToken);
// Your connection with an anonymous use of API
new Client($connection);
// A HttpConnection
new Client($apiURL, $apiToken);
// A HttpConnection with an anonymous use of API
new Client($apiURL);
// A PiwikConnection (local PHP instance)
new Client();

This will simplify the use of the library & make an awesome example for the README.

Cheers,
Thomas.

Required buzz version

Not sure if this is problem with your requirements list or buzz's versioning, but will get following error:

knplabs/knp-piwik-client dev-master requires kriswallsmith/buzz 0.10.* -> no matching package found.

Proposal > catch Buzz exceptions

Hi!

This is a proposal. If you accept it on the principle, I will make a PR with the updated code, tests & docs.

---

I propose to catch Buzz exceptions, and throw a PiwikClientException. Because Buzz is a sub dependency, it should not be exposed.

Cheers,
Thomas.

Proposal > remove license file header

Hi!

This is a proposal. If you accept it on the principle, I will make a PR with the updated code, tests & docs.

---

Could we remove the license headers on every file?
We juste have to keep the README & LICENSE files.

It simpler and it seems to be what you do on your other projets.

Cheers,
Thomas.