Giter Site home page Giter Site logo

Comments (7)

jeremiahsnapp avatar jeremiahsnapp commented on August 10, 2024 1

@knu this seems to work for us. Can you please make a stable release? Thanks!

from ruby-unf_ext.

jeremiahsnapp avatar jeremiahsnapp commented on August 10, 2024

I did some more investigating and I noticed that the 0.0.8.1-x64-mingw32 gem is missing the unf_ext.so library file built for ruby 3.1 as you can see in the following output which is just a list of the gem's files.

$ tar tzvf data.tar.gz                                                                                                                                                                                                                
-rw-r--r--  0 wheel  wheel      55 Mar 12 22:31 .document
-rw-r--r--  0 wheel  wheel    1000 Mar 12 22:31 .github/workflows/unf_ext.yml
-rw-r--r--  0 wheel  wheel     174 Mar 12 22:31 .gitignore
-rw-r--r--  0 wheel  wheel    1214 Mar 12 22:31 CHANGELOG.md
-rw-r--r--  0 wheel  wheel      97 Mar 12 22:31 Gemfile
-rw-r--r--  0 wheel  wheel    1174 Mar 12 22:31 LICENSE.txt
-rw-r--r--  0 wheel  wheel     992 Mar 12 22:31 README.md
-rw-r--r--  0 wheel  wheel     801 Mar 12 22:31 Rakefile
-rw-r--r--  0 wheel  wheel    1314 Mar 12 22:31 ext/unf_ext/extconf.rb
-rw-r--r--  0 wheel  wheel    2129 Mar 12 22:31 ext/unf_ext/unf.cc
-rw-r--r--  0 wheel  wheel    4474 Mar 12 22:31 ext/unf_ext/unf/normalizer.hh
-rw-r--r--  0 wheel  wheel 1437417 Mar 12 22:31 ext/unf_ext/unf/table.hh
-rw-r--r--  0 wheel  wheel    4149 Mar 12 22:31 ext/unf_ext/unf/trie/char_stream.hh
-rw-r--r--  0 wheel  wheel     590 Mar 12 22:31 ext/unf_ext/unf/trie/node.hh
-rw-r--r--  0 wheel  wheel    5587 Mar 12 22:31 ext/unf_ext/unf/trie/searcher.hh
-rw-r--r--  0 wheel  wheel     619 Mar 12 22:31 ext/unf_ext/unf/util.hh
-rwxrwxr-x  0 wheel  wheel  536064 Mar 12 22:31 lib/2.4/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  536064 Mar 12 22:31 lib/2.5/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  536064 Mar 12 22:31 lib/2.6/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  536576 Mar 12 22:31 lib/2.7/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  543744 Mar 12 22:31 lib/3.0/unf_ext.so
-rw-r--r--  0 wheel  wheel     109 Mar 12 22:31 lib/unf_ext.rb
-rw-r--r--  0 wheel  wheel      64 Mar 12 22:31 lib/unf_ext/version.rb
-rw-r--r--  0 wheel  wheel     470 Mar 12 22:31 test/helper.rb
-rw-r--r--  0 wheel  wheel  602527 Mar 12 22:31 test/normalization-test.txt
-rw-r--r--  0 wheel  wheel    1757 Mar 12 22:31 test/test_unf_ext.rb
-rw-r--r--  0 wheel  wheel    1336 Mar 12 22:31 unf_ext.gemspec

You can see that the unf_ext-0.0.8.1-x86-mingw32.gem gem does have the unf_ext.so library file built for ruby 3.1.

$ tar tzvf data.tar.gz                                                                                                                                                                                                                
-rw-r--r--  0 wheel  wheel      55 Mar 12 22:31 .document
-rw-r--r--  0 wheel  wheel    1000 Mar 12 22:31 .github/workflows/unf_ext.yml
-rw-r--r--  0 wheel  wheel     174 Mar 12 22:31 .gitignore
-rw-r--r--  0 wheel  wheel    1214 Mar 12 22:31 CHANGELOG.md
-rw-r--r--  0 wheel  wheel      97 Mar 12 22:31 Gemfile
-rw-r--r--  0 wheel  wheel    1174 Mar 12 22:31 LICENSE.txt
-rw-r--r--  0 wheel  wheel     992 Mar 12 22:31 README.md
-rw-r--r--  0 wheel  wheel     801 Mar 12 22:31 Rakefile
-rw-r--r--  0 wheel  wheel    1314 Mar 12 22:31 ext/unf_ext/extconf.rb
-rw-r--r--  0 wheel  wheel    2129 Mar 12 22:31 ext/unf_ext/unf.cc
-rw-r--r--  0 wheel  wheel    4474 Mar 12 22:31 ext/unf_ext/unf/normalizer.hh
-rw-r--r--  0 wheel  wheel 1437417 Mar 12 22:31 ext/unf_ext/unf/table.hh
-rw-r--r--  0 wheel  wheel    4149 Mar 12 22:31 ext/unf_ext/unf/trie/char_stream.hh
-rw-r--r--  0 wheel  wheel     590 Mar 12 22:31 ext/unf_ext/unf/trie/node.hh
-rw-r--r--  0 wheel  wheel    5587 Mar 12 22:31 ext/unf_ext/unf/trie/searcher.hh
-rw-r--r--  0 wheel  wheel     619 Mar 12 22:31 ext/unf_ext/unf/util.hh
-rwxrwxr-x  0 wheel  wheel  530432 Mar 12 22:31 lib/2.4/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  530432 Mar 12 22:31 lib/2.5/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  530432 Mar 12 22:31 lib/2.6/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  531456 Mar 12 22:31 lib/2.7/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  531968 Mar 12 22:31 lib/3.0/unf_ext.so
-rwxrwxr-x  0 wheel  wheel  531968 Mar 12 22:31 lib/3.1/unf_ext.so
-rw-r--r--  0 wheel  wheel     109 Mar 12 22:31 lib/unf_ext.rb
-rw-r--r--  0 wheel  wheel      64 Mar 12 22:31 lib/unf_ext/version.rb
-rw-r--r--  0 wheel  wheel     470 Mar 12 22:31 test/helper.rb
-rw-r--r--  0 wheel  wheel  602527 Mar 12 22:31 test/normalization-test.txt
-rw-r--r--  0 wheel  wheel    1757 Mar 12 22:31 test/test_unf_ext.rb
-rw-r--r--  0 wheel  wheel    1336 Mar 12 22:31 unf_ext.gemspec

Somehow the build process for 0.0.8.1-x64-mingw32 didn't build for ruby 3.1.

from ruby-unf_ext.

knu avatar knu commented on August 10, 2024

Thanks for reporting this. I might have failed to build and package binary gems properly with the latest version of rake-compiler-dock. I'll roll out 0.0.8.2 soon.

from ruby-unf_ext.

knu avatar knu commented on August 10, 2024

This is probably related to the fact that RubyInstaller changed the x64 platform name from x64-mingw32 to x64-mingw-ucrt.
https://rubyinstaller.org/2021/12/31/rubyinstaller-3.1.0-1-released.html

from ruby-unf_ext.

knu avatar knu commented on August 10, 2024

I've released 0.0.8.2.beta for testing. The latest version of rake-compiler-dock no longer seems to build an x64-mingw32 binary for Ruby 3.1 (code), so I followed that and pushed three binary gems. Feedback is welcome.

from ruby-unf_ext.

jeremiahsnapp avatar jeremiahsnapp commented on August 10, 2024

Hi @knu, do you have any concerns with making 0.0.8.2 a stable release?

from ruby-unf_ext.

gabgagnon avatar gabgagnon commented on August 10, 2024

@knu Can you make it a stable version?

from ruby-unf_ext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.