Comments (1)
koalaman
commented on July 23, 2024
Nice catch! This was due to one of ShellCheck's design mistakes: making directives separate nodes in the AST that checks match against to identify problems.
In this case, the check looked for ! cmd inside various compound command bodies. It neglected to look for ! cmd inside directives inside the compound command bodies. As a result, any type of directive (whether or not related to disabling warnings) would cause this particular check not to recognize the problem it aimed to.
It was fortunately not a general problem with disabling specific codes, but it's definitely not the first bug caused by this design mistake, and it certainly won't be the last.
from shellcheck.
Related Issues (20)
- SC2034 doesn't consider local function definitions to define new scopes
- Please separate the issue of unused functions from SC2317 (Command appears to be unreachable) HOT 11
- `require-double-brackets` doesn't work in BusyBox `sh` even though `[[` is supported HOT 3
- SC2115 fires when it is statically verifyable that the variable cannot be empty HOT 2
- SC2221/SC2222 fires for non-exhaustive wildcard patterns HOT 1
- SC2154 var is referenced but not assigned not triggered if used within an array HOT 1
- Feature Request: Provide an option to specify the fallback shell type HOT 9
- SC2251 - add ${PIPESTATUS[0]} check to exceptions HOT 1
- SC2015 inconsistent behavior HOT 2
- Skip SC2015 when it end with: || true
- Please support all alias for busybox shell equally
- SC2154 from strict bash mode example using trap HOT 2
- SC2086 false positive on readonly integer variable
- SC2004 false positive on assignment to array position HOT 1
- Missing SC2166 URL in summary section HOT 1
- SC2094, SC2035, SC2034, SC2205, SC2283 ternary arithmetic false positives
- RFE: variant of `source=` directive that supports globbing
- SC1090 is sometimes not raised HOT 1
- [Feature request][Bash] Add rules to provide tips on adding local, or readonly status to variables
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shellcheck.