kodlian/tvvlcplayer

TVVLCPlayer lets you integrate easily a powerfull video player with playback control views to your tvOS apps.

tvvlcplayer's Issues

Support for Info and Subtitle views

Any plans on when Info and Subtitle views will be supported?

Installation via Cocoapods causes xcasset problems

When I add TVVLCPlayer via Cocoapods, my tvOS app no longer recognises any of my assets in the xcasset file. This means the app icon and top shelf components are missing at runtime, even though the xcasset file and project are configured correctly. This can be fixed by removing TVVLCPlayer as a dependency.

Any ideas what could be causing this? Removing the build phase that copies pod resources had no effect.

Complication error with Cocoapods 1.5

Using Cocoapods 1.5, I get the following error when trying to build or use TVVLCPlayer: using bridging headers with framework targets is unsupported The error doesn't occur with Cocoapods 1.4.

The only big difference I can find is 1.4 sets TVVLCPlayer's product type as a static library, while 1.5 sets it as a framework. Once I set the productType to com.apple.product-type.library.static and add the 'Setup Static Framework' build phase back in the project file, the library then compiles fine.

Crash: Could not find a storyboard named 'TVVLCPlayer' in bundle

I've found a reproducible crash when presenting TVVLCPlayerViewController from a segue. After 5 or 6 separate presentations, the following exception is thrown:

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Could not find a storyboard named 'TVVLCPlayer' in bundle NSBundle </Users/weiran/Library/Developer/CoreSimulator/Devices/134AC1D7-2515-49E4-9A33-64C9E3D0105B/data/Containers/Bundle/Application/CE356116-96E3-4692-8E26-D4439CCFF2F1/WatchItLater.app/TVVLCPlayer.bundle> (not yet loaded)'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010d72ca56 __exceptionPreprocess + 294
	1   libobjc.A.dylib                     0x000000010c66c031 objc_exception_throw + 48
	2   UIKit                               0x000000010a6d46d6 +[UIStoryboard storyboardWithName:bundle:] + 672
	3   UIKit                               0x000000010a6d4b9c -[UIStoryboard instantiateViewControllerReferencedByPlaceholderWithIdentifier:] + 87
	4   UIKit                               0x000000010a482993 -[UIStoryboardViewControllerPlaceholder initWithCoder:] + 143
	5   UIKit                               0x000000010a4dafe8 UINibDecoderDecodeObjectForValue + 704
	6   UIKit                               0x000000010a4dad1b -[UINibDecoder decodeObjectForKey:] + 246
	7   UIKit                               0x000000010a2ad1a2 -[UIRuntimeConnection initWithCoder:] + 178
	8   UIKit                               0x000000010a4dafe8 UINibDecoderDecodeObjectForValue + 704
	9   UIKit                               0x000000010a4db186 UINibDecoderDecodeObjectForValue + 1118
	10  UIKit                               0x000000010a4dad1b -[UINibDecoder decodeObjectForKey:] + 246
	11  UIKit                               0x000000010a2ac393 -[UINib instantiateWithOwner:options:] + 1262
	12  UIKit                               0x000000010a6d4d1a -[UIStoryboard instantiateViewControllerWithIdentifier:] + 181
	13  UIKit                               0x000000010a6ddd71 -[UIStoryboardSegueTemplate instantiateOrFindDestinationViewControllerWithSender:] + 90
	14  UIKit                               0x000000010a6ddfb5 -[UIStoryboardSegueTemplate _perform:] + 52
	15  UIKit                               0x000000010a025678 -[UIViewController performSegueWithIdentifier:sender:] + 99
	16  WatchItLater                        0x00000001055f8731 _T012WatchItLater20DetailViewControllerC15showVideoPlayer33_ABE5D1BE521D8FB44C277C60855AA8DELLySiSg9startFrom_tF + 449
	17  WatchItLater                        0x00000001055f8f0e _T012WatchItLater20DetailViewControllerC021playFromPositionAlertF033_ABE5D1BE521D8FB44C277C60855AA8DELLSo07UIAlertF0CSgAA5VideoCFySo0T6ActionCcfU_ + 62
	18  WatchItLater                        0x00000001055fd791 _T012WatchItLater20DetailViewControllerC021playFromPositionAlertF033_ABE5D1BE521D8FB44C277C60855AA8DELLSo07UIAlertF0CSgAA5VideoCFySo0T6ActionCcfU_TA + 17
	19  WatchItLater                        0x00000001055e6292 _T0So13UIAlertActionCIegx_ABIeyBy_TR + 66
	20  UIKit                               0x000000010a20290e -[UIAlertController _invokeHandlersForAction:] + 105
	21  UIKit                               0x000000010a203313 __103-[UIAlertController _dismissAnimated:triggeringAction:triggeredByPopoverDimmingView:dismissCompletion:]_block_invoke.457 + 16
	22  UIKit                               0x0000000109ff5f4a -[UIPresentationController transitionDidFinish:] + 1346
	23  UIKit                               0x0000000109ff9dba __56-[UIPresentationController runTransitionForCurrentState]_block_invoke.430 + 183
	24  UIKit                               0x000000010aaa5eda -[_UIViewControllerTransitionContext completeTransition:] + 102
	25  UIKit                               0x0000000109f5541d -[UIViewAnimationBlockDelegate _didEndBlockAnimation:finished:context:] + 859
	26  UIKit                               0x0000000109f28499 -[UIViewAnimationState sendDelegateAnimationDidStop:finished:] + 343
	27  UIKit                               0x0000000109f28adc -[UIViewAnimationState animationDidStop:finished:] + 293
	28  UIKit                               0x0000000109f28b90 -[UIViewAnimationState animationDidStop:finished:] + 473
	29  QuartzCore                          0x000000010e416d07 _ZN2CA5Layer23run_animation_callbacksEPv + 323
	30  libdispatch.dylib                   0x000000010f367848 _dispatch_client_callout + 8
	31  libdispatch.dylib                   0x000000010f37292b _dispatch_main_queue_callback_4CF + 628
	32  CoreFoundation                      0x000000010d6ef509 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
	33  CoreFoundation                      0x000000010d6b3716 __CFRunLoopRun + 2342
	34  CoreFoundation                      0x000000010d6b2b7b CFRunLoopRunSpecific + 635
	35  GraphicsServices                    0x000000011028ca73 GSEventRunModal + 62
	36  UIKit                               0x0000000109e98214 UIApplicationMain + 159
	37  WatchItLater                        0x00000001055f0617 main + 55
	38  libdyld.dylib                       0x000000010f3e3d99 start + 1
	39  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Video Plays after few seconds of audio play

As title states video plays late than audio, plus zapping time is too much.

How to get controls like screenshots?

How do i get controls like screenshot and scrubbing with remote.

On the new tvOS 14.2, tapping Menu exits to the Apple TV homescreen instead of back

It seems that something is broken with latest tvOS 14.2. Menu is not properly detected and exits the app. Play button not recognised so you can't pause and seek to a different position

the panelview can't focus on tabbar navigation by swiftUI

on tvos, when creating navbar navigation view, then navigationLink to your VLCPlayer view. When you start to play video, the panel of subtitle and audio panel can't focus, if you select subtitle track,you can't focus subtitle delay selector list.

rtsp/rtmp support?

Hi. Thanks you for great library. Does you lib support rtsp/rtmp?

Some users of my app reported that the tvOS screensaver shows while they are watching a movie

I push the viewcontroller in the navigationcontroller to show it fullscreen, the class VLCPlayerViewController set the view of the VLCPlayer with the UIView that occupies the full screen.
Some users experiment this issue that the screensaver shows.

Do i need to do?
UIApplication.shared.isIdleTimerDisabled = false in viewWillAppear
UIApplication.shared.isIdleTimerDisabled = true in viewWillDissapear

[!] Unable to find a specification for `TVVLCPlayer (~> 1.0.2)`

Hello. I go to https://cocoapods.org/ and find TVVLCPlayer but it's not found. Can you help?