koldakov/futuramaapi

Futurama inspired REST and GraphQL API, blending characters exploration with real-time updates. Tech playground featuring FastAPI, Docker, and more!

Follow me:

futuramaapi's Issues

relationship will copy column to column which conflicts with relationship(s)

sys:1: SAWarning: relationship 'Episode.characters' will copy column episodes.id to column episode_character_association.episode_id, which conflicts with relationship(s): 'EpisodeCharacterAssociation.episode' (copies episodes.id to episode_character_association.episode_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards. To silence this warning, add the parameter 'overlaps="episode"' to the 'Episode.characters' relationship. (Background on this warning at: https://sqlalche.me/e/20/qzyx) (This warning originated from the configure_mappers() process, which was invoked automatically in response to a user-initiated operation.)

As I understand this warning is useless, but anyway need to check deeply

Tokens infrastructure

Currently futuramaapi.routers.tokens.schemas.DecodedUserToken has only 2 types: access and refresh.

Shall activate/password change/other token have it's own type?

From the 1 hand with activate/password change token people can access users info, but from the other hand that's an access token itself. Not sure about the logic here

Migrate to SQLModel

After closing #3 we need to check if SQLModel can be used

fastapi pagination improvement

When it's used it's not really limit the select, but retrieves all rows from DB and limits the result, which is not good.

    return await paginate(
        session,
        select(CharacterModel)
        .order_by(
            CharacterModel.get_order_by(
                field=order_by,
                direction=direction,
            )
        )
        .where(
            *get_characters_cond(
                gender=gender,
                character_status=character_status,
                species=species,
                query=query,
            )
        ),
    )

So this part of the code should be fixed, here should be a limit.