kommitters/editorjs-inline-image

Unsplash inline images plugin for editorjs

editorjs-inline-image's Issues

Please add typescript support

I am working on a big project so I need typescript support . I tried to rewrite the library to typescript but failed . Please write this library in typescript . If you need help , I will also help . Please bro , rewrite this library in typescript .

Update dependencies with potential security vulnerabilities

Context

https://github.com/kommitters/editorjs-inline-image/security/dependabot

Objective

To keep the library up-to-date by updating dependencies in response to these alerts.

spesific request image size

Is your feature request related to a problem? Please describe.

How to query a specific image size? Because if I take all the images from Unsplash, some of the images are very tall, I want certain images to be Landscape size.

Add tab for file upload

I am currently using both https://github.com/editor-js/image and this tool since I want to offer both upload from file and Unsplash search.
I would prefer to have image upload from file like in editorjs-image available as first tab in this tool.

Add read-only mode support

Please ref.: https://editorjs.io/configuration#read-only-mode

Citing from it:

Each of the Block Tools you use MUST support the read-only mode to enable this mode in the editor.

Provide image select callback

Is your feature request related to a problem? Please describe.

I am trying to change selected image url. The url has some parameters, I have to add 'q' parameter in order to change image quality or fetch compressed image from unsplash

https://unsplash.com/blog/the-5-minute-guide-to-image-quality/

Describe the solution you'd like

I need a callback receiving selected image data and returning changed block data, which will be given to the editor for rendering. In other words, we can add callback, which will be called after image select action and before giving the block data to the editor

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Add read-only mode support

Context

The recent EditorJS version has included a readOnly property. Ref.

Objective

To add support to this new property

Security Policy violation SECURITY.md

This issue was automatically created by Allstar.

Security Policy Violation
Security policy not enabled.
A SECURITY.md file can give users information about what constitutes a vulnerability and how to report one securely so that information about a bug is not publicly visible. Examples of secure reporting methods include using an issue tracker with private issue support, or encrypted email with a published key.

To fix this, add a SECURITY.md file that explains how to handle vulnerabilities found in your repository. Go to https://github.com/kommitters/editorjs-inline-image/security/policy to enable.

For more information, see https://docs.github.com/en/code-security/getting-started/adding-a-security-policy-to-your-repository.

---

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

Can i disable embedding images from urls

Hello, as the title says, i want to disable embedding images from external urls. I just want to use unsplash feature. Is it possible?

Update dependencies with potential security vulnerabilities

Context

https://github.com/kommitters/editorjs-inline-image/security/dependabot

Objective

To keep the library up-to-date by updating dependencies in response to these alerts.

Security Policy violation Branch Protection

This issue was automatically created by Allstar.

Security Policy Violation
Dismiss stale reviews not configured for branch main

---

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

¿Could I connect a tool to publish to npm automatically?

Hi

The main idea is to use GitHub Action to publish automatically when a new release is created.

Thanks

The CSS sheet style is not being injected in the DOM

Description

Because of the css-loader dependence was uptated to solve vulnerabilities, the CSS sheet style is not being injected in the DOM, it is necessary to update style-loader as well.

🚨 DO NOT LEAK YOUR UNSPLASH API KEYS 🚨

According to unsplash's documentation, you should NOT leave your API keys in client side, like this plugin intends.

I would recommend forking the original code and making your own library

Update dependencies with potential security vulnerabilities

Context

https://github.com/kommitters/editorjs-inline-image/security/dependabot

Objective

To keep the library up-to-date by updating dependencies in response to these alerts.

Update dependencies with potential security vulnerabilities

Context

https://github.com/kommitters/editorjs-inline-image/security/dependabot

Objective

To keep the library up-to-date by updating dependencies in response to these alerts.

Add workflow for automatic publishing in npm

Is your feature request related to a problem? Please describe.

Currently, the publishing process to the NPM library hub is done manually.

Describe the solution you'd like

Add workflow for automatic publishing in npm when the release on Github is created.

Describe alternatives you've considered

https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages

Image zoom when clicked

Is your feature request related to a problem? Please describe.

Could you please add an ability to zoom in the image when clicked?

That would be great if image can be scaled up when user clicks it during read mode.

Custom apiUrl Example

Is your feature request related to a problem? Please describe.

Unsplash is great but what if my pictures/images/video are stored on my server/cloud? I see that config.apiUrl can be whatever I want. But how the apiUrl response should look like? Are paths of inserted media relative or absolute? What if I drag and drop a media inside editorjs from the same page (list of available images for example)?

Describe the solution you'd like

Maybe adding a dedicated "Custom apiUrl" section in the README.md including the following:

Expected response example:

{
  "id": "myuniqueid",
  "width": imgwidth,
  "height": imgheight,
  "urls": {
    "full": "articles/1/img/myimage.jpg",
    "thumb": "articles/1/img/myimage_thumb.jpg"
  },
},
{
  "id": "myuniqueid2",
  "width": imgwidth,
  "height": imgheight,
  "urls": {
    "full": "articles/1/img/myimage2.jpg",
    "thumb": "articles/1/img/myimage2_thumb.jpg"
  },
}

other custom apiUrl config options like:
config.imageAddedPath= "absolute/relative",
// option for path option? isn't better for local ressources to have relative paths so it's easier to maintain? host can be adapted on backend (dev server, prod server, amazon bucket, etc...)`

drag and drop from list on the same page:
config.imageDropped= "data or path",
// it would be great to have an option to have the relative path inserted like <img src="/img/example.jpg" instead of having image inserted as <img src="data:image/jpg;base64,...

Update dependencies with potential security vulnerabilities

Context

https://github.com/kommitters/editorjs-inline-image/security/dependabot

Objective

To keep the library up-to-date by updating dependencies in response to these alerts.