korvinm/pp-keep

WordPressPlugin modifying how Private Posts are displayed

pp-keep's Issues

Refactor to avoid duplicating check on user cap

The if statement

if( current_user_can( 'read_private_posts' ) ){
  //do something
}

is used twice in the plugin. First in the class PPKeep to wrap the contents of the function rem_pp()
and secondly in the class PP_Keep_Widget to wrap the contents of the function widget() so that the widget is not output on the front end for users without that capability.
How can this be refactored so the if statement only needs using once?

Some functions depend on the user not changing a page title

The class PPKeep has a function, create() which creates a page.
The function returns a variable like so:

$insert_post = wp_insert_post( $post, true);//now you can use $post_id within add_post_meta or update_post_meta 
return $insert_post;    

There are a couple of places elsewhere in the plugin where I am interacting with this page.
in the class PP_Keep_Widget, the widget includes a link to the page.
In the deactivation hook I am deleting the page. In both cases I am getting the page using the page title. However this depends on the user neither changing the title nor deleting the page, which cannot be guaranteed. I'm not coding defensively, as the saying goes.

I would really like to access the return variable from the create() function instead as at least using the ID of the post would be a bit more like it. It wouldn't defend against the user deleting the page but it would still work if the user has changed the page title.

But I don't know how to access the variable outside the class.