Comments (4)
Oh my, I can't believe I somehow missed this and am just seeing this now!
Anyways, thanks a lot Nitzan, this is some really thought-provoking feedback. Agree 100% about the 404.
About the 2 sprites for each pokemon - We really liked the aesthetic of the other kind of "banner" sprite and it is 100% intentional.
About your last point I actually did it on March 22nd (commit id: dfae0c6 title : "display message for trying to view empty collection") and forgot to host this build! Talk about the importance of a good and automated workflow...
from react-pokedex.
I took care of it and the version with the display message is now deployed so you can check it out if you'd like. Thanks again for the great feedback. :)
P.S The 2 sprites are just great for the vertical flexbox style on mobile in my opinion, what do you think? Would you leave the 2 sprites or just keep 1?
from react-pokedex.
Looks awesome but I prefer one. If you really liked the sharper sprites (the bottom ones) just use them instead 👍
from react-pokedex.
Okay thank you! I'll talk to @michefraim about it and I think we'll go with keeping 2 sprites for mobile and maybe 1 for bigger screens.
from react-pokedex.
Related Issues (2)
- Feedabck HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-pokedex.