Giter Site home page Giter Site logo

react-pokedex's People

Contributors

kosta1221 avatar

Watchers

 avatar

react-pokedex's Issues

Feedabck

Great work, Here is what you can do to improve:
dont chage things on react using DOM this is a bad practice in react
Indentation is too right
delete commented code
more Error messages

Requirements and style feedback

Amazing job guys ๐Ÿ‘
Smooth UX, beautiful UI and a very good pokedex!
A few notes:

  • Great implementation of sprites bonus
  • The auto complete is very cool and looks good
  • Spinner smooth and done correctly
  • 404 message is too simple ๐Ÿ‘Ž We wanted a cool one!
  • Why are you fetching two sprites for each pokemon?
  • When collection is empty a small yellow with blue border div is displayed. Isn't a message ("No pokemon caught!") would be nicer?

@kosta1221
@michefraim

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.