kotlin-polytech/kotlinasfirst

Задачи для онлайн-курса "Котлин как первый язык программирования"

kotlinasfirst's Issues

Remove or fill TODO at the end of chapter 5

lesson5.task1.plusMinus: consider allowing signed numbers.

Currently, to strictly check input string for correctness a student has to perform two checks:

• try to call toInt() on number (to check format and integer range) and throw IllegalArgumentException if NumberFormatException happens;
• match with regex (something like [0-9]+) (to forbid signed numbers (+1, -7 etc.)), throw IAE if number does not match this regex.

Most students usually do not do at least one of those and it is rarely noted by teachers. A possible bug can only be found by random tests in some rare cases.

This can be solved two ways:

• provide some non random tests (like 1 + +3, 12 + -2, 121212121212121212121 + 3). (I'm not sure if JUnit's assertThrows will allow us to check if IAE but not NFE is thrown)
• consider the first two examples correct inputs (and everything accepted by .toInt()). (This way we have to update the model implementation since it tries to strictly check input string).

Think about evaluation system in 2017

In 2016 we had some issues about this. In particular, people tend to solve a lot of tasks in first lessons and then try to solve 1-2 easiest in second half.

Fix mostExpensive task

First, clarify that price can be without dot. Also, diagnostic message in tests should be fixed,

Upgrade kotlin version to 1.1.4

After release

lesson5.task1: Reorder tasks by difficulty

Add leading zeroes to lesson numbers

Most directory viewers now sort the lessons as following:

• lesson1
• lesson10
• lesson2
• lesson3
• ...
• lesson9

which is a bit frustrating.

Adding leading zeroes would solve this problem:

• lesson01
• lesson02
• lesson03
• ...
• lesson09
• lesson10

Add lesson about data-like classes

Lesson 4: consider to convert Double to Int in tasks

This will help to stabilize tests, and in these tasks Double adds not so much to understanding something

Add lessons or tasks about maps

It's useful in general, important for some file tasks (lesson 8), important for examination.

Синхронизировать анаграммы с палиндромами

См. один из последних коммитов Кирилла

dateStrToDigit/dateDigitToStr

Specify that day should be correct (e.g. 31.02.2001 and 29.02.2001 should be incorrect). Maybe enforce that with new task in lesson2 (daysInMonth(month: Int, year: Int))

Clarify lesson7.task2.rotate

Should we rotate matrix in-place or return a copy?

Rename 'grad' to 'deg' in angleInRadian

clarify transliterate

What should we do with case in dictionary values when they are non-lower case? Should we call .capitalize() or .toLowerCase().capitalize()?

chapter04: лямбды

Нужно пояснение, почему параметр-лямбда не заключён в круглые скобки и когда это возможно.

Lesson 4: make roman numbers as in standard description

Choose and attach license

(2017) Create separate module for each lesson or even for each task

To be able to compile a lesson or a task regardless of other lessons / tasks current state

Clarify description and add shorter complex test for top20Words

• Clarify description: Is hello inside hello42 a word? (Not it's unclear if we should treat it as a word or just ignore it).
• Add test shorter than Eugene Onegin but that covers corner case (punctuation after word, Ё letter, hello42 case etc.)

Add inspection configuration file to repo

And think a little bit about this configuration. For example, "LoopToCallChain" must be disabled.

factorizeToString: divisors order

Clarify that divisros in factorizeToString should be in ascending order.

Lesson 6: some geometry data classes are broken

• Currently Line equality is broken. Point(α * x, α * y), angle + π * n for ∀α ∈ ℝ, ∀n ∈ ℤ represent the same line.
  k*x + b might work better but still isn't perfect ((-Inf) * x + b and (+Inf) * x + b represent the same line)
• Triangle and Segment equality comparison should be independent from the order of the points (for Segment it matters in diameter tests).

Make lesson3.digitNumber easy, not trivial

Too much people solve it wrong in the first attempt

Migrate to official code style

Provide information about KiB, MiB, etc

Clarify description of pow

In Kotlin 1.2+, pow is an extension and called as x.pow(y)

Move lesson about files earlier

Reasons:

• it's needed for examination
• it's an advancement of lesson about text parsing (5)

Synchronize with test runner

Also better to wait until the beginning of September

Provide better reference list

May be it's a good idea to have one large reference list in README (and at some place of Coursera course(s)), and one shorter reference list per tutorial chapter.

Tests for lesson5.buildGrades

They should sort the function results

Update chapter 0 accordingly to infrastructure changes

Add lesson about console applications with command line

Lesson should include task stubs, tests, and tutorial chapter. Probably it should have number 9, later we will discuss should we remove current lesson 7 or leave it as optional.

convertToString/decimalFromString: explicitly forbid to use stdlib functions

These tasks now can be solved using one line with standard library function which is probably not what we expect from students here.

Switch on "use expression body" inspection

It currently has "no highlighting, fix only" status in 1.1.4 by default

Kotlin Algorithm Club

Здравствуйте,
Я поддерживаю небольшой проект, посвящённый алгоритмам и структурам данных в kotlin. Возможно, он будет полезен в вашем курсе.
Ваш бывший студент =)

Line init block: replace assert with require

https://github.com/Kotlin-Polytech/KotlinAsFirst/blob/master/src/lesson6/task1/Geometry.kt#L120

Assertions are disabled in JVM by default and requireing is more correct.

Move task to lesson 3

Гипотеза Коллатца

/**
* Рекуррентная последовательность чисел задана следующим образом:
*
*   ЕСЛИ (X четное)
*     Xслед = X /2
*   ИНАЧЕ
*     Xслед = 3 * X + 1
*
* например
*   15 46 23 70 35 106 53 160 80 40 20 10 5 16 8 4 2 1 4 2 1 4 2 1 ...
* Данная последовательность рано или поздно встречает X == 1.
* Написать функцию, которая находит, сколько шагов требуется для
* этого для какого-либо начального X > 0.
*
* Имя функции и тип результата функции предложить самостоятельно.
*
* Кроме функции, следует написать тесты, 
* подтверждающие её работоспособность.
*/
fun myFun(x: Int): Any = TODO()

Random tests for lesson5.findCheapestStuff must consider the possibility of two things with the same price

Create fork for 2017 and move 2017.begin accordingly

Something like Kotoed2017. Better to wait until 04-09-2017 or something like this.

Write explicitly for all relevant lesson 3 task: do NOT use string functions

chapter01: дискриминант

Для примера их использования рассмотрим решение задачи вычисления дискриминанта квадратного уравнения. Математически он равен квадратному корню из b²-4ac.

Дискриминант равен b²-4ac (не корню из), а при вычислении корней используется корень из дискриминанта.

Remove slides (and all relevant commits) from repo

May be, together with algorithm lessons, it will lead to migration to another repo, like KotoedCourse or so.

Add test with squareBetweenExists with m or n as exact square

Map lesson

Update JUnit 5 version to release one

They had RC2 on July 30, soon we can expect release version

Add extra lessons for algorithms

See JavaKotlinASD repo.

lesson5.task1.whoAreInBoth: specify behavior for lists with repeats

Migrate from Maven to Gradle

It's controversial but otherwise it's unclear how can we use inspection plugin. Some part of this work is already done in gradle branch.

Add lesson about container classes