Giter Site home page Giter Site logo

Not accessible about gifffer HOT 4 CLOSED

ThibaultJanBeyer avatar ThibaultJanBeyer commented on September 10, 2024
Not accessible

from gifffer.

Comments (4)

krasimir avatar krasimir commented on September 10, 2024

The <button> suggestion is a nice one and I made that change (1.2.1 version released). I'm a little bit puzzled about the second step. Can you please clarify on that.

from gifffer.

ThibaultJanBeyer avatar ThibaultJanBeyer commented on September 10, 2024

right, so normal images have an "alt" Attribute. See <img src="img.gif" alt="some text">, if a blind user traverse the page, his screen reader will read aloud that alt attribute: 'some text, img'. Now with gifffer we lose that alt attribute. An Idea would be to have something like this: <img data-gifffer="image.gif" data-gifffer-alt="some text" /> and using that information in code to populate the gifffer with a visually hidden text. Simplified something like this: <container><playbutton /><canvas /><visuallyhidden>some text</visuallyhidden></container> (obviously with real tags, these are only to clarify the example) so that some text remains there. Which is also a good practice for SEO… Then, it actually makes more sense to make the playbutton a button, not the whole div and hide the playbutton for screen readers (since blind users do not need to play the gif, they just need access to the alt text and having a playbutton they don’t know what it does might confuse them). If you want, I can make a pull request this weekend with that addition, what do you think?

from gifffer.

krasimir avatar krasimir commented on September 10, 2024

I see. The container-to-button is already done. I'll be happy to see a PR for the alt text.

from gifffer.

ThibaultJanBeyer avatar ThibaultJanBeyer commented on September 10, 2024

You may close this issue now πŸ‘

from gifffer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.