krestomatio/moodle-local_tier

Moodle plugin to control user registrations, storage quotas, and administrative access restrictions system-wide

moodle-local_tier's Issues

Storage limit not working

Moodle 4.3.2
Plugin: 0.0.5
2024012200

Config:

$CFG->forced_plugin_settings = [
"local_tier" => [
"max_storage_bytes" => "5000000",
],
];

Ran the \local_tier\task\total_storage_task task manually, tried uploading a 480MB file using a teacher account which should vastly exceed the limit set above but upload was permitted. Values before the upload showed (after the task had ran):

totalstoragebytes
841410019

total_databasebytes
14450688

total_filesbytes
826959331

scheduled task set by default to run every minute.

The total storage task is set to run every minute by default. I'd suspect this could be relaxed a bit and only run every hour - not many tasks in Moodle should be set to run every minute - it just unnecessarily slows the cron process down and puts extra load on the server.

not a blocker for approval.

Naming collisions

https://moodledev.io/general/community/plugincontribution/checklist#namespace-collisions

The locallib.php file contains a number of incorrectly named functions - all functions should use the frankenstyle naming prefix to prevent collisions with core code.

Note this is a blocker for plugins db approval.

postgres specific functions in sql queries

pg_database_size is a postgres specific function.

plugins submitted to the plugins db must support postgresql and mysql-based databases - at a bare minimum you could disable that feature when your plugin is installed in a mysql based db, but ideally you'd handle that with a mysql compatible function.

note - this is a blocker for plugins db approval.