kristijanhusak/deoplete-phpactor

Phpactor integration for deoplete.nvim

Hi there 👋

deoplete-phpactor's Issues

PHP Path

I seem to have issues when using this with php5 but not php7. I know that phpactor lets me set the php bin path that I want to use. Does this line say to use the php found in your path? If so, can we use phpactor's g:phpactorPhpBin instead?

phpactorOmniAutoClassImport not working

What works:

I configured vim/neovim phpactorOmniAutoClassImport with vim-mucomplete successfully.
Follow steps described in README, deoplete-phpactor works, deoplete did complete with phpactor.

What's not working

When I press <CR> to accept completion (deoplete default), it didn't import class for me.

What I've tracked

phpactor set an autocmd to trigger auto class importing. I've checked that the value of v:completed_item are almost the same (only different is that deoplete prepend [phpactor] for value of key menu).

It may failed caused by the hash_key.
By the way, manually call phpactor#_completeImportClass(v:completed_item) didn't import the class as well.

I'm not fimilar with vim script, but hope this helps.

error

NVIM v0.2.2

[deoplete] Traceback (most recent call last):^@ File "/home/wenchao/.vim/plugged/deoplete.nvim/rplugin/python3/deoplete/child.py", line 220
, in _gather_results^@ ctx['candidates'] = source.gather_candidates(ctx)^@ File "/home/wenchao/.vim/plugged/deoplete-phpactor/rplugin/py
thon3/deoplete/source/phpactor.py", line 66, in gather_candidates^@ result = result['parameters']['value']^@keyerror: 'value'^@error from
phpactor: KeyError('value',). Use :messages / see above for error details.

Constructor completion

Works very well, thanks for the plugin. I have an issue though when typing a constructor I don't have any completion.

Sort results

The results from this plugin aren't in any particular order, it's not a huge deal but padawan sorts them so it's easier to navigate.

(See below where completions are coming from both phpactor and padawan)

Error on any completion

NVIM v0.3.1

Error from phpactor: JSONDecodeError('Expecting value: line 1 column 1 (char 0)').  Use :messages / see above for error details.
[deoplete] Traceback (most recent call last):
  File "~/.config/nvim/plugged/deoplete.nvim/rplugin/python3/deoplete/child.py", line 179, in _gather_results
    result = self._get_result(context, source)
  File "~/.config/nvim/plugged/deoplete.nvim/rplugin/python3/deoplete/child.py", line 234, in _get_result
    ctx['candidates'] = source.gather_candidates(ctx)
  File "~/.config/nvim/plugged/deoplete-phpactor/rplugin/python3/deoplete/source/phpactor.py", line 65, in gather_candidates
    result = json.loads(result.decode())
  File "/usr/local/Cellar/python/3.7.1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/usr/local/Cellar/python/3.7.1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/Cellar/python/3.7.1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)