Whiff % is showing 0% for all pitches

[kruser]

Whiff % is showing 0% for all pitches

[albertlyu]

Looks like pitchStats.js was missing:

if (pitch.isWhiff())
{
    aggregator.whiff++;
}

I'm not sure why. I'll investigate. I'm guessing I didn't have an updated local repo when I submitted my pull request.

[albertlyu]

See commit 5e0f497 for the last time whiffs were being aggregated.

pitchfx-site/app/app/scripts/controllers/pitchStats.js

Lines 428 to 440 in 5e0f497

	if (pitch.isSwing())
	{
	aggregator.swing++;
	/*jshint maxdepth:5 */
	if (pitch.isWhiff())
	{
	aggregator.whiff++;
	if ((!havePitchTypeFilters || pitchTypeFilters[pitchCode]) && angular.isDefined(pitch.px) && angular.isDefined(pitch.pz))
	{
	whiffSeries.push([pitch.px, pitch.pz]);
	}
	}
	}

When ec62105 was pushed to master, the whiff stats were wiped out. I believe the intention was to remove the whiffSeries object, but in doing so, aggregator.whiff++; was also removed. 5e0f497...ec62105#diff-112bb635c769a65c5ead2fd78f47975aR210

I believe the fix would be to add the following to L330-L333 at https://github.com/kruser/pitchfx-site/blob/master/app/app/scripts/controllers/pitchStats.js#L330-L333:

if (pitch.isSwing()) {
    aggregator.swing++;
    if (pitch.isWhiff()) {
        aggregator.whiff++;
    }
}

I will submit a pull request with these changes later today, for @kruser's review.

[kruser]

deploying to site now. I only see you on the site @albertlyu so it's safe to deploy.

FYI, if you don't want to show up on my Google Analytics you can always opt-out on Chrome. That's what I do.
https://tools.google.com/dlpage/gaoptout