Comments (3)
Looks like pitchStats.js was missing:
if (pitch.isWhiff())
{
aggregator.whiff++;
}
I'm not sure why. I'll investigate. I'm guessing I didn't have an updated local repo when I submitted my pull request.
from pitchfx-site.
See commit 5e0f497 for the last time whiffs were being aggregated.
pitchfx-site/app/app/scripts/controllers/pitchStats.js
Lines 428 to 440 in 5e0f497
When ec62105 was pushed to master, the whiff stats were wiped out. I believe the intention was to remove the whiffSeries
object, but in doing so, aggregator.whiff++;
was also removed. 5e0f497...ec62105#diff-112bb635c769a65c5ead2fd78f47975aR210
I believe the fix would be to add the following to L330-L333 at https://github.com/kruser/pitchfx-site/blob/master/app/app/scripts/controllers/pitchStats.js#L330-L333:
if (pitch.isSwing()) {
aggregator.swing++;
if (pitch.isWhiff()) {
aggregator.whiff++;
}
}
I will submit a pull request with these changes later today, for @kruser's review.
from pitchfx-site.
deploying to site now. I only see you on the site @albertlyu so it's safe to deploy.
FYI, if you don't want to show up on my Google Analytics you can always opt-out on Chrome. That's what I do.
https://tools.google.com/dlpage/gaoptout
from pitchfx-site.
Related Issues (20)
- New Domain/Site Name HOT 3
- New Zone Charts - BABIP, wOBA, etc. HOT 27
- Improve Filters on Mobile
- Improve Heatmap Pickers for Mobile HOT 1
- Create a Logo for BaseballMod.com HOT 22
- Heatmap for Called Strikes? HOT 9
- Standardize max heat for charts HOT 1
- Group the different pitch heatmaps HOT 5
- Add totals to pitch table HOT 2
- Improve discoverability on the home page HOT 22
- Pitch Count Heatmap HOT 16
- Site down: Tried accessing roster API with invalid team HOT 3
- Highcharts heatmaps HOT 3
- Use bower to install highcharts/highmaps
- Choose a color pallete for batted ball trajectories HOT 2
- Choose a color pallete for pitch types HOT 1
- Clarify team buttons on home page HOT 2
- Datepicker default date range off? HOT 1
- Roster not returning when last game was rained out HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pitchfx-site.