kschu91/largest-remainder-method

A PHP implementation of the largest remainder method algorithm.

largest-remainder-method's Issues

Greater than 0 precision do not sum up to 100?

On the readme you give the example:

[
    18.562874251497007,
    20.958083832335326,
    18.562874251497007,
    19.161676646706585,
    22.75449101796407
]

Which, with a precision of 2, results in

Array
(
    [0] => 18.55
    [1] => 20.94
    [2] => 18.55
    [3] => 19.15
    [4] => 22.74
)

But this sums up to 99.93. Shouldn't it be 100? Seems like precision with anything other than 0 does not work.

not getting an expected result with 2 numbers

		$numbers = [
			23.98,
			23.98,
		];
		$lr = new LargestRemainder($numbers);

		$result = $lr->round();

		$this->assertSame(array_sum($result), 47.0);

Both numbers are getting rounded to 24.0 where I expect them to be 24, 23. Is this a bug or am I using this incorrectly?

Simple failing test case with precision 2 and 2 values

$lr = new Aeq\LargestRemainder\Math\LargestRemainder([0.015, 0.015]);
$lr->setPrecision(2);
print_r($lr->round());

Expected result: [0.02. 0.01]
Actual result: [0.0, 0.0]