ksp-ro/rolibrary

Library for shared code among the ROx family of mods.

ROLibrary

Library for shared code among the ROx family of mods.

rolibrary's Issues

NullReferenceException spam at ROLib.ModuleROTank.OnFixedUpdate after update v1.7.0

I get a constant NullReferenceException spam whenever i decouple a stage with RO-Tanks.
It happens on multiple crafts & multiple stages.

It started after i updated the following mods to their most recent versions.
RO-Tanks (v2.10.0), ROLibrary (v1.7.0), RealFules (v15.6.2), RealismOverhaul (v17.0.0.0), and RP-1 (v2.7.0).

Module ModuleROTank threw during OnFixedUpdate: System.NullReferenceException: Object reference not set to an instance of an object
  at ROLib.ModuleROTank.OnFixedUpdate () [0x0000b] in <8a9ef8a4ef4e4608b4c4d1eac39f6efb>:0 
  at Part.ModulesOnFixedUpdate () [0x000bd] in <4b449f2841f84227adfaad3149c8fdba>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

The exceptions and the launch of the craft start in part 3 of the log.

Player_pt1.log
Player_pt2.log
Player_pt3.log

Auto decouple log spam

This line is probably missing a pair of parentheses.

Changing the Core slider for an ROTank causes the tank to visibly change length

Steel modular ROTank. Changing the Core slider between 1.0x Kerolox and 0.25x Kerolox cause the tank to visibly change length. Note that the fuel mass doesn't change, and the length slider doesn't change. If I nudge the length slider slightly the tank resizes back to the correct length. There are other possibly related issues detailed below.

Discord discussion starts at https://discord.com/channels/319857228905447436/620690446540341261/988130866989531187

Images.
Starting with the core set to 8.0x-Kerolox

Cycling to the next Core (1.0x-Kerolox) option with via the RH ">>" button. Note how the tank reinforcement looks too long.

Cycling to the next Core option (0.25x-Kerolox). Note the visual change in length, without a change in Mass or dV, how the texture changes and that the CoreTex slider disappears from the PAW.

If I nudge the length slider slightly (eg 11.61m) the visual length is now correct.

Thanks for all your work on RO/RP-1.