kste/sphincs

Optimized implementations for cryptographic hash functions for the use in hash-based signature schemes.

sphincs's Issues

Using Keccak-P1600 Rho constant in Keccak-P800

sphincs/x86/crypto_sign/sphincs256keccak/avx2/KeccakP-800-times8-SIMD256.c

Line 177 in ee5af8e

ROL32in256(Bbe, A##ge, 44); \

There exists some errors in this file. The rho offset for Keccak-P800 should module 32 which means all the constants should smaller than 32. But I found that in https://github.com/kste/sphincs/blob/ee5af8e9cffecb33f3eecd0908b86c673ced3f63/x86/crypto_sign/sphincs256keccak/avx2/KeccakP-800-times8-SIMD256.c, some of the constants are larger than 31. Also, I look at the Keccak-P1600 implementation and find out that its constants are being used in Keccak-P800.

The above implementation error leads to the fail verification of SPHINCS when instantiate with Keccak-P800 (I tested it myself).

SHA256 HMAC?

This is an interesting project. Do you know of any assembly-optimized AVX2 version of SHA256 HMAC?