kstover/jammming

CodeCademy Jammming coursework

jammming's Issues

Summary - Exceeds Expectations

You did a really good job on your project. Looking at your code is seems like the majority is 100% yours and nothing from the answer key. Great job adding extra functionality like searching on enter being hit. I really liked your documentation throughout the entire project. You show clear understanding of React fundamentals like passing props and rendering children. All in all, awesome work!

Spotify.js

Awesome job on your Spotify.js file. I like that you used jsDocs to describe what the code was doing. It looks very professional!

State Mutation

In you App.js file you mutate state:

// updatePlaylist fn

playlist = this.state.playlist;
playlist.push( item );
this.setState( { playlist: playlist } );

playlist is a direct reference and not a new copy of this.state.playlist. Anything done to playlist will happen to this.state.playlist. Therefore you must do something like:

const playlist = [ ...this.state.playlist ];
const playlist = this.state.playlist.slice();

Either one of these will return a NEW array. When you use the array method filter that returns a new array so that line is correct (line 68).

Documentation / Comments

Great job adding all of the comments/docs to your code. It looks really good and gives the reader an explanation of what everything does. Very clean!