kubernetes-retired/csi-lib-fc

[EOL] A go package that can be imported to help CSI plugins with connecting to fibre channel devices

CSI lib-fc

A go package that can be imported to help CSI plugins with connecting to fibre channel devices. Simply import it and get access to the necessary functions

Goals

Provide a basic, lightweight library for CSI Plugin Authors to leverage some of the common tasks on a node like connecting and disconnecting fibre channel devices.

We intentionally avoid pulling in additional dependencies, and we intend to be stateless and as such are not using receivers. Currently the focus is strictly based on a CSI context.

Design Philosophy

The idea is to keep this as lightweight and generic as possible. We intentionally avoid the use of any third party libraries or packages in this project. We don't have a vendor directory, because we attempt to rely only on the std golang libs. This may prove to not be ideal, and may be changed over time, but initially it's a worthwhile goal.

Community, discussion, contribution, and support

Learn how to engage with the Kubernetes community on the community page.

You can reach the maintainers of this project at:

• Slack
  • sig-storage
  • wg-csi
• Mailing List

Code of conduct

Participation in the Kubernetes community is governed by the Kubernetes Code of Conduct.

csi-lib-fc's Issues

Broken Link of `contributor cheat sheet` need to fix

Bug Report

I have observed same kind of issue in various kubernetes-csi project.
this happens because after the localization there are too much modifications done in the various directories.
I have observed same issue in this page also.

It has one broken link of the contributes cheat sheet which needs to fix.
I will try to look in further csi repo as well and try to fix it as soon as I can

/kind bug
/assign

Condition not handled when `FindMultipathDeviceForDevice` returns nil error

No handling added when FindMultipathDeviceForDevice not returning any error : https://github.com/kubernetes-csi/csi-lib-fc/blob/fe8a7253a266e8fc6d39c8ada3df9cf89b381b9c/fibrechannel/fibrechannel.go#L211

if name == FcPath {
   disk, err := io.EvalSymlinks(DevID + name)
    if err != nil {
    glog.Errorf("fc: failed to find a corresponding disk from symlink[%s], error %v", DevID+name, err)
    return "", ""
    }
    if dm, err1 := FindMultipathDeviceForDevice(disk, io); err1 != nil {
    return disk, dm
    }
}

Expected fix:

dm, err1 := FindMultipathDeviceForDevice(disk, io)
    if err1 != nil {
    glog.Errorf("fc: failed to find a multipath disk for %s, error %v", disk, err)
    return disk, ""
}
return disk, dm