kubernetes-sigs/container-object-storage-interface-csi-adapter

CSI driver to bootstrap COSI workloads

container-object-storage-interface-csi-adapter's Issues

Add deployment yamls

Create deployment yamls that will deploy the csi adapter that can be used to deploy just those components, or be part of a global deploy that would deploy all of object storage.

Other components of object storage have been using kustomize to do this, so this needs to fit into that scheme.

Issue/PR Templates

This repo should have Issue/PR templates similar to the other COSI repositories. This will make the process for opening up issues (and resolving them) more streamlined and consistent. repository

Better error codes on failure

Currently, we are using the gRPC internal error code for most of the errors. This is not really good practice, and we should instead replace these with using more informative/relevant error codes.

CSI Node Failure and the BA Finalizer

We are planning on adding a finalizer onto the Bucket Access Publish and removing the finalizer on Unpublish. But the behavior of this when the node dies is undefined. We are using ephemeral volumes, with the VolumeID as a part of the finalizer.

At an initial glance, if the pod is rescheduled with the same VolumeID onto another node, then we do not have any issues. We just need to validate that this is the behavior, and if it is not, plan another way to address this issue.

Build COSI Adapter using CSI Ephemeral Volume

Prototype a CSI driver for the purpose of injecting provisioned bucket endpoint and credential into a Pod.

Add deployment documentation

Now that kustomize files have been added to the root of the project, we need a getting started guide which explains how to deploy and concerns around it. The deployment step itself is a single command now:

  kubectl create -k github.com/kubernetes-sigs/container-object-csi-adapter

KEP partity with code:

• container-object-storage-interface-csi-adapater should be archived

Emit events for provisoner on pod

Enhancement

Is your feature request related to a problem?/Why is this needed
We should provide feedback from the provisioner to the application pod when a COSI bucket is being created

Describe the solution you'd like in detail
TBD

Describe alternatives you've considered
This is more of a nice to have than required, we should provide feedback for UX where possible.

RBAC rules for CSI adapter needs updates

It looks like in fc868d0#diff-184694ad6baa9738a47d41dde3dfaa5f8d8ecccd555520740748c51c7d31223bR163 (from #32) code was added which retrieved Pod information from the apiserver from inside the CSI driver. However, the related RBAC manifest wasn't updated to let the objectstorage-csi-adapter-sa get the "pods" resource, causing a Pod consuming a B/BA not to start:

Events:
  Type     Reason       Age              From                         Message
  ----     ------       ----             ----                         -------
  Normal   Scheduled    5s               default-scheduler            Successfully assigned default/object-storage-consumer to kind-control-plane
  Warning  FailedMount  1s (x4 over 5s)  kubelet, kind-control-plane  MountVolume.SetUp failed for volume "cosi-secrets" : rpc error: code = FailedPrecondition desc = pods "object-storage-consumer" is forbidden: User "system:serviceaccount:default:objectstorage-csi-adapter-sa" cannot get resource "pods" in API group "" in the namespace "default"

Adding this to the ClusterRole in resources/rbac.yaml likely fixes this (untested, I can do a PR later).

What happened: CI for cosi-driver-sample fails

What you expected to happen: CI for cosi-driver-sample to succeed

How to reproduce this bug (as minimally and precisely as possible): Run a driver with the sidecar and the CSI adapter, then run a basic scenario launching a Pod consuming a Bucket

Environment:

• Kubernetes version (use kubectl version), please list client and server: 1.20.2
• CSI Adapter version (provide the release tag or commit hash): Canary
• Provisoner name and version (provide the release tag or commit hash): cosi-driver-sample, custom branch

Add unit tests for finalizer logic in CSI Adapter

Add CI for this project

Add finalizer for Bucket

We need to add and remove a finalized for the volumeId during the on publish/unpublish steps respectively.

Update README.md

The current readme.md is out of date, and does not give guidelines for new persons interested in the project to easily get started and contribute.