Comments (4)
/assign
from kubebuilder.
From my local reproducing, the error is:
INFO Running make:
$ make generate
/Users/tonyjin/pro/tmp/kb/bin/controller-gen-v0.14.0 object:headerFile="hack/boilerplate.go.txt" paths="./..."
Next: implement your new Webhook and generate the manifests with:
$ make manifests
/Users/tonyjin/pro/tmp/kb/bin/controller-gen-v0.14.0 rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
tutorial.kubebuilder.io/project/api/v1:-: CRD for CronJob.batch.tutorial.kubebuilder.io has no storage version
Error: not all generators ran successfully
run `controller-gen rbac:roleName=manager-role crd webhook paths=./... output:crd:artifacts:config=config/crd/bases -w` to see all available markers, or `controller-gen rbac:roleName=manager-role crd webhook paths=./... output:crd:artifacts:config=config/crd/bases -h` for usage
make: *** [manifests] Error 1
I think it is a similar issue to:
#1196
So, when following https://book.kubebuilder.io/multiversion-tutorial/api-changes.html#storage-versions, adding //+kubebuilder:storageversion
can help:
from kubebuilder.
This are the steps to build our tutorial https://github.com/kubernetes-sigs/kubebuilder/tree/master/docs/book/src/multiversion-tutorial sample.
After add the store it still failing in the e2e test regards the tests added for the webhook.
So, here in this task we need to
- Find the solution and fix it in the scaffolds
- Manually update the tutorial by running the script https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/multiversion-tutorial/testdata/generate_multiversion.sh (sadly it still not done with the make generate which is the last step that we need to close #2510) and then compare master branch with our changes to manually add on top the docs info and code implementation of examples
- Then, push the PR and ensure that it will pass in all tests. See that we have e2e tests to validate the book samples with basic stuff and that fails. So, we need also address any required change in the sample and/or scaffold to ensure that all works fine and pass in the CI tests.
It could be a good first issue for someone that would like to spend so effort and get something that is not so trivial and requires investigation.
Help here is very welcome !!!!
from kubebuilder.
Hi @Kavinjsir
You are 100% . It is the same: #1196.
The problem that I was facing was with the default tests scaffold for the the controller . It was missing declare the resource properly. See; https://github.com/kubernetes-sigs/kubebuilder/actions/runs/8844368662/job/24286141139?pr=3875
I could fix this one, but the tests for the controller still failing
I will raise I new issue with a better description
We need to implement the tests for the controller to ensure that the reconciliation of the sample is accurate.
from kubebuilder.
Related Issues (20)
- Generate alpha command do not respect API namespacing HOT 2
- End to End Test should check Kubecontext before Proceeding HOT 1
- Create testdata sample for samples in the reference links HOT 4
- Support `objectSelector` in webhook's code markers HOT 2
- v2 vs v3 page is TODO HOT 3
- Fail do "kubebuilder init" in 4.0.0 HOT 2
- Updating config in PostScaffold is ignored HOT 2
- Allow Custom Marker Prefix HOT 2
- Improve Default .golangci.yml Configuration to Exclude lll Linter for kubebuilder Markers HOT 3
- Why set namespace with kustomize for cluster-scoped Mutating|ValidatingWebhookConfiguration? HOT 4
- Stacking of work queue metrics in grafana dashboard is confusing HOT 3
- kubebuilder should use 1.22.0 instead of 1.22 HOT 2
- Improved test support for 3rd party apps HOT 2
- update webhook marker docs HOT 2
- [Typo]: migration_guide_gov3_to_gov4.md doc HOT 1
- "@[" in scaffolded Makefile results in `bash: line 1: @[: command not found` HOT 4
- The CustomResourceDefinition name is too long: must have at most 262144 bytes HOT 1
- Update Cronjob and Multiversion Tutorials samples to Use Status Conditions HOT 1
- Conditionally Enable `filters.WithAuthenticationAndAuthorization` Only When `secureMetrics` is True HOT 6
- role.yaml doesn't contain all CRDs, and "make" nukes any fixes HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubebuilder.