Evaludate and Apply Latest Lint Rules and Features

[Kavinjsir]

Evaludate and Apply Latest Lint Rules and Features

[camilamacedo86]

I think kind/cleanup is OK. 🥇

If the motivation came from the bump #3846
see that the fixes applied are accurate.

• We should not use . to import but we have one exception then in this case we need configure to ignore
• When args are not used we should use _

That are the only checks that the whole code and samples fails after the update and seems that is more related those files are been ignored before in the lint instead of changes in the lint persei.

I think that the only thing that we could do is to check if we can ignore the specific scenario

	// nolint:revive
	. "github.com/onsi/ginkgo/v2"
	// nolint:revive
	. "github.com/onsi/gomega"

Via config like

[rule.dot-imports]
  arguments = [{ allowedPackages = ["github.com/onsi/ginkgo/v2","github.com/onsi/gomega"] }]

As you suggested. But the checks shows fine.
Wdyt? Also, I agree with you. If the goal here is to do this change only I think it is a good-first-issue (adding the label :-) )

[Kavinjsir]

@camilamacedo86 I'm not sure how to tag, this seems not suitable to be kind/feature. And we may consider it as good-first-issue :)

[prashantrewar]

Hey @camilamacedo86 and @Kavinjsir, I'm interested. Could you please guide me on this issue?

Thank you!

[prashantrewar]

/assign

[Kavinjsir]

@camilamacedo86 Sounds good to me!

• We should not use . to import but we have one exception then in this case we need configure to ignore

To stay align with your concern, we may add comment like:

[rule.dot-imports]
  # dot import should be ONLY allowed for ginkgo testing packages
  arguments = [{ allowedPackages = ["github.com/onsi/ginkgo/v2","github.com/onsi/gomega"] }]