Helm -- nodeSelector not applied to windows daemonset

[petercable]

Helm -- nodeSelector not applied to windows daemonset

[petercable]

sig-storage-local-static-provisioner/helm/provisioner/templates/daemonset_windows.yaml

Lines 35 to 36 in 3ea2ccc

	nodeSelector:
	kubernetes.io/os: windows

[mauriciopoppe]

I think adding

{{- if .Values.daemonset.nodeSelector }}
        {{ toYaml .Values.daemonset.nodeSelector | nindent 8 }}
{{- end }}

should work but at the same time you could have Linux vs Windows specific node selector key values, another option is to go with

{{- if .Values.daemonset.nodeSelectorWindows }}
        {{ toYaml .Values.daemonset.nodeSelectorWindows | nindent 8 }}
{{- end }}

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[mauriciopoppe]

This should be fixed in #353, check the release notes in that PR and the helm installation docs