Comments (6)
Thanks for the feature request, I think we could add this as .common.enableWindows: false
in the helm chart. I'll add some tags so that someone can help with this.
from sig-storage-local-static-provisioner.
Hey @mauriciopoppe, thanks for doing that!
from sig-storage-local-static-provisioner.
Hi @mauriciopoppe, I would like to contribute to this PR as my first issues in sig-storage-local-static-provisioner
.
from sig-storage-local-static-provisioner.
/assign
from sig-storage-local-static-provisioner.
After reading the source code, we might wanna add a new config field in ProvisionerConfiguration
for enableWindwos bool
or UserConfig
or even RuntimeConfig
if this field ever needs to be passed down to deeper levels into controller or discoverer or informer. Not very sure where is the entry point for disabling this Windows Daemonset in the source code, perhaps I need some help/guidance into this. I am willing to complete this feature request.
from sig-storage-local-static-provisioner.
Looks like a simple add of enableWindows
in helm value common.{..}
and in daemonset_windows.yaml
should do the job. I have opened a small PR for this new feature here #388. Needs approval for ok-to-test
flag. Thank you :)
from sig-storage-local-static-provisioner.
Related Issues (20)
- Move examples to have all of them in a single location HOT 5
- Release Helm chart for v2.5.0 HOT 5
- Transition Windows daemonset to become a HostProcess container HOT 4
- Helm -- nodeSelector not applied to windows daemonset HOT 4
- Remove generation code for helm v2 HOT 1
- Missing doc on 2.5.0 version compatibility with K8s versions in readme.md HOT 1
- v2.5.0 Release breaks helm chart, version, etc. and provides v2.4.0 application HOT 2
- Switch from k8s.gcr.io to registry.k8s.io HOT 1
- Use Helm chart manifests in the e2e tests HOT 6
- Please help me HOT 9
- Can't scrape metrics for more than 1000 nodes HOT 4
- Multiple PersistentVolumes from single local device HOT 7
- Take ownership of the Helm repo on Artifact Hub HOT 8
- Deletion of PVCs on statefulsetscale-up due to low intervals HOT 8
- Failed to discover local volumes: failed to get ReclaimPolicy from storage class "fast-disks": storageclass.storage.k8s.io "fast-disks" not found HOT 1
- 0/1 nodes are available: 1 node(s) didn't find available persistent volumes to bind. HOT 3
- Fix Critical CVE-2019-8457 by upgrading base image to debian-base:bookworm-v1.0.1
- node-cleanup deleter process repeatedly deleting unused, but valid PVs HOT 1
- Any plans to cut a new release soon? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sig-storage-local-static-provisioner.