Giter Site home page Giter Site logo

Comments (6)

mauriciopoppe avatar mauriciopoppe commented on June 17, 2024

Thanks for the feature request, I think we could add this as .common.enableWindows: false in the helm chart. I'll add some tags so that someone can help with this.

from sig-storage-local-static-provisioner.

evanfoster avatar evanfoster commented on June 17, 2024

Hey @mauriciopoppe, thanks for doing that!

from sig-storage-local-static-provisioner.

jennwah avatar jennwah commented on June 17, 2024

Hi @mauriciopoppe, I would like to contribute to this PR as my first issues in sig-storage-local-static-provisioner.

from sig-storage-local-static-provisioner.

jennwah avatar jennwah commented on June 17, 2024

/assign

from sig-storage-local-static-provisioner.

jennwah avatar jennwah commented on June 17, 2024

After reading the source code, we might wanna add a new config field in ProvisionerConfiguration for enableWindwos bool or UserConfig or even RuntimeConfig if this field ever needs to be passed down to deeper levels into controller or discoverer or informer. Not very sure where is the entry point for disabling this Windows Daemonset in the source code, perhaps I need some help/guidance into this. I am willing to complete this feature request.

@mauriciopoppe

from sig-storage-local-static-provisioner.

jennwah avatar jennwah commented on June 17, 2024

Looks like a simple add of enableWindows in helm value common.{..} and in daemonset_windows.yaml should do the job. I have opened a small PR for this new feature here #388. Needs approval for ok-to-test flag. Thank you :)

from sig-storage-local-static-provisioner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.