kubernetes/csi-translation-lib

Staging repo for CSI Migration/Translation libraries

Purpose

This repository contains functions to be consumed by various Kubernetes and out-of-tree CSI components like external provisioner to facilitate migration of code from Kubernetes In-tree plugin code to CSI plugin repositories.

Consumers of this repository can make use of functions like TranslateToCSI and TranslateToInTree functions to translate PV sources.

Community, discussion, contribution, and support

Learn how to engage with the Kubernetes community on the community page.

You can reach the maintainers of this repository at:

• Slack: #sig-storage (on https://kubernetes.slack.com -- get an invite at slack.kubernetes.io)
• Mailing List: https://groups.google.com/forum/#!forum/kubernetes-sig-storage

Code of Conduct

Participation in the Kubernetes community is governed by the Kubernetes Code of Conduct.

Contibution Guidelines

See CONTRIBUTING.md for more information.

csi-translation-lib's Issues

Unknown allowedTopologies cause an error

Unknown allowedTopology labels cause translation to fail: https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/in_tree_volume.go#L329

However, on GKE other labels are sometimes used in PV node affinity, such as kubernetes.io/hostname or kubernetes.io/os. It's not common (100s of clusters as of July 2021), but seems enough that it should be dealt with.

The suggestion is to just pass unknown topologies through. If they are used in the storageclass labels they will cause failures, but that is the current gce-pd behavior anyway.

This reasoning probably holds for other clouds as well, although I haven't tested it myself.

/assign @mattcary