kubevirt/kubevirt-tekton-tasks

VM specific tasks for Tekton Pipelines

KubeVirt Tekton Tasks

Tekton Pipelines are CI/CD-style pipelines for Kubernetes. This repository provides KubeVirt-specific Tekton tasks, which focus on:

• Creating and managing resources (VMs, DataVolumes, DataSources)
• Executing commands in VMs
• Manipulating disk images with libguestfs tools

Deployment

In order to install the KubeVirt Tekton tasks in the active namespace you need to apply the following manifest. You have to repeat this for every namespace in which you'd like to run the tasks.

VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt-tekton-tasks/releases | \
            jq '.[] | select(.prerelease==false) | .tag_name' | sort -V | tail -n1 | tr -d '"')
kubectl apply -f "https://github.com/kubevirt/kubevirt-tekton-tasks/releases/download/${VERSION}/kubevirt-tekton-tasks.yaml"

Visit RBAC permissions for running the tasks if the pipeline needs to create/access resources (VMs, PVCs, etc.) in a different namespace other than the one the pipeline runs in.

Usage

copy-template, modify-vm-template and create-vm-from-template tasks are deprecated and will be removed in future versions. These tasks based on templates will be replaced with create-vm task with enhancements related to instance types.

Create Virtual Machines

• create-vm-from-manifest
• create-vm-from-template

Utilize Templates

• copy-template
• modify-vm-template

Modify data objects

• modify-data-object

Generate SSH Keys

• generate-ssh-keys

Execute Commands in Virtual Machines

• execute-in-vm: execute commands over SSH
• cleanup-vm: execute commands and/or stop/delete VMs

Manipulate PVCs with libguestfs tools

• disk-virt-customize: execute virt-customize commands in PVCs
• disk-virt-sysprep: execute virt-sysprep commands in PVCs

Wait for Virtual Machine Instance Status

• wait-for-vmi-status

Modify Windows iso

• modify-windows-iso-file - modifies windows iso (replaces prompt bootloader with no-promt bootloader) and replaces original iso in PVC with updated one.

Examples

Windows EFI Installer Pipeline

Downloads a Windows ISO file into a PVC and automatically installs Windows 10, 11 or Server 2k22 with EFI enabled by using a custom Answer file into a new base DataVolume. Supported Windows versions: Windows 10, 11, Server 2k22

Windows Customize Pipeline

Applies customizations to an existing Windows 10, 11, Server 2k22 installation by using a custom Answer file and creates a new base DataVolume. Supported Windows versions: Windows 10, 11, Server 2k22

Unit Tester Pipeline - Unmaintained

Good unit tests are detached from the operating system and can run everywhere. However, this is not always the case. Your tests may require access to entire operating system, or run as root, or need a specific kernel.

This example shows how you can run your tests in your VM of choice. The pipeline creates a VM, connects to it over SSH and runs tests inside it. It also showcases the finally construct.

Server Deployer Pipeline - Unmaintained

For complex application server deployments it might be easier to start the server as is in a VM rather than converting it to cloud-native application.

This example shows how you can initialize/modify a PVC and deploy such application in a VM.

Virt-sysprep Updater Pipeline - Unmaintained

Virt-sysprep can be used for preparing VM images which can be then used as base images for other VMs.

This example shows how you can update an operating system and seal VM's image by using virt-customize. Then, a VM is created from such image.

Development Guide

See Getting Started for the environment setup and development workflow.

kubevirt-tekton-tasks's Issues

modify-vm-template is using wrong getters for Template labels and annotations

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:

Specifying parameter templateAnnotations has no effect when running modify-vm-template task.

What you expected to happen:

templateAnnotations get applied to Template when runinng modify-vm-template task.

How to reproduce it (as minimally and precisely as possible):

Run modify-vm-template task and specify templateAnnotations.

Anything else we need to know?:

setValuesToTemplate() is using the wrong getters here:

kubevirt-tekton-tasks/modules/modify-vm-template/pkg/templates/template-provider.go

Line 96 in 5e9c414

labels := t.cliOptions.GetVMLabels()

kubevirt-tekton-tasks/modules/modify-vm-template/pkg/templates/template-provider.go

Line 99 in 5e9c414

annotations := t.cliOptions.GetVMAnnotations()

getTemplateLabels() and getTemplateAnnotations() should be used.

Replace clusterTasks with Tasks

Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement

ClusterTasks are deprecated and replaced with Tasks - https://tekton.dev/docs/pipelines/tasks/#task-vs-clustertask.
We will have make sure clusterTasks are replaced with tasks.

Pipeline keeps running when copy-template Task fails

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:

copy-template Task failed because the template it tried to create already existed. After that the Pipeline stayed in state Running.

What you expected to happen:

The Pipeline switches to state Failed when copy-template Task failed.

How to reproduce it (as minimally and precisely as possible):

• Create template (e.g. with name testtemplate)
• Run copy-template Task with parameter targetTemplateName set to testtemplate

Downstream related information should be removed

https://github.com/kubevirt/kubevirt-tekton-tasks/blame/main/README.md#L24-L34

We should not maintain downstream documentation

Align kubevirt tekton tasks with instance types

Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement

Align kubevirt tekton tasks with instance types.
Common templates will be deprecated in some future version and we should make sure, kubevirt tekton tasks should work with https://github.com/kubevirt/common-instancetypes

make top level examples generated

Add ability to create VM from remote manifest

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind enhancement

What happened:
I would like to use the create-vm-from-manifest task to create a VM while providing a remote manifest instead of having to supply the manifest content directly.

What you expected to happen:

Supply a remote url to a manifest instead of having to provide the YAML to the task directly.

How to reproduce it (as minimally and precisely as possible):
See above

Anything else we need to know?:
N/A

Environment:

• KubeVirt version (use virtctl version):
• Kubernetes version (use kubectl version):
• tekton-pipelines version:
• kubevirt-tekton-tasks version:
• Pipeline/Taskrun specification:
• PipelineRun/TaskRun specification:
• CDI version if applicable:
• Cloud provider or hardware configuration:

Enable loading of pipelines from yaml in tests

Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement

What happened:
Enable loading of pipelines from yaml files in e2e tests, so user doesn't have to specify it in code

create-datavolume task: reimplement in go

• add early detection of failed datavolume imports

add support for including sshPublicKey secret in create-vm-from-template task

per #31 (comment) discussion, it should be possible to specify the sshPublicKey secret name in task parameters and the secret will be used by the VM to inject authorized keys

could be implemented either by

• specifying the accessCredentials in the VM manifest/template and then just injecting the secret name
• specifying accessCredentials API (propagationMethod, users, secretName) in the task parameters

The disadvantage of the later one is that it bloats the number of task parameters

Even though this feature is usable through the VM manifest in create-vm-from-manifest (see unit-tester-pipeline.yaml) we should probably make the feature set compatible with create-vm-from-template regarding this issue.

create-vm-tasks: possibility to specify bootOrder, bus and other configuration for appended disks

two options

• pass disk/volume definitions in task params - this would be probably too difficult to use
• specify the disk/volume definitions in the VM/Template yaml and replace a stub pvc/dv name with the real one
  • persistentVolumeClaims could be specified either standalone or with diskName selector, eg.

  - name: persistentVolumeClaims
    value:
      - "generated-pvc-1"
      - "disk-a:generated-pvc-2"
  

make more detailed examples

make all YAML examples generated

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all dependencies (main) (fedora, github.com/onsi/ginkgo/v2, github.com/onsi/gomega, github.com/openshift/api, github.com/openshift/client-go, github.com/tektoncd/pipeline, k8s.io/api, k8s.io/apimachinery, k8s.io/cli-runtime, k8s.io/client-go, k8s.io/kube-openapi, k8s.io/kubectl, knative.dev/pkg, kubevirt.io/api, kubevirt.io/client-go, kubevirt.io/containerized-data-importer, kubevirt.io/containerized-data-importer-api, kubevirt.io/kubevirt, quay.io/kubevirt/libguestfs-tools)

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update module kubevirt.io/kubevirt to v1.2.1 [security] (release-v0.17)
• chore(deps): update module kubevirt.io/kubevirt to v1.2.1 [security] (release-v0.15)

Detected dependencies

Branch main

dockerfile

automation/generatetasks/build/Dockerfile

• fedora 41

build/Containerfile

build/Containerfile.DiskVirt

• quay.io/kubevirt/libguestfs-tools v1.3.0

github-actions

.github/workflows/release.yaml

• actions/checkout v4
• actions/setup-go v5
• bruceadams/get-release v1.3.2
• actions/upload-release-asset v1

.github/workflows/test-yaml-consistency.yaml

• actions/checkout v4

.github/workflows/validate-no-offensive-lang.yml

• actions/checkout v4

gomod

go.mod

• go 1.22.4
• k8s.io/client-go v0.30.3
• k8s.io/kube-openapi v0.0.0-20240709000822-3c01b740850f@3c01b740850f
• k8s.io/kubectl v0.30.3
• github.com/openshift/api v0.0.0-20240722135205-ae4f370f361f@ae4f370f361f
• github.com/openshift/client-go v0.0.0-20240528061634-b054aa794d87@b054aa794d87
• github.com/alexflint/go-arg v1.5.1
• github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510@e7afc7fbc510
• github.com/onsi/ginkgo/v2 v2.19.0
• github.com/onsi/gomega v1.33.1
• github.com/openshift/api v3.9.0+incompatible
• github.com/openshift/client-go v3.9.0+incompatible
• github.com/spf13/cobra v1.8.1
• github.com/tektoncd/pipeline v0.61.1
• go.uber.org/zap v1.27.0
• k8s.io/api v0.30.3
• k8s.io/apimachinery v0.30.3
• k8s.io/cli-runtime v0.30.3
• k8s.io/client-go v12.0.0+incompatible
• knative.dev/pkg v0.0.0-20240716082220-4355f0c73608@4355f0c73608
• kubevirt.io/api v1.3.0
• kubevirt.io/client-go v1.3.0
• kubevirt.io/containerized-data-importer v1.59.0
• kubevirt.io/containerized-data-importer-api v1.59.0
• kubevirt.io/kubevirt v1.3.0
• kubevirt.io/qe-tools v0.1.8
• sigs.k8s.io/yaml v1.4.0

Branch release-v0.17

dockerfile

automation/generatetasks/build/Dockerfile

build/Containerfile

build/Containerfile.DiskVirt

github-actions

.github/workflows/release.yaml

.github/workflows/validate-no-offensive-lang.yml

gomod

modules/copy-template/go.mod

modules/create-vm/go.mod

• kubevirt.io/kubevirt v1.1.0

modules/disk-virt-customize/go.mod

modules/disk-virt-sysprep/go.mod

modules/execute-in-vm/go.mod

modules/generate-ssh-keys/go.mod

modules/modify-data-object/go.mod

modules/modify-vm-template/go.mod

modules/shared/go.mod

modules/sharedtest/go.mod

modules/wait-for-vmi-status/go.mod

Branch release-v0.15

dockerfile

automation/generatetasks/build/Dockerfile

build/Containerfile

build/Containerfile.DiskVirt

github-actions

.github/workflows/release.yaml

.github/workflows/validate-no-offensive-lang.yml

gomod

modules/copy-template/go.mod

modules/create-vm/go.mod

• kubevirt.io/kubevirt v1.0.0-alpha.0

modules/disk-virt-customize/go.mod

modules/disk-virt-sysprep/go.mod

modules/execute-in-vm/go.mod

modules/generate-ssh-keys/go.mod

modules/modify-data-object/go.mod

modules/modify-vm-template/go.mod

modules/shared/go.mod

modules/sharedtest/go.mod

modules/wait-for-vmi-status/go.mod

Branch release-v0.13

dockerfile

automation/generatetasks/build/Dockerfile

modules/copy-template/build/copy-template/Dockerfile

modules/create-vm/build/create-vm/Dockerfile

modules/disk-virt-customize/build/disk-virt-customize/Dockerfile

modules/disk-virt-sysprep/build/disk-virt-sysprep/Dockerfile

modules/execute-in-vm/build/execute-in-vm/Dockerfile

modules/generate-ssh-keys/build/generate-ssh-keys/Dockerfile

modules/modify-data-object/build/modify-data-object/Dockerfile

modules/modify-vm-template/build/modify-vm-template/Dockerfile

modules/wait-for-vmi-status/build/wait-for-vmi-status/Dockerfile

github-actions

.github/workflows/release.yaml

.github/workflows/validate-no-offensive-lang.yml

gomod

modules/copy-template/go.mod

modules/create-vm/go.mod

modules/disk-virt-customize/go.mod

modules/disk-virt-sysprep/go.mod

modules/execute-in-vm/go.mod

modules/generate-ssh-keys/go.mod

modules/modify-data-object/go.mod

modules/modify-vm-template/go.mod

modules/shared/go.mod

modules/sharedtest/go.mod

modules/wait-for-vmi-status/go.mod

Branch release-v0.12

dockerfile

automation/generatetasks/build/Dockerfile

modules/copy-template/build/copy-template/Dockerfile

modules/create-vm/build/create-vm/Dockerfile

modules/disk-virt-customize/build/disk-virt-customize/Dockerfile

modules/disk-virt-sysprep/build/disk-virt-sysprep/Dockerfile

modules/execute-in-vm/build/execute-in-vm/Dockerfile

modules/generate-ssh-keys/build/generate-ssh-keys/Dockerfile

modules/modify-data-object/build/modify-data-object/Dockerfile

modules/modify-vm-template/build/modify-vm-template/Dockerfile

modules/wait-for-vmi-status/build/wait-for-vmi-status/Dockerfile

github-actions

.github/workflows/release.yaml

.github/workflows/validate-no-offensive-lang.yml

gomod

modules/copy-template/go.mod

modules/create-vm/go.mod

modules/disk-virt-customize/go.mod

modules/disk-virt-sysprep/go.mod

modules/execute-in-vm/go.mod

modules/generate-ssh-keys/go.mod

modules/modify-data-object/go.mod

modules/modify-vm-template/go.mod

modules/shared/go.mod

modules/sharedtest/go.mod

modules/wait-for-vmi-status/go.mod

create-datavolume-from-manifest should be able to overwrite existing DV

Is this a BUG REPORT or FEATURE REQUEST?:

/kind enhancement

What happened:

If a pipelines tries to update an existing PV, the pipeline fails

What you expected to happen:

The pipeline can explicitly allow to overwrite or replace the DV

How to reproduce it (as minimally and precisely as possible):

run https://github.com/kubevirt/tekton-tasks-operator/blob/main/data/tekton-pipelines/okd/windows10-installer.yaml twice.

Replace spec.running with spec.runStrategy

Replace spec.running with spec.runStrategy because spec.running will be deprecated later. Similar issue was opened in common-templates repository, kubevirt/common-templates#581.

create-data-object fails to wait for objects with generateName

/kind bug

What happened:

I was trying to run example pipelines, but windows10-customize pipeline fails on create-data-object task with Failed to wait for success of data object: resource name may not be empty

What you expected to happen:

Succesfully run pipeline

How to reproduce it (as minimally and precisely as possible):

Running the TTO example pipelines

Allow Kubernetes's built-in ssh-auth secret type

KubeVirt Tekton Tasks currently requires SSH credentials to be stored as an "Opaque" secret type with its own, project-specific fields. This means one cannot reuse SSH credentials from other contexts.

How about defaulting to (or at least allowing) Kubernetes's built-in "kubernetes.io/ssh-auth" type [1], meaning to allow secrets to be specified as:

apiVersion: v1
kind: Secret
metadata:
  name: secret-ssh-auth
type: kubernetes.io/ssh-auth
data:
  ssh-privatekey: |
    LS0tLS1CRUdJTiBPUEVOU1NI ...
  ssh-publickey: |
    U0bVBRUk82dUs5Y2ZWRWhDZU ...

[1] https://kubernetes.io/docs/concepts/configuration/secret/#ssh-authentication-secrets

Setting latest release version from README.md instructions fails with 404

/kind bug

What happened:
Got

error: unable to read URL "https://github.com/kubevirt/kubevirt-tekton-tasks/releases/download//kubevirt-tekton-tasks-okd.yaml", server reported 404 Not Found, status code=404

because curl -s https://github.com/kubevirt/kubevirt-tekton-tasks/releases/latest returns an empty string

because there is no release tagged "latest"

What you expected to happen:
Example instructions in the repo's base README.md should work as expected.

How to reproduce it (as minimally and precisely as possible):

VERSION=$(curl -s https://github.com/kubevirt/kubevirt-tekton-tasks/releases/latest | grep -o "v[0-9]\.[0-9]*\.[0-9]*")
kubectl apply -n default -f "https://github.com/kubevirt/kubevirt-tekton-tasks/releases/download/${VERSION}/kubevirt-tekton-tasks-okd.yaml"

Anything else we need to know?:

Should be straight-forward...

Environment:

not applicable, this is before k8s gets involved.

Enable artifacthub linter

What happened:
Enable artifacthub linter once artifacthub/hub#3691 is resolved

Rebase on https://github.com/kubevirt/libguestfs-appliance

We should consume https://github.com/kubevirt/libguestfs-appliance as the base image for this.

Reasoning is that somebody is taking care of the appliance, we can benefit from this

Pipelinerun in example folder fails

/kind bug

What happened:

When I was trying to start pipelineRuns in example folder error occured:
admission webhook "webhook.pipeline.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "serviceAccountNames"

What you expected to happen:

Start the pipeline

How to reproduce it (as minimally and precisely as possible):

Follow example instructions at https://github.com/kubevirt/kubevirt-tekton-tasks/tree/main/examples/pipelines/windows10-installer

Pipeline run fails with probable RBAC issue

/kind bug

What happened:
Trying to use windows10-installer example from repo in OCP 4.10 fails in task create-vm-from-manifest with:

could not add owner reference to windows10-source-4wl8x DataVolume: datavolumes.cdi.kubevirt.io "windows10-source-4wl8x" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>

What you expected to happen:

Creation of VM

How to reproduce it (as minimally and precisely as possible):

Follow example instructions at https://github.com/kubevirt/kubevirt-tekton-tasks/tree/main/examples/pipelines/windows10-installer

Anything else we need to know?:

Environment:

• KubeVirt version (use virtctl version):

Client Version: version.Info{GitVersion:"v0.44.3-5-gaa60cafdd", GitCommit:"aa60cafddc1040b434f5b7ca40fa49c8174adb61", GitTreeState:"clean", BuildDate:"2021-10-30T17:55:57Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{GitVersion:"v0.49.0-163-gb0553b0f5", GitCommit:"b0553b0f5e5c7c091e7107382073bba7d9be3f43", GitTreeState:"clean", BuildDate:"2022-05-19T18:19:30Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}

• Kubernetes version (use kubectl version):

$ oc version
Client Version: 4.10.18
Server Version: 4.10.18
Kubernetes Version: v1.23.5+3afdacb

• tekton-pipelines version:

$ tkn version
Client version: 0.23.1
Pipeline version: v0.33.2
Triggers version: v0.19.0
Operator version: v0.55.1

• kubevirt-tekton-tasks version: current main

• Pipeline/Taskrun specification:

• PipelineRun/TaskRun specification:

• CDI version if applicable:

• Cloud provider or hardware configuration:

e2e tests using deprecated kubevirt.io/v1alpha3 API

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

In recent CI e2e tests I saw a lot of the following warnings:

   Begin Captured StdOut/StdErr Output >>
    W0907 16:46:20.074423   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.098179   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.138689   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.177835   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.216410   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.255660   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.294724   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.338697   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.384938   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.423593   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.462486   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.501779   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.541326   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.687683   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:28.888890   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:29.089729   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:29.288497   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:29.488375   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:29.687316   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:29.887855   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:30.088860   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:30.290910   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:30.496281   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
    W0907 16:46:30.695252   14888 warnings.go:70] kubevirt.io/v1alpha3 is now deprecated and will be removed in a future release.
  << End Captured StdOut/StdErr Output 

This should be investigated. Perhaps the tests are using an outdated kubevirt client version?

What you expected to happen:

The e2e tests should use the kubevirt.io/v1 API.

add smoke tests for released images

add new test to the CI

• will use latest published images (instead of the ones compiled on the spot from the PR like the other tests)
• simple smoke tests (one negative + one positive use case for each task/image ? )
• could be periodic and not tied to the PR (eg once a week?)
• could test example pipelines

add multi namespace example pipeline

create an example pipeline which use concepts explained in https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/docs/tasks-rbac-permissions.md

• the pipeline should access/create resources in different namespaces
• the pipeline should explain on how to deploy and setup the tasks/namespaces for this pipeline

virt-sysprep: base image missing `perl` binary for `edit` customization

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

What happened:
virt-sysprep ClusterTask fails if an edit command is passed in. virt-sysprep and virt-customize allow for non-interactive editing of a file like so and requires perl to be installed:

 edit /some/file:s/^OPT=.*/OPT=ok/

https://github.com/rwmjones/guestfs-tools/blob/3a498512f58bc431db490e96cdb712b19389bda4/customize/perl_edit-c.c#L42
https://github.com/rwmjones/guestfs-tools/blob/3a498512f58bc431db490e96cdb712b19389bda4/customize/perl_edit.ml#L22-L30

Should the perl binary be included in kubevirt/libguestfs-tools? I can't seem to find where this image lives.

kubevirt-tekton-tasks/modules/disk-virt-sysprep/build/disk-virt-sysprep/Dockerfile

Line 19 in 07b8ea3

FROM quay.io/kubevirt/libguestfs-tools:v0.49.0

What you expected to happen:
success :)

How to reproduce it (as minimally and precisely as possible):

---
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  name: kmi-pipeline
spec:
  tasks:
    - name: create-datavolume-from-manifest
      taskRef:
        kind: ClusterTask
        name: create-datavolume-from-manifest
      params:
        - name: waitForSuccess
          value: 'true'
        - name: manifest
          value: |
            apiVersion: cdi.kubevirt.io/v1beta1
            kind: DataVolume
            metadata:
              generateName: fedora-35-
            spec:
              pvc:
                accessModes:
                  - ReadWriteOnce
                resources:
                  requests:
                    storage: 10Gi
                volumeMode: Filesystem
              source:
                http:
                  url: https://download.fedoraproject.org/pub/fedora/linux/releases/35/Cloud/x86_64/images/Fedora-Cloud-Base-35-1.2.x86_64.qcow2

    - name: disk-virt-sysprep
      params:
        - name: pvc
          value: "$(tasks.create-datavolume-from-manifest.results.name)"
        - name: sysprepCommands
          value: |
            run-command dnf -y --best upgrade --exclude=kernel*
            edit /etc/selinux/config:s/^SELINUX=enforcing/SELINUX=permissive/
            install vim,tmux
            run-command dnf clean all
            delete /var/cache/dnf
        - name: additionalOptions
          value: "--network"
      taskRef:
        kind: ClusterTask
        name: disk-virt-sysprep
      runAfter:
        - create-datavolume-from-manifest
---
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  generateName: kmi-pipelinerun-
spec:
  pipelineRef:
    name: kmi-pipeline
  serviceAccountNames:
    - taskName: create-datavolume-from-manifest
      serviceAccountName: create-datavolume-from-manifest-task

...
[disk-virt-sysprep : run-virt-sysprep] [   5.2] Performing "utmp" ...
[disk-virt-sysprep : run-virt-sysprep] [   5.2] Performing "yum-uuid" ...
[disk-virt-sysprep : run-virt-sysprep] [   5.2] Performing "customize" ...
[disk-virt-sysprep : run-virt-sysprep] [   5.2] Setting a random seed
[disk-virt-sysprep : run-virt-sysprep] [   5.2] Setting the machine ID in /etc/machine-id
[disk-virt-sysprep : run-virt-sysprep] [   5.2] Running: dnf -y --best upgrade --exclude=kernel*
[disk-virt-sysprep : run-virt-sysprep] [  50.0] Editing: /etc/selinux/config
[disk-virt-sysprep : run-virt-sysprep] sh: perl: command not found
[disk-virt-sysprep : run-virt-sysprep] virt-sysprep: error: failure: rm: /var/run/utmp: No such file or directory
[disk-virt-sysprep : run-virt-sysprep]
[disk-virt-sysprep : run-virt-sysprep] If reporting bugs, run virt-sysprep with debugging enabled and include the
[disk-virt-sysprep : run-virt-sysprep] complete output:
[disk-virt-sysprep : run-virt-sysprep]
[disk-virt-sysprep : run-virt-sysprep]   virt-sysprep -v -x [...]

failed to get logs for task disk-virt-sysprep : container step-run-virt-sysprep has failed  : [{"key":"StartedAt","value":"2022-02-18T20:54:20.324Z","type":3}]

Anything else we need to know?:

Environment:

• KubeVirt version (use virtctl version):

Client Version: version.Info{GitVersion:"v0.49.0", GitCommit:"f8160a0b5eac2acafab74fd7916bfcaf0c39a6a3", GitTreeState:"clean", BuildDate:"2022-01-11T17:37:26Z", GoVersion:"go1.16.6", Compiler:"gc", Platfo
rm:"linux/amd64"}
Server Version: version.Info{GitVersion:"v0.46.0-dirty", GitCommit:"3ebb0a03fde639ea9afb5ee83ac7ac72dbeb4a9d", GitTreeState:"dirty", BuildDate:"2021-10-08T21:39:28Z", GoVersion:"go1.16.6", Compiler:"gc",
Platform:"linux/amd64"}

• Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"archive", BuildDate:"2022-01-27T18:26:18Z", GoVersion:"go1.17.
6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.6", GitCommit:"d921bc6d1810da51177fbd0ed61dc811c5228097", GitTreeState:"clean", BuildDate:"2021-10-27T17:44:26Z", GoVersion:"go1.16.9"
, Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.23) and server (1.21) exceeds the supported minor version skew of +/-1

• tekton-pipelines version:

Client version: 0.21.0
Pipeline version: v0.33.0

• kubevirt-tekton-tasks version: v0.4.0
• CDI version if applicable: v1.42.1

execute-in-vm fails when private key is missing a newline at the end

caused by improper secret creation

We should add it if we detect it is missing

error:

Warning: Permanently added '10.116.1.229' (ECDSA) to the list of known hosts.
Load key "/tekton/home/.ssh/id_rsa": invalid format
Permission denied, please try again.
Permission denied, please try again.
[email protected]: Permission denied (publickey,gssapi-keyex,gssapi-with-mic,password).

windows-efi-installer pipelinerun fails with permission denied on step "modify-windows-iso-file"

What happened:
I want to install and use the tekton tasks to run the example pipeline,
Windows EFI Installer Pipeline
When instantiating the pipelinerun as part of,
https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/release/pipelines/windows-efi-installer/pipelineruns/pipelineruns.yaml

The task "modify-windows-iso-file" fails.
Log output states permission denied

What you expected to happen:
I expect the pipeline to complete and having a working Windows Template.

How to reproduce it (as minimally and precisely as possible):
Follow the install section on the main Readme.
Create the pipeline,
kubevirt-tekton-tasks/release/pipelines/windows-efi-installer
and instanciate a pipelinerun

Additional context:
I believe the problem is because the pipelinerun defines some values to the podtemplate,
securityContext:
runAsUser: 1001
runAsGroup: 1001
fsGroup: 1001
See,
https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/release/pipelines/windows-efi-installer/pipelineruns/pipelineruns.yaml

Changing this to
taskRunSpecs:
- pipelineTaskName: "modify-windows-iso-file"
podTemplate:
securityContext:
runAsUser: 107
runAsGroup: 1001
fsGroup: 107

Makes the pipeline work.
Environment:

• KubeVirt version (use virtctl version): N/A
  Client Version: version.Info{GitVersion:"v1.1.1-110-g359e3f5ed", GitCommit:"359e3f5eda4ad2c77958b98924ed9a1e53c91d06", GitTreeState:"clean", BuildDate:"2024-05-29T01:45:44Z", GoVersion:"go1.20.12 X:strictfipsruntime", Compiler:"gc", Platform:"linux/amd64"}
  Server Version: version.Info{GitVersion:"v1.1.1-110-g359e3f5ed", GitCommit:"359e3f5eda4ad2c77958b98924ed9a1e53c91d06", GitTreeState:"clean", BuildDate:"2024-06-07T04:25:34Z", GoVersion:"go1.20.12 X:strictfipsruntime", Compiler:"gc", Platform:"linux/amd64"}

• Kubernetes version (use kubectl version): N/A
  Client Version: 4.15.2
  Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
  Kubernetes Version: v1.28.6+6216ea1

• VM or VMI specifications: N/A

• Cloud provider or hardware configuration: N/A

• OS (e.g. from /etc/os-release): N/A

• Kernel (e.g. uname -a): N/A

• Install tools: N/A

• Others: N/A

Make KubeVirt tasks available on Tekton Hub

Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement

What happened:
It would be easier to discover these tasks if they were available on the Tekton Hub (hub.tekton.dev) and may even drive the creation of additional tasks

What you expected to happen:
Search for KubeVirt tekton tasks on the tekton hub and see that they exist.

How to reproduce it (as minimally and precisely as possible):
N/A

Anything else we need to know?:
N/A

Create a plain Kubernetes testing lane

/kind enhancement

What happened:
Currently, the kubevirt-tekton-tasks are only tested in OpenShift. The project would benefit from also having a testing line in plain Kubernetes, increasing the amount of corner cases tested.

What you expected to happen:
To test kubevirt-tekton-taks in a plain kubernetes scenarios.