kucherenkoihor/android-architecture-components

The template project that uses Android Architecture Components with Repository pattern. The simple app that uses awesome Fuel library instead of Retrofit for perfoming HTTP request. The app also persists data using the Room library and display data in RecyclerView.

android-architecture-components's Issues

Purpose of Suppress("LeakingThis")

Hello,
in your BaseLifecycleActivity, you have an annotation:
@Suppress("LeakingThis")

Can you briefly explain the purpose of this annotation? It doesn't have effect on Lint, since nothing similar causes a warning.

Thank you for the sample,
Igor

Question about using MediatorLiveData

Hi,
This is not an issue but a question. There is no other way to ask a question.

Why you did not use an MediatorLiveData instead of observing 3 differents LiveData like you do:
viewModel.isLoadingLiveData.observe(this, Observer<Boolean> { it?.let { vRefresh.isRefreshing = it } })
viewModel.reposLiveData.observe(this, Observer<List<Repo>> { it?.let { adapter.dataSource = it } })
viewModel.throwableLiveData.observe(this, Observer<Throwable> { it?.let { Snackbar.make(rv, it.localizedMessage, Snackbar.LENGTH_LONG).show() } }).

You could add those 3 different source inside the mediatorLiveData and thus observing one livedata in the your activity/fragment.

IoException: Stream closed

There was a toast error message. Sorry, I didn't see anything in logs. Had no time to look into it in details.

Kotlin-android vs findViewById

Hi,
I'm getting up to speed in Kotlin. I know there is https://kotlinlang.org/docs/tutorials/android-plugin.html - which let you avoid writing findViewById calls. I'd like to know - is there a reason you are using findViewById in this code? I see you are declaring them as lazy, but cannot see the advantage to them...

Thank you,
Igor