The sipcore from kurotych

Adjust HeaderValue vstr field

vstr field - This is header value from start until parameters or end of value ( not includes parameters )
Spaces at the end of value should be trimmed

Add support header comma-separated values

https://tools.ietf.org/html/rfc3261#section-7.3.1

The following groups of header field rows are valid and equivalent:

      Route: <sip:[email protected]>
      Subject: Lunch
      Route: <sip:[email protected]>
      Route: <sip:[email protected]>

      Route: <sip:[email protected]>, <sip:[email protected]>
      Route: <sip:[email protected]>
      Subject: Lunch

      Subject: Lunch
      Route: <sip:[email protected]>, <sip:[email protected]>,
             <sip:[email protected]>

Add codecov report

Implement SipUri

Implement sipuri.rs module
https://tools.ietf.org/html/rfc3261#section-19.1
https://tools.ietf.org/html/rfc3261#section-25

Example SIP and SIPS URIs ( Unit test stuff )

sip:[email protected]
sip:alice:[email protected];transport=tcp
sips:[email protected]?subject=project%20x&priority=urgent
sip:+1-212-555-1212:[email protected];user=phone
sips:[email protected]
sip:[email protected]
sip:atlanta.com;method=REGISTER?to=alice%40atlanta.com
sip:alice;day=[email protected]

Implement unicase library

For headers comparing, at least.

When comparing header fields, field names are always case-
insensitive.  Unless otherwise stated in the definition of a
particular header field, field values, parameter names, and parameter
values are case-insensitive.  Tokens are always case-insensitive.
Unless specified otherwise, values expressed as quoted strings are
case-sensitive.  For example,

      Contact: <sip:[email protected]>;expires=3600

   is equivalent to

      CONTACT: <sip:[email protected]>;ExPiReS=3600

   and

      Content-Disposition: session;handling=optional

   is equivalent to

      content-disposition: Session;HANDLING=OPTIONAL

   The following two header fields are not equivalent:

      Warning: 370 devnull "Choose a bigger pipe"
      Warning: 370 devnull "CHOOSE A BIGGER PIPE"

Refs:
https://github.com/seanmonstar/unicase/
https://docs.rs/unicase/2.6.0/unicase/
https://tools.ietf.org/html/rfc3261#section-7.3.1

Remove IRI dependency

Any way to use it on stable rust?

Hi

I'd like to use it on stable. Is it something that can be done?

Implement absoluteURI

absoluteURI = scheme ":" ( hier-part / opaque-part )

Also, replace URI in RequestLine according to RFC3261:

pub uri: SipUri<'a>,

to

pub uri: RequestURI <'a>,

Request-URI = SIP-URI / SIPS-URI / absoluteURI

Remove is_digit() from bnfcore

Replace is_digit() functions from bnfcore.rs to nom::character::is_digit;

Improve parsing of sip message headers

Make parsing headers according to each definition from https://tools.ietf.org/html/rfc3261#section-25

message-header  =  (Accept
                /  Accept-Encoding
                /  Accept-Language
                /  Alert-Info
                /  Allow
                /  Authentication-Info
                /  Authorization
                /  Call-ID
                /  Call-Info
                /  Contact
                /  Content-Disposition
                /  Content-Encoding
                /  Content-Language
                /  Content-Length
                /  Content-Type
                /  CSeq
                /  Date
                /  Error-Info
                /  Expires
                /  From
                /  In-Reply-To
                /  Max-Forwards
                /  MIME-Version
                /  Min-Expires
                /  Organization
                /  Priority
                /  Proxy-Authenticate
                /  Proxy-Authorization
                /  Proxy-Require
                /  Record-Route
                /  Reply-To
                /  Require
                /  Retry-After
                /  Route
                /  Server
                /  Subject
                /  Supported
                /  Timestamp
                /  To
                /  Unsupported
                /  User-Agent
                /  Via
                /  Warning
                /  WWW-Authenticate
                /  extension-header) CRLF

Implement trait Iterator for headers

https://doc.rust-lang.org/1.29.1/core/iter/index.html

Start iteration should from top of sip message. The RFC headers first, extensions after

Implement support long header fields

https://tools.ietf.org/html/rfc2822#section-2.2.3

GenericParam panicked

sipcore/crates/sipmsg/src/headers/generic_params.rs

Line 38 in e018d34

let (input, (_, param_val, _)) = take_quoted_string(input).unwrap();

in some possible invalid input this causes panic

thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Error(SipParseError { code: 1, message: Some("take_until_nonescaped_quote error!") })'

better propagate like the rest of code in GenericParam

Implement GenericParam struct ( parser )

generic-param = token [ EQUAL gen-value ]

User Agent parser missing quot cases

sipcore/crates/sipmsg/src/headers/parsers/user_agent.rs

Line 22 in 0ca37a4

    
           fn take_value(source_input: &[u8]) -> nom::IResult<&[u8], HeaderValue, SipParseError> {

In some SIP samples from Wireshark project contained the following UA :

User-Agent: <Motorola VT1000 mac: 000CE5C74EF8 sw:VT20_02.03.00_A ln:0 cfg:1253778536520/1002173358>

This fails because quot cases not handled, maybe :

            if tmp_input[0] == b'<' {
                let (input, _) = take_sws_token::laquot(tmp_input)?;
                let (input, _) = take_until(">")(input)?;
                let (input, _) = take_sws_token::raquot(input)?;
                tmp_input = input;
                continue;
            }

Create documentation for HeaderValue struct

Create a markdown table for vtype => vtags (one to many) and post to documentation

sipmsg: Parameters

Create parameters.rs file for parsing header parameters fields into a container.

Add support empty sip header values

Add support sip headers short names

For example Via == v

Via =  ( "Via" / "v" ) HCOLON via-parm *(COMMA via-parm)

Implement logic for COMMA separated value

Move SipUri to common folder

Adjust parsers to HeaderValue struct

Fill vtype and vtags value during parsing raw data.

Check IPv6 support

Add test cases from https://tools.ietf.org/html/rfc5118
Fix bugs if it'll happen.
See example: https://github.com/armatusmiles/sipcore/blob/master/crates/sipmsg/tests/rfc4475.rs

Think about remove NomParser

It seems useless. I don't remember why i did it

use crate::common::errorparse::SipParseError;

pub trait NomParser<'a> {
    type ParseResult;
    fn parse(input: &'a [u8]) -> nom::IResult<&[u8], Self::ParseResult, SipParseError>;
}