kuzzmi/ember-cli-webfontloader

WebFontLoader wrapped in Ember CLI addon

ember-cli-webfontloader's Issues

Fix breaking changes in FastBoot 1.0

The current ember-cli-fastboot releases (1.0.0-rc.1 and above) introduce breaking changes. These will most likely break your current FastBoot implementation.

See ember-fastboot/ember-cli-fastboot#387 for more information and a guide on how to fix your addon. Also you may want to visit the -fastboot Slack channel to get help from other users.

Note: this issue has been created automatically, by searching for certain patterns in your code. If you think this has been falsely created, feel free to close!

Missing `index.js` file

Hi,

not sure if I broke something with FastBoot compatibility, but installing v0.3.0 results in missing index.js in root directory.

Thanks!

ES6 syntax breaks build on CI server

After having installed ember-cli-webfontloader in our app, the CI build breaks on the following line in the addon:

Unexpected token (
.../node_modules/ember-cli-webfontloader/index.js:7
included(app) {
^

I checked that ember-cli-webfontloader has ember-cli-babel as a dependency so I'm not sure if this is a problem in ember-cli-webfontloader itself but after a 5-min research I haven't seen another Ember addon that uses the ES6 syntax in its index.js so I'm not sure. FWIW, the tests pass locally.

Fix broken tests

Currently one of the tests is failing:

not ok 8 PhantomJS 2.1 - TestLoader Failures: dummy/tests/unit/initializers/ember-cli-webfontloader-test: could not be loaded
    ---
        actual: >
            null
        message: >
            Died on test #1 moduleLoadFailure@http://localhost:7357/assets/test-support.js:6250:15
            require@http://localhost:7357/assets/test-loader.js:31:31
            loadModules@http://localhost:7357/assets/test-loader.js:21:25
            load@http://localhost:7357/assets/test-loader.js:40:35
            http://localhost:7357/assets/test-support.js:6259:20: Could not find module `dummy/initializers/ember-cli-webfontloader` imported from `dummy/tests/unit/initializers/ember-cli-webfontloader-test`

Update dependencies and increase supported version of Node

Dependencies must be up-to-date and package.json reflect supported versions of node.

Support for Fastboot 1.0.0rc6+

Currently this addon doesn't work with new Fastboot as it changed the way the loading/detection is working:

https://github.com/ember-fastboot/ember-cli-fastboot/#build-hooks-for-fastboot
https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c

Update webfontloader script to 1.6.26

Original webfontloader library is 1.6.26 now and must be updated here.

Loading Roboto Mono should not be the default

Roboto Mono is currently loaded by default because ember-cli merges config/environment.js.

It can only be overwritten if the user is using a Google font.

Fonts.com version is hanging with the class wf-loading, no events called

Hi Kuzzmi,

I tried using your addon today. But I couldn't get events to fire. Eventually I figured out it had to do with a Fonts.com specific issue which has to do with the Web Font Loader version. (typekit/webfontloader#331)

Could you update your Web Font Loader version to v1.6.27?

Best,
Harm