kylefarris/ampersand-multiselect-view

A view module for intelligently rendering and validating multiple select box input. Works well with ampersand-form-view. Based off of ampersand-select-view.

ampersand-multiselect-view's Issues

Model property lookup returning undefined

On line 225:
https://github.com/kylefarris/ampersand-multiselect-view/blob/master/ampersand-multiselect-view.js#L225

lookupValues should be v

Bad variable reference in the reset method

On line 261:
https://github.com/kylefarris/ampersand-multiselect-view/blob/master/ampersand-multiselect-view.js#L261

startingValuea should be startingValues

Unable to enumerate the options of a multiselect in Microsoft Edge

This isn't an ampersand bug, it's an Edge bug. And I think it was reported here: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/9628212/

That glitch indicates that the state of options elements in a select object aren't updated immediately in Microsoft Edge. This behaviour is confirmed by Microsoft Edge team and, until they fix it, produces an error here:

206 this.getAllOptions().forEach(function(v,i) {
207 this.select.options[i].selected = false;
208 }.bind(this));

Line 207 appears to fail in Microsoft Edge. this.select.childNodes.length and this.select.options.length will be temporarily different while the options are enumerated and deselected by the loop above. Then subsequent code will proceed (and fail).

Loading a form with a model object with valid multi-select data does not cause the multi-select view to display correct items as selected.

(Hopefully that's self-explanatory.)

Probably this has to do with the template html needing more data-hook work of some sort, but I'm not good enough to figure out how to do it.

yieldModel vs. yieldModels

Please clarify in the documentation and in the code which option to use. Currently the code seems to be favouring yieldModels (lines 64, 154, 221), but there is an instance in the code which is using yieldModel (line 334).