l-bydo/onedayonealgo

Learn one algorithm each day, code it, and upload

𝗔𝗯𝗼𝘂𝘁 𝗟-𝗕𝘆𝗗𝗼 C𝗼𝗺𝗺𝘂𝗻𝗶𝘁𝘆

We have developed a community to promote Learning By Doing, no matter, what your branch is or from which college you belong.What you need here is a passion for your interests in learning and implementing technology related stuffs. We will act as facilitators while anyone joining this community acts as a volunteer.✅ The soul aim of this initiative is to bring together all the tech heads, who are committed to enhance their knowledge,so as to promote collaborative learning and problem solving. We will be having virtual discussions on different topics of concern.Alongwith it ,we will be constantly sharing important information from various resources.📚

This 𝑶𝒏𝒆𝑫𝒂𝒚𝑶𝒏𝒆𝑨𝒍𝒈𝒐 is a series that we are conducting here on GitHub as a part of L-ByDo Community. You will have algorithms to solve each day, code it in whatever language you are comfortable with and upload your file here.

𝗖𝗼𝗻𝘁𝗿𝗶𝗯𝘂𝘁𝗶𝗼𝗻 𝗴𝘂𝗶𝗱𝗲𝗹𝗶𝗻𝗲𝘀

1.𝘾𝙤𝙢𝙢𝙪𝙣𝙞𝙘𝙖𝙩𝙞𝙣𝙜 𝙚𝙛𝙛𝙚𝙘𝙩𝙞𝙫𝙚𝙡𝙮:

Whether you’re a one-time contributor or trying to join a community, working with others is one of the most important skills you’ll develop in open source. Before you open an issue or pull request, or ask a question in chat, keep these points in mind to help your ideas come across effectively.

• 𝑮𝒊𝒗𝒆 𝑪𝒐𝒏𝒕𝒆𝒙𝒕 : Help others get quickly up to speed. If you’re running into an error, explain what you’re trying to do and how to reproduce it. If you’re suggesting a new idea, explain why you think it’d be useful to the project (not just to you!).

• 𝑫𝒐 𝒚𝒐𝒖𝒓 𝒉𝒐𝒎𝒆𝒘𝒐𝒓𝒌 𝒃𝒆𝒇𝒐𝒓𝒆𝒉𝒂𝒏𝒅: It’s OK not to know things, but show that you tried. Before asking for help, be sure to check a project’s README, documentation, issues (open or closed), mailing list, and search the internet for an answer. People will appreciate when you demonstrate that you’re trying to learn.

• 𝑲𝒆𝒆𝒑 𝒓𝒆𝒒𝒖𝒆𝒔𝒕𝒔 𝒔𝒉𝒐𝒓𝒕 𝒂𝒏𝒅 𝒅𝒊𝒓𝒆𝒄𝒕: Much like sending an email, every contribution, no matter how simple or helpful, requires someone else’s review. Many projects have more incoming requests than people available to help. Be concise. You will increase the chance that someone will be able to help you.

• 𝑲𝒆𝒆𝒑 𝒂𝒍𝒍 𝒄𝒐𝒎𝒎𝒖𝒏𝒊𝒄𝒂𝒕𝒊𝒐𝒏 𝒑𝒖𝒃𝒍𝒊𝒄: Although it’s tempting, don’t reach out to maintainers privately unless you need to share sensitive information (such as a security issue or serious conduct violation). When you keep the conversation public, more people can learn and benefit from your exchange. Discussions can be, in themselves, contributions.

• 𝑰𝒕’𝒔 𝒐𝒌𝒂𝒚 𝒕𝒐 𝒂𝒔𝒌 𝒒𝒖𝒆𝒔𝒕𝒊𝒐𝒏𝒔 (𝒃𝒖𝒕 𝒃𝒆 𝒑𝒂𝒕𝒊𝒆𝒏𝒕!): Everybody was new to the project at some point, and even experienced contributors need to get up to speed when they look at a new project. By the same token, even longtime maintainers are not always familiar with every part of the project. Show them the same patience that you’d want them to show to you.

• 𝑹𝒆𝒔𝒑𝒆𝒄𝒕 𝒄𝒐𝒎𝒎𝒖𝒏𝒊𝒕𝒚 𝒅𝒆𝒄𝒊𝒔𝒊𝒐𝒏𝒔: Your ideas may differ from the community’s priorities or vision. They may offer feedback or decide not to pursue your idea. While you should discuss and look for compromise, maintainers have to live with your decision longer than you will. If you disagree with their direction, you can always work on your own fork or start your own project.

• 𝑨𝒃𝒐𝒗𝒆 𝒂𝒍𝒍, 𝒌𝒆𝒆𝒑 𝒊𝒕 𝒄𝒍𝒂𝒔𝒔𝒚: Open source is made up of collaborators from all over the world. Context gets lost across languages, cultures, geographies, and time zones. In addition, written communication makes it harder to convey a tone or mood. Assume good intentions in these conversations. It’s fine to politely push back on an idea, ask for more context, or further clarify your position. Just try to leave the internet a better place than when you found it.

2.𝙂𝙖𝙩𝙝𝙚𝙧𝙞𝙣𝙜 𝙘𝙤𝙣𝙩𝙚𝙭𝙩:

Before doing anything, do a quick check to make sure your idea hasn’t been discussed elsewhere. Skim the project’s README, issues (open and closed), mailing list, and Stack Overflow. You don’t have to spend hours going through everything, but a quick search for a few key terms goes a long way. If you can’t find your idea elsewhere, you’re ready to make a move. If the project is on GitHub, you’ll likely communicate by opening an issue or pull request:

• Issues are like starting a conversation or discussion
• Pull requests are for starting work on a solution

For lightweight communication, such as a clarifying or how-to question, try asking on Stack Overflow, IRC, Slack, or other chat channels, if the project has one Before you open an issue or pull request, check the project’s contributing docs (usually a file called CONTRIBUTING, or in the README), to see whether you need to include anything specific. For example, they may ask that you follow a template, or require that you use tests. If you want to make a substantial contribution, open an issue to ask before working on it. It’s helpful to watch the project for a while (on GitHub, you can click “Watch” to be notified of all conversations), and get to know community members, before doing work that might not get accepted.

3.𝙊𝙥𝙚𝙣𝙞𝙣𝙜 𝙖𝙣 𝙞𝙨𝙨𝙪𝙚:

You should usually open an issue in the following situations:

• Report an error you can’t solve yourself
• Discuss a high-level topic or idea (for example, community, vision or policies)
• Propose a new feature or other project idea

Tips for communicating on issues:

1. If you see an open issue that you want to tackle, comment on the issue to let people know you’re on it. That way, people are less likely to duplicate your work.
   
2. If an issue was opened a while ago, it’s possible that it’s being addressed somewhere else, or has already been resolved, so comment to ask for confirmation before starting work.
   
3. If you opened an issue, but figured out the answer later on your own, comment on the issue to let people know, then close the issue. Even documenting that outcome is a contribution to the project.

4.𝙊𝙥𝙚𝙣𝙞𝙣𝙜 𝙖 𝙥𝙪𝙡𝙡 𝙧𝙚𝙦𝙪𝙚𝙨𝙩:

You should usually open a pull request in the following situations:

• Submit trivial fixes (for example, a typo, a broken link or an obvious error)
• Start work on a contribution that was already asked for, or that you’ve already discussed, in an issue
• A pull request doesn’t have to represent finished work. It’s usually better to open a pull request early on, so others can watch or give feedback on your progress. Just mark it as a “WIP” (Work in Progress) in the subject line. You can always add more commits later.

If the project is on GitHub, here’s how to submit a pull request:

1. Fork the repository and clone it locally. Connect your local to the original “upstream” repository by adding it as a remote. Pull in changes from “upstream” often so that you stay up to date so that when you submit your pull request, merge conflicts will be less likely. (See more detailed instructions here.)
2. Create a branch for your edits.
3. Reference any relevant issues or supporting documentation in your PR (for example, “Closes #37.”)
4. Include screenshots of the before and after if your changes include differences in HTML/CSS. Drag and drop the images into the body of your pull request.
5. Test your changes! Run your changes against any existing tests if they exist and create new ones when needed. Whether tests exist or not, make sure your changes don’t break the existing project.
6. Contribute in the style of the project to the best of your abilities. This may mean using indents, semi-colons or comments differently than you would in your own repository, but makes it easier for the maintainer to merge, others to understand and maintain in the future.

You did it 🏆

Whether you just made your first open source contribution, or you’re looking for new ways to contribute, we hope you’re inspired to take action.

onedayonealgo's Issues

Test Issue

This issue tests Github Actions Labeler workflow.

NO python code here! Ouch :(

Restructure Directories

Directories need to be restructured using the Best Practices

• Folders to be renamed according to the naming convention wherever necessary.
• Files to be renamed according to naming convention wherever necessary.
• Folders for Languages to be created accordingly, and files to be passed in it. Eg. Cycle_Sort/Python/ should have codes for Cycle Sort using Python only.

NOTE: Check Sorting_Algorithms/Counting_Sort to see the naming convention and directory structure.

Merge Sort in Python

I want to work on a Merge sort implementation in python

Update readme

Mention all ongoing projects, specify contributing guidelines

Enhance README.md

Readme needs to be reconstructed for Hacktoberfest 2020.

redundant code

OneDayOneAlgo/SieveOfEratosthenes/DamianArado/DamianArado.c

Line 22 in 3d25e1c

array[1]==1;

OneDayOneAlgo/SieveOfEratosthenes/DamianArado/DamianArado.c

Line 23 in 3d25e1c

array[2]==0;

i think using equality operator does not makes any sense in this situation

[ADD] Solutions of famous questions from CSES

Add solution to questions from https://cses.fi/problemset/

• Make the directory in the given format
• CSES_solution / [NAME OF PROBLEM] / [SOLUTION FILE]
• CSES_solution / [NAME OF PROBLEM] / [README]

Note: README for every problem involves the link to problem and short description of approach.

Auto Issue Labeler

I can create an Auto issue labeler that labels every issue opened as Hacktoberfest and add relevant language based on the topic and description.

Merge sort algorithm in C using dynamic memory allocation

Hey, I intend to make changes in your Merge sort code written in C ( it being written using static memory allocation techniques)

Reduce the auxiliary space in recursion.

#this is variation of quick sort algorithm implemented recursively
def quicksort(seq):
    length=len(seq)
    if length<=1: #if only one element or 0, return itself
        return seq
    else:
        pivot=seq.pop()
    great=[]
    low=[]
    def fun(seq,low,great):  #recursion through list
        if len(seq)==0:
            return
        elif seq[0]>pivot:
            great.append(seq[0])  #take larger elements in this array
        else:
            low.append(seq[0])  #take shorter elements in this array
        return fun(seq[1:],low,great)
    fun(seq,low,great)
    return quicksort(low)+[pivot]+quicksort(great)  #add smaller+pivot +larger recursively
print(quicksort([4,3,78,78,43,3,8,79,1000,4,5666]))

using varibale size array

OneDayOneAlgo/SieveOfEratosthenes/DamianArado/DamianArado.c

Line 12 in 3d25e1c

int array[limit]={0};

some compilers like clang would not permite to compile the program and will through an error

error: variable-sized object may not be initialized
        int array[limit]={0};
                  ^~~~~
1 error generated.

it is better to use the constant size with C-Style arrays or the another possible solution is to dynamically allocate the array

Test Python Issue

This is to test my Labeler bot . Its not written in python

Add TripletSum Algorithm

Add TripletSum Algorith, under Algorithm/General_Algorithm.

[FIX] Pull Request- Github Actions workflow

Github Actions Workflow, set up for Greeting the first-time PR makers, is not working right, therefore, need FIXES.

Permission to work on Project Euler files.

I would like to contribute by adding quality solutions to more problems in Project Euler.