HRTF loader doesn't return boolean false if .wav not found

[dug9]

HRTF loader doesn't return boolean false if .wav not found

[dug9]

Q. do you prefer Pull Requests or code snippets?
Snippets:

1. HRTFDatabas.h > struct HRTFDatabaseInfo- add
   bool files_found_and_loaded = false;

2. HRTFDatabas.h > HRTFDatabase add
   public: bool files_found_and_loaded() { return info->files_found_and_loaded; }

3. AudioContext.cpp ::loadHrtfDatabase() change:
   bool loaded = db->database()->files_found_and_loaded();
   loaded = loaded && db->database()->numberOfElevations() > 0 && db->database()->numberOfAzimuths() > 0;
   return loaded;

4. HRTFPanner.cpp in bool HRTFElevation::calculateKernelsForAzimuthElevation()
   change:
   if (!impulseResponse)
   {
   LOG_ERROR("impulse not found %s (bad path?)", resourceName.c_str());
   info->files_found_and_loaded = false;
   return false;
   }
   ...
   if (!isBusGood)
   {
   info->files_found_and_loaded = false;
   return false;
   }
   ...
   info->files_found_and_loaded = true;

   return true;
   }

5. HRTFPanner.cpp > HRTFDatabaseLoader::~HRTFDatabaseLoader() comment out:
   //s_loader = nullptr; //.reset(db) does a pointer swap and the destructor called after new constructor

[meshula]

If you can PR, I can merge things after a review, that's my preference. Otherwise, you'll need to wait until I have time to try integrating the change.

[dug9]

May I have Labsound/github write access to push a PR branch? Or should I be cloning Labsound on github to put my PRs?

[meshula]

The workflow we prefer is that you make a fork, and make the PR from there.

[dug9]

Fixed with pull request