labster/p6-file-directory-tree

Port of File::Path::Tiny to Perl 6 - create and delete directories

p6-file-directory-tree's Issues

mktree is far from optimal

https://irclogs.raku.org/raku/2023-10-16.html#22:05

WARNING: Version mismatch for File-Directory-Tree ("https://github.com/labster/p6-file-directory-tree.git") found. META6.json has "*" but latest 'git tag' is "master"

Can you please start using versions instead of '*' in META6.json? Maybe something like v0.0.1.
And then please also add the same version as git tag so it's consistent...

rmdir recursively while empty?

This is a suggestion for a possible feature (I found myself having to hand-roll the following recently, and figured it'd make for a good enhancement for File::Directory::Tree).

Suppose you want to remove an empty directory (like rmdir does), and then have that removal bubble up until you encounter a non-empty directory. So:

• for the path /a/b/c/d, if none of those directories have anything else inside, then running this command would remove all of them;
• for the same path, if a/b also contains something else apart from c, then running this command on /a/b/c/d would remove c but stop there (because afterwards /a/b wouldn't be empty).
  In short, something like rmtree but only calling rmdir and not empty-directory.

Perhaps whether rmtree calls empty-directory or not can be passed as a named parameter, defaulting to the current version.

Test fails thus no installation

Hi, first of all, thanks for the module.

Unfortunately, I cannot install it, because a test fails:
% zef install File::Directory::Tree
===> Searching for: File::Directory::Tree
===> Testing: File::Directory::Tree:auth('labster')
No such method 'child' for invocant of type 'Bool'
in block at t/basic.t line 32
in block at t/basic.t line 30

Looks like you planned 9 tests, but ran 7

===> Testing [FAIL]: File::Directory::Tree:auth('labster')

install failing on windows

I was able to install this module from a git clone on windows in git bash, but if I tried to install with

zef install File::Directory::Tree

I get the following error:

$ zef install --force-install File::Directory::Tree
===> Searching for: File::Directory::Tree
Aborting due to test failure: File::Directory::Tree (use --force-test to override)
===> Testing: File::Directory::Tree
[File::Directory::Tree] ===SORRY!=== Error while compiling C:\Users\coke\.zef\tmp\File%3A%3ADirectory%3A%3ATree%3Aver%3C%2A%3E%3Aauth%3Cgithub%3Alabster%3E.tar.gz\p6-file-directory-tree-master/t\basic.t
[File::Directory::Tree] Failed to open file C:\Users\coke\.zef\tmp\File%3A%3ADirectory%3A%3ATree%3Aver%3C%2A%3E%3Aauth%3Cgithub%3Alabster%3E.tar.gz\p6-file-directory-tree-master\.precomp\D9FCEA76B4CE7E9B96269DCF9BA0D77F691994B0\95\952279BFDDC9EF8BA07A41980D0268FA20AB126F.repo-id.1BKAD88ZKTH9VQBFCLIUSVDX8.tmp: No such file or directory
[File::Directory::Tree] at C:\Users\coke\.zef\tmp\File%3A%3ADirectory%3A%3ATree%3Aver%3C%2A%3E%3Aauth%3Cgithub%3Alabster%3E.tar.gz\p6-file-directory-tree-master/t\basic.t:2
[File::Directory::Tree] Actually thrown at:
[File::Directory::Tree]   in any statement_control at C:\raku\share\perl6\lib/Perl6/Grammar.moarvm line 1
===> Testing [FAIL]: File::Directory::Tree

build fails on appveyor

===> Testing: File::Directory::Tree:auth('labster')
t/basic.t .. 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/9 subtests 
Test Summary Report
-------------------
t/basic.t (Wstat: 65280 Tests: 7 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 9 tests but ran 7.
Files=1, Tests=7,  1 wallclock secs ( 0.06 usr +  0.00 sys =  0.06 CPU)
Result: FAIL
Failed to create directory 'C:\Users\appveyor\AppData\Local\Temp\1\file-directory-tree-module-tests\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a\a' with mode '0o777': Failed to mkdir: 206
  in block  at t/basic.t line 28
  in block <unit> at t/basic.t line 26
# Looks like you planned 9 tests, but ran 7
===> Testing [FAIL]: File::Directory::Tree:auth('labster')
Aborting due to test failure: File::Directory::Tree:auth('labster') (use --force-test to override)
  in code  at C:\Users\appveyor\rakudobrew\moar-2017.06\install\share\perl6\site\sources\58A2CF7B6756361E028457049819328DE7AF8AD8 (Zef::Client) line 373
  in method test at C:\Users\appveyor\rakudobrew\moar-2017.06\install\share\perl6\site\sources\58A2CF7B6756361E028457049819328DE7AF8AD8 (Zef::Client) line 351
  in code  at C:\Users\appveyor\rakudobrew\moar-2017.06\install\share\perl6\site\sources\58A2CF7B6756361E028457049819328DE7AF8AD8 (Zef::Client) line 528
  in sub  at C:\Users\appveyor\rakudobrew\moar-2017.06\install\share\perl6\site\sources\58A2CF7B6756361E028457049819328DE7AF8AD8 (Zef::Client) line 525
  in method install at C:\Users\appveyor\rakudobrew\moar-2017.06\install\share\perl6\site\sources\58A2CF7B6756361E028457049819328DE7AF8AD8 (Zef::Client) line 631
  in sub MAIN at C:\Users\appveyor\rakudobrew\moar-2017.06\install\share\perl6\site\sources\B9B6B5F22DE3727E789C70B98CFB4A5030EE58D8 (Zef::CLI) line 152
  in block <unit> at C:\Users\appveyor\rakudobrew\moar-2017.06\install\share\perl6\site\resources\781A78D3FE358EE90D60E4633882482D3AE9D3A5 line 1

Tests are failing now

Travis tests are failing.

Please "git tag" your RAKU modules with it's versions

Can you please set a specific "version" for your RAKU module in your META6.json file?
You have a '*" now, which is known to make trouble and may not be supported within the RAKU tool chain (soon), say ZEF, FEZ, MI6...

Can you please "GIT TAG" your RAKU modules with it's version, similar and at the same time you maintain it's "version": "x.y.z" in your META6.json file?
I was told, this will happen "for free" going forward with mi6 anyhow, but for now it would be great if you spend those 2 seconds already now :)

"Tagging" is generally highly appreciated in regards to "reproducible builds" and here especially for the "Rakudo Star" modules

THANK YOU!

README.md should show library name

It would be nice if the README showed the module that we needed to import. (Have to guess based on repo name or look in META6.json)

update file extensions

===> Testing: File::Directory::Tree
[File::Directory::Tree] Saw 1 occurrence of deprecated code.
[File::Directory::Tree] ================================================================================
[File::Directory::Tree] .pm file extension in raku library path seen at:
[File::Directory::Tree]   file#/private/var/folders/8n/rypl9_990b9578zd5435pgr40000gn/T/.zef/1690673565.99479/File%3A%3ADirectory%3A%3ATree%3Aver%3C%2A%3E%3Aauth%3Cgithub%3Alabster%3E.tar.gz/p6-file-directory-tree-master/lib, line 0
[File::Directory::Tree] Please use the .rakumod extension for raku modules, or include a META6.json file that explicitly declares each raku module file instead.
[File::Directory::Tree] --------------------------------------------------------------------------------
[File::Directory::Tree] Please contact the author to have these occurrences of deprecated code
[File::Directory::Tree] adapted, so that this message will disappear!

Update to use 'auth' in META6.json

  "author"      : "labster",

Should be auth instead of author; as I understand it, this used to be allowed before 6.c, but is no longer the standard.