laceywalkerr/controlflow

Book 1, Chapter 9

I am a student from Nashville Software School (Cohort 43)

• 🌱 I am learning all about C#, .Net, SQL, and React.js!
• 💬 Feel free to ask about any of my repositories! I love talking about my Front End Capstone: Paranormal-Apptivity 👻
• 📫 You may contact me through email [email protected] or by my Linkedln.
• ⚡ I'm in the process of completing my personal website, check it out! Click Here (Kindly run on desktop)

controlflow's Issues

Code Review

It seems that you wrote code for the Roommate project by trying to follow the pattern created by the code that was given to you. This is usually a good strategy, HOWEVER, the code you wrote does not work. In fact, it would not compile. This suggests that you didn't test it. You must test your code as you go. You should write as little code as possible before testing it.

The Room property of a Roommate is not a string. This code doesn't look like it would compile. You should fix errors like this before moving onto writing more code.

ControlFlow/Roommates/Roommates/Program.cs

Lines 82 to 90 in 12e54e4

	Roommate Gus = new Roommate
	{
	Firstname = "Gus",
	Lastname = "Herring",
	RentPortion = 500,
	MovedInDate = 090920,
	Room = "GuestRoom"
	};

This is invalid SQL

ControlFlow/Roommates/Roommates/Repositories/RoomateRepository.cs

Line 24 in 12e54e4

cmd.CommandText = "SELECT Id Firstname Lastname RentPortion MovedInDate Room FROM Roommate";

The Room property is not a string

ControlFlow/Roommates/Roommates/Repositories/RoomateRepository.cs

Line 49 in 12e54e4

string RoomValueValue = reader.GetString(RoomValueColumnPosition);

This is invalid SQL

ControlFlow/Roommates/Roommates/Repositories/RoomateRepository.cs

Line 79 in 12e54e4

cmd.CommandText = "SELECT Firstname Lastname RentPortion MovedInDate Room FROM Roommate WHERE Id = @id";

The Room property is not a string

ControlFlow/Roommates/Roommates/Repositories/RoomateRepository.cs

Line 94 in 12e54e4

Room = reader.GetString(reader.GetOrdinal("LastName")),