ladysnake/effective

A Minecraft Quilt client-side mod adding ambient and environmental interaction effects to enhance immersion.

A Quilt client-side mod improving Minecraft's ambience through particles, visual effects and sounds.

The mod adds various effects like water splashes, waterfall clouds, fireflies, improved visual effects, screen shake and many more.

Every effect is customisable and can be toggled in the configuration.

Video showcase (Effective 2.1 + in depth cascade system explanation)

Gallery

Current features:

Water effects:

• Splashes, droplets and ripples when entities fall in water
• Waterfall clouds
  • Appears when water flows into two block deep water source blocks / a water source above a wool block (to make it silent)
  • Can also be used on beaches to simulate waves crashing
• Waterfall mist
  • Appears when water directly flows from above into source blocks
  • Can be used to create fog or mist ambiences
  • If a water source above a wool block is used instead of two water sources, the mist will be colored after the wool
• Flowing water droplets
• Rain ripples
• Glowing plankton
  • Makes splashes, droplets, ripples and waterfall clouds glow blue in warm oceans
• Chests open underwater emit bubbles
  • Chests with soul sand below them open randomly when underwater

Entity effects:

• Glow squids hypnotize players
• Allay trails
• Golden Allays

Screen shake effects for:

• Warden roars
• Warden sonic booms
• Ravager roars
• Ender dragon roars

Illuminated effects:

• Fireflies in forests and humid biomes
  • Frequency depending on the biome's humidity, the higher the more appear
• Chorus petals around Chorus trees and when breaking Chorus flowers
  • Frequency depending on the Chorus flower's age
• Will o' Wisps in soul sand valleys
• Eyes in the dark that creep on you during Halloween

Improved effects for:

• Fireballs
• Dragon fireballs and breath
• Spectral arrows
• Glow squid particles

Miscellaneous effects:

• Sculk dust floating out of sculk blocks
• Cosmetics for supporters: support the mod here!
  • Support dashboard
• Ultrakill parry effect when deflecting Ghast fireballs

FAQ

Q: Can I use this mod on a vanilla server?

A: Yes. If you have installed this mod on your Minecraft client, you will be able to connect to vanilla Minecraft servers and the ambient effects will work as intended.

Q: Why Quilt? Why not Forge or Fabric?

A: Short answer: some utilities and libraries I need for my mods are only available for Quilt. I also do not wish to continue supporting loaders led by transphobes / racists / horrible people in general, especially when a better product like Quilt exists. If you want the long version of it, it's here.

Now if you want the long version...

I don't have any problem dissociating a project from the person behind it when that project is the best there is, however, Fabric's lead dev's transphobia genuinely got in the way of code contributions that would've been great additions to the loader's API (these contributions being made by trans people). Certain systems like the custom biome, dimension or multipart APIs of Fabric have a lot of problems and sometimes straight up don't work, while these issues have been fixed on Quilt.

For Forge, it's not so much about the devs being bad people, it's more that the way Forge does things and forces modders to do things in a particular (and in my opinion, complicated) way genuinely got me to quit modding before I switched to Fabric when it first came out. On top of that, Forge devs have in the past caused me and my friends quite a bit of trouble and unfortunate interactions, and when I did allow Forge ports of my mods to be made, I would have people come to me regarding issues on the Forge version, which I had nothing to do with.

Additionally, Quilt has a bigger team, and I personally know most of the devs. Therefore, I can also try to help by directly giving feedback or contributions to them if need be, unlike with Fabric or Forge. To also quote a friend I completely agree with: "The argument of "X modloader has no popular mods ergo no popular mods should move to it" is circular and, to put it bluntly, a tad idiotic. I've heard it with Fabric before, and as I did not listen previously I will not listen now. Quilt is a modloader that I can trust the development team of, and thus I develop on it."

If you're upset about the mod not being available to you because you don't wanna use Quilt, I can understand that. However, please also understand that if it weren't for Quilt, I probably wouldn't have updated my mod anyway, so you're technically not missing out on anything! Ultimately, whether or not you want to use this mod is entirely your choice, so do not play victim and put the blame on me if you do not wish to go through the steps to play with it.

Finally, I mod for myself above all, releasing my mods is just a bonus I provide for free. This is a hobby that should stay enjoyable, and altough I'm trying my best to keep it that way, it's becoming harder and harder as time passes due to entitled players and the incredibly toxic modding community. This is my work, my mod, and I am free to do whatever I want with it. If I don't want it to be available for loaders I dislike and don't want to support, I am free to make that choice without having to justify it. However, I still hope this explanation gives a little more insight and helps you understand!

🐀❤️

Q: But I really wanna play with this mod and I play on Fabric!

A: You can run Fabric mods on Quilt. 99% of Fabric mods run perfectly on Quilt, so if you wanna use this mod alongside Fabric ones, consider switching. It's not as big of a task to move as it seems. If you find an incompatibility from a Fabric mod on Quilt, you can report it here and the Quilt team will do its best.

Q: Can I port this mod to Forge / Fabric?

A: No. I am not comfortable with ports of my mod being made for other loaders I do not wish to support, for the reason listed above.

Q: Can I port this mod to Bedrock?

A: Yes. Unlike Fabric or Forge, if you wish to make a version of this mod for Minecraft Bedrock edition, I do not have an issue with it. However, please contact me first to get proper written permission.

Q: Can you backport this mod to 1.x? When will you update to 1.x?

A: No. I mod Minecraft as a hobby with very limited time. Therefore, I will not backport this mod to older versions of Minecraft, and I will update it to future versions when I feel like it. If you want it updated to newer versions, feel free to contribute to the mod and make a pull request, it's appreciated! Otherwise, don't come begging.

Q: Can I include this mod in a modpack?**

A: Yes you can. Go ahead, don't bother asking. Please however provide credit and a link to either the GitHub repository, Modrinth or CurseForge project page.

Copyright (C) 2023 Ladysnake

effective's Issues

downgrade to fabric 1.17 pls

Sound of waterfalls is EXTREMELY LOUD and does not decrease with distance

The title says it all.
I'm pretty sure one of my mods is doing this, I'll be back with the mod name soon

Too Many Lava Splashes.

When an item or entity goes into lava there are too many splashes. Instead of just one it makes one for everyone time its colliding with the lava.
Im using Fabric Loader 0.12.12 with the latest update for fabric API
For ex:

Lava.Clip.mp4

Note i did test it without item physics and there was no difference

Splash not working when water is 1 block deep

heres an example

Minecraft_.1.18.1.-.Multiplayer.3rd-party.Server.2021-12-25.16-24-03.1.mp4

ㅤㅤ

splash doesnt work

when I put the mod in minecraft I made a world for the mod but for some reason the splash doesn't appear :(

Black Splashes

The splashes are completely black and not 3D, and most mobs won’t even activate the splashes, lava splashes work fine. I know there are other issues with this in it but I wanted to make it its own issues, and this uses different mods then them.

Mods using:

Cascade effects don't work with Sodium and Iris

The cascade effects just don't appear and there is no sound either. Not sure if this issue is exclusive to compatibility with Sodium but I'm too lazy to find out lol.

Also, sometimes splashes don't calculate properly if ticks are running behind or you're on a server.

Can you (The one who created this mod) make a new version for FORGE please?

No effects, other than little mist from waterfall

i only get the little effects on a water fall, none of the splashes or the waterfall cascade
Im running 1.18, with Iris and Sodium, if this changes anything
Thanks in advance!

Too much lag with cascades

The cascades cause too much lag, my PC is slow and can't handle it.

Horrible performance when using optifine's internal shaders

Hello, I was playing with this mod installed. It would work just fine until I unloaded a chunk with a waterfall and then reloaded it. My game would become incredibly laggy and borderline unplayable. Is there anyway this mod could be optimized in the future?

Thanks,

Lagging in the Nether

I have been experiencing insane lag in the nether and looked through my mods individually to find the culprit, and unfortunately, this lovely mod is it. I believe since the Nether is mostly liquid and since there are quite a number of entities that are in that lava there are constant splashes which causes this lag. Im no minecraft mod creator but I would think that if you could use instancing for the mesh or have a LOD where if an entity is too far then dont make it splash might help.

Again, Im no minecraft mod developer but can see where there can be some optimization routes to take.

[Suggestion] Make splashes respect water color

Currently, splashes are a singular, universal color.
This looks pretty weird in water that doesn't match:

If the splash could be made to match the color of the water it's on, that could improve it quite a bit.

ConcurrentModificationException looking like its coming from Effective

Running Medieval Minecraft 1.18.1 v7 with effective added in on a server.
Only one of our players has this issue, everyone else is fine. If it matters, he chose Siren for his Origin's choice and spends most of his time underwater.

It doesn't seem to be repeatable in any specific area, and happens randomly, sometimes right after logging in, sometimes after several hours.

Crash Log Attached
crash_log.txt

Magma Cubes Cause Lag On Lava

Magma cubes bounce on the "sea level" lava in the Nether, causing continuous lag.
It spiked my game from 282 fps, to 131, then 30.

Untitled.mp4

(Slight cut to fit 10MB, even without the cut, you can see my frames drop at the very start)

List of my mods:

Possible Incompatibility or Something is Wrong

Started using the newer version of Effective and all the stuff missing from the issue with cascades not showing up and all that with Sodium is resolved, but the noise from the cascades will play almost everywhere when the chunk that the cascade is in is loaded.

Constant Splashes from Magma Cubes

Magma cubes, in lava, are constantly bouncing on the surface, and it seems to count as a pretty decent splash each time.

Crash

[08/01/2022 19:26:14 PM] [Render thread/INFO] Stopping worker threads
[08/01/2022 19:26:23 PM] at Not Enough Crashes deobfuscated stack trace.(1.18.1+build.12)
[08/01/2022 19:26:23 PM] at java.util.HashMap$HashIterator.nextNode(HashMap.java:1597)
[08/01/2022 19:26:23 PM] at java.util.HashMap$KeyIterator.next(HashMap.java:1620)
[08/01/2022 19:26:23 PM] at ladysnake.effective.client.world.WaterfallCloudGenerators.tick(WaterfallCloudGenerators.java:34)
[08/01/2022 19:26:23 PM] at ladysnake.effective.client.Effective.lambda$onInitializeClient$2(Effective.java:121)
[08/01/2022 19:26:23 PM] at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$6(ClientTickEvents.java:111)
[08/01/2022 19:26:23 PM] at net.minecraft.client.world.ClientWorld.handler$cii000$tickWorldAfterBlockEntities(ClientWorld:4100)
[08/01/2022 19:26:23 PM] at net.minecraft.world.World.tickBlockEntities(World:483)
[08/01/2022 19:26:23 PM] at net.minecraft.client.world.ClientWorld.tickEntities(ClientWorld:205)
[08/01/2022 19:26:23 PM] at net.minecraft.client.MinecraftClient.tick(MinecraftClient:1751)
[08/01/2022 19:26:23 PM] at net.minecraft.client.MinecraftClient.render(MinecraftClient:1086)
[08/01/2022 19:26:23 PM] at net.minecraft.client.MinecraftClient.run(MinecraftClient:733)
[08/01/2022 19:26:23 PM] at net.minecraft.client.main.Main.main(Main:238)
[08/01/2022 19:26:23 PM] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[08/01/2022 19:26:23 PM] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[08/01/2022 19:26:23 PM] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[08/01/2022 19:26:23 PM] at java.lang.reflect.Method.invoke(Method.java:568)
[08/01/2022 19:26:23 PM] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608)
[08/01/2022 19:26:23 PM] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
[08/01/2022 19:26:23 PM] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[08/01/2022 19:26:23 PM] [Render thread/FATAL] Unreported exception thrown!
[08/01/2022 19:26:24 PM] ---- Minecraft Crash Report ----
[08/01/2022 19:26:24 PM] // Don't do that.
[08/01/2022 19:26:24 PM]
[08/01/2022 19:26:24 PM] Time: 1/8/22, 7:26 PM
[08/01/2022 19:26:24 PM] Description: Unexpected error
[08/01/2022 19:26:24 PM]
[08/01/2022 19:26:24 PM] java.util.ConcurrentModificationException
[08/01/2022 19:26:24 PM] at Not Enough Crashes deobfuscated stack trace.(1.18.1+build.12)
[08/01/2022 19:26:24 PM] at java.util.HashMap$HashIterator.nextNode(HashMap.java:1597)
[08/01/2022 19:26:24 PM] at java.util.HashMap$KeyIterator.next(HashMap.java:1620)
[08/01/2022 19:26:24 PM] at ladysnake.effective.client.world.WaterfallCloudGenerators.tick(WaterfallCloudGenerators.java:34)
[08/01/2022 19:26:24 PM] at ladysnake.effective.client.Effective.lambda$onInitializeClient$2(Effective.java:121)
[08/01/2022 19:26:24 PM] at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$6(ClientTickEvents.java:111)
[08/01/2022 19:26:24 PM] at net.minecraft.client.world.ClientWorld.handler$cii000$tickWorldAfterBlockEntities(ClientWorld:4100)
[08/01/2022 19:26:24 PM] at net.minecraft.world.World.tickBlockEntities(World:483)
[08/01/2022 19:26:24 PM] at net.minecraft.client.world.ClientWorld.tickEntities(ClientWorld:205)
[08/01/2022 19:26:24 PM] at net.minecraft.client.MinecraftClient.tick(MinecraftClient:1751)
[08/01/2022 19:26:24 PM] at net.minecraft.client.MinecraftClient.render(MinecraftClient:1086)
[08/01/2022 19:26:24 PM] at net.minecraft.client.MinecraftClient.run(MinecraftClient:733)
[08/01/2022 19:26:24 PM] at net.minecraft.client.main.Main.main(Main:238)
[08/01/2022 19:26:24 PM] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[08/01/2022 19:26:24 PM] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[08/01/2022 19:26:24 PM] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[08/01/2022 19:26:24 PM] at java.lang.reflect.Method.invoke(Method.java:568)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[08/01/2022 19:26:24 PM]
[08/01/2022 19:26:24 PM]
[08/01/2022 19:26:24 PM] A detailed walkthrough of the error, its code path and all known details is as follows:
[08/01/2022 19:26:24 PM] ---------------------------------------------------------------------------------------
[08/01/2022 19:26:24 PM]
[08/01/2022 19:26:24 PM] -- Head --
[08/01/2022 19:26:24 PM] Thread: Render thread
[08/01/2022 19:26:24 PM] Stacktrace:
[08/01/2022 19:26:24 PM] at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597)
[08/01/2022 19:26:24 PM] at java.base/java.util.HashMap$KeyIterator.next(HashMap.java:1620)
[08/01/2022 19:26:24 PM] at ladysnake.effective.client.world.WaterfallCloudGenerators.tick(WaterfallCloudGenerators.java:34)
[08/01/2022 19:26:24 PM] at ladysnake.effective.client.Effective.lambda$onInitializeClient$2(Effective.java:121)
[08/01/2022 19:26:24 PM] at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$6(ClientTickEvents.java:111)
[08/01/2022 19:26:24 PM] at net.minecraft.class_638.handler$cii000$tickWorldAfterBlockEntities(class_638.java:4100)
[08/01/2022 19:26:24 PM] at net.minecraft.class_1937.method_18471(class_1937.java:483)
[08/01/2022 19:26:24 PM] at net.minecraft.class_638.method_18116(class_638.java:205)
[08/01/2022 19:26:24 PM]
[08/01/2022 19:26:24 PM] -- Affected level --
[08/01/2022 19:26:24 PM] Details:
[08/01/2022 19:26:24 PM] All players: 1 total; [class_746['MINECRAFTUSERNAME'/23, l='ClientWorld minecraft:overworld', x=3109.54, y=97.97, z=1931.49]]
[08/01/2022 19:26:24 PM] Chunk stats: Client Chunks (ImmPtl) 249
[08/01/2022 19:26:24 PM] Level dimension: minecraft:overworld
[08/01/2022 19:26:24 PM] Level spawn location: World: (0,63,0), Section: (at 0,15,0 in 0,3,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
[08/01/2022 19:26:24 PM] Level time: 893219 game time, 132554 day time
[08/01/2022 19:26:24 PM] Server brand: fabric
[08/01/2022 19:26:24 PM] Server type: Integrated singleplayer server
[08/01/2022 19:26:24 PM] Stacktrace:
[08/01/2022 19:26:24 PM] at net.minecraft.class_638.method_8538(class_638.java:408)
[08/01/2022 19:26:24 PM] at net.minecraft.class_310.method_1587(class_310.java:2402)
[08/01/2022 19:26:24 PM] at net.minecraft.class_310.method_1514(class_310.java:757)
[08/01/2022 19:26:24 PM] at net.minecraft.client.main.Main.main(Main.java:238)
[08/01/2022 19:26:24 PM] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[08/01/2022 19:26:24 PM] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[08/01/2022 19:26:24 PM] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[08/01/2022 19:26:24 PM] at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[08/01/2022 19:26:24 PM]
[08/01/2022 19:26:24 PM] -- Last reload --
[08/01/2022 19:26:24 PM] Details:
[08/01/2022 19:26:24 PM] Reload number: 1
[08/01/2022 19:26:24 PM] Reload reason: initial
[08/01/2022 19:26:24 PM] Finished: Yes
[08/01/2022 19:26:24 PM] Packs: Default, Fabric Mods, fabric-copper-golem/copper_golem, fabric-diagonal-panes/default
[08/01/2022 19:26:24 PM]
[08/01/2022 19:26:24 PM] -- System Details --
[08/01/2022 19:26:24 PM] Details:
[08/01/2022 19:26:24 PM] Minecraft Version: 1.18.1
[08/01/2022 19:26:24 PM] Minecraft Version ID: 1.18.1
[08/01/2022 19:26:24 PM] Operating System: Windows 10 (amd64) version 10.0
[08/01/2022 19:26:24 PM] Java Version: 17.0.1, Microsoft
[08/01/2022 19:26:24 PM] Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
[08/01/2022 19:26:24 PM] Memory: 1614554064 bytes (1539 MiB) / 5368709120 bytes (5120 MiB) up to 5368709120 bytes (5120 MiB)
[08/01/2022 19:26:24 PM] CPUs: 8
[08/01/2022 19:26:24 PM] Processor Vendor: AuthenticAMD
[08/01/2022 19:26:24 PM] Processor Name: AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx
[08/01/2022 19:26:24 PM] Identifier: AuthenticAMD Family 23 Model 24 Stepping 1
[08/01/2022 19:26:24 PM] Microarchitecture: Zen / Zen+
[08/01/2022 19:26:24 PM] Frequency (GHz): 2.10
[08/01/2022 19:26:24 PM] Number of physical packages: 1
[08/01/2022 19:26:24 PM] Number of physical CPUs: 4
[08/01/2022 19:26:24 PM] Number of logical CPUs: 8
[08/01/2022 19:26:24 PM] Graphics card #0 name: AMD Radeon(TM) Vega 8 Graphics
[08/01/2022 19:26:24 PM] Graphics card #0 vendor: Advanced Micro Devices, Inc. (0x1002)
[08/01/2022 19:26:24 PM] Graphics card #0 VRAM (MB): 2048.00
[08/01/2022 19:26:24 PM] Graphics card #0 deviceId: 0x15d8
[08/01/2022 19:26:24 PM] Graphics card #0 versionInfo: DriverVersion=26.20.11002.13003
[08/01/2022 19:26:24 PM] Memory slot #0 capacity (MB): 4096.00
[08/01/2022 19:26:24 PM] Memory slot #0 clockSpeed (GHz): 2.40
[08/01/2022 19:26:24 PM] Memory slot #0 type: DDR4
[08/01/2022 19:26:24 PM] Memory slot #1 capacity (MB): 4096.00
[08/01/2022 19:26:24 PM] Memory slot #1 clockSpeed (GHz): 2.40
[08/01/2022 19:26:24 PM] Memory slot #1 type: DDR4
[08/01/2022 19:26:24 PM] Virtual memory max (MB): 24449.98
[08/01/2022 19:26:24 PM] Virtual memory used (MB): 18759.25
[08/01/2022 19:26:24 PM] Swap memory total (MB): 18432.00
[08/01/2022 19:26:24 PM] Swap memory used (MB): 4888.46
[08/01/2022 19:26:24 PM] JVM Flags: 12 total; -XX:-OmitStackTraceInFastThrow -Xms1024M -Xmx5120M -XX:MetaspaceSize=448M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M
[08/01/2022 19:26:24 PM] Fabric Mods:
[08/01/2022 19:26:24 PM] additionaladditions: Additional Additions 3.0.1
[08/01/2022 19:26:24 PM] adorn: Adorn 3.1.0+1.18.1
[08/01/2022 19:26:24 PM] advanced_runtime_resource_pack: Runtime Resource Pack 0.5.4
[08/01/2022 19:26:24 PM] advancednetherite: Advanced Netherite 1.2.0-1.18
[08/01/2022 19:26:24 PM] advancementframes: Advancement Frames 1.18-1.5.0
[08/01/2022 19:26:24 PM] ae2: Applied Energistics 2 10.0.0-beta.4
[08/01/2022 19:26:24 PM] alternatecurrent: Alternate Current 1.1.0
[08/01/2022 19:26:24 PM] amecs: Amecs 1.3.4+mc.1.18-pre1
[08/01/2022 19:26:24 PM] amecsapi: Amecs API 1.3.0+mc1.18-pre1
[08/01/2022 19:26:24 PM] ancientgateways: Ancient Gateways 1.2.0
[08/01/2022 19:26:24 PM] animatica: Animatica 0.2+1.18
[08/01/2022 19:26:24 PM] apples: Apples & Carrots 1.5
[08/01/2022 19:26:24 PM] appleskin: AppleSkin mc1.18-2.2.0
[08/01/2022 19:26:24 PM] aqupdcaracal: Caracal mob 1.18-1.3.5
[08/01/2022 19:26:24 PM] aqupdgrizzly: Grizzly Bear mob 1.18-1.2.1
[08/01/2022 19:26:24 PM] arcanus: Arcanus 1.25
[08/01/2022 19:26:24 PM] architectury: Architectury 3.2.63
[08/01/2022 19:26:24 PM] artifality: Artifality 0.5.0
[08/01/2022 19:26:24 PM] artisanat: Artisanat 2.2.1
[08/01/2022 19:26:24 PM] assembly: Assembly 21w06a-1.0.0
[08/01/2022 19:26:24 PM] automaticdoors-fabric: Automatic Doors (Fabric) 1.9
[08/01/2022 19:26:24 PM] badstdout: BadStdOut 1.1.1-1.18
[08/01/2022 19:26:24 PM] balm-fabric: Balm 2.4.0+0
[08/01/2022 19:26:24 PM] barkcarpets: Bark Carpets 1.18
[08/01/2022 19:26:24 PM] bcdt_expansion: BCDT Expansion 1.18.1-1.1.1
[08/01/2022 19:26:24 PM] bclib: BCLib 1.2.1
[08/01/2022 19:26:24 PM] bedrockcrafter-fabric: Bedrock Crafter 1.1.3
[08/01/2022 19:26:24 PM] beenfo: Beenfo 1.18.1-fabric0.45.0-1.3.3
[08/01/2022 19:26:24 PM] bitsandchisels: BitsAndChisels 2.6.1
[08/01/2022 19:26:24 PM] config2brigadier: Config to Brigadier 1.0.2
[08/01/2022 19:26:24 PM] creativekeybind: CreativeKeybind 1.18.1-fabric-1.0.2
[08/01/2022 19:26:24 PM] enhancedblockentities: Enhanced Block Entities 0.5+1.18
[08/01/2022 19:26:24 PM] fabric-diagonal-panes: Fabric Diagonal Panes 0.6.0
[08/01/2022 19:26:24 PM] fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.7+b4f4f6cd65
[08/01/2022 19:26:24 PM] farmingforblockheads: Farming for Blockheads 9.0.2
[08/01/2022 19:26:24 PM] figura: Figura 0.0.7
[08/01/2022 19:26:24 PM] languagereload: Language Reload 1.2
[08/01/2022 19:26:24 PM] notenoughanimations: NotEnoughAnimations 1.4.0
[08/01/2022 19:26:24 PM] omega-config: OmegaConfig 1.0.8
[08/01/2022 19:26:24 PM] org_jetbrains_kotlin_kotlin-stdlib-jdk7: kotlin-stdlib-jdk7 1.6.10
[08/01/2022 19:26:24 PM] paperdoll: PaperDoll 1.0.0-mc1.18-pre1
[08/01/2022 19:26:24 PM] at Not Enough Crashes deobfuscated stack trace.(1.18.1+build.12)
[08/01/2022 19:26:24 PM] at net.minecraft.client.gui.screen.ingame.HandledScreens.register(HandledScreens:76)
[08/01/2022 19:26:24 PM] at net.fabricmc.fabric.api.client.screenhandler.v1.ScreenRegistry.register(ScreenRegistry.java:66)
[08/01/2022 19:26:24 PM] at appeng.init.client.InitScreens.register(InitScreens.java:201)
[08/01/2022 19:26:24 PM] at appeng.init.client.InitScreens.init(InitScreens.java:122)
[08/01/2022 19:26:24 PM] at appeng.core.AppEngClient.postClientSetup(AppEngClient.java:204)
[08/01/2022 19:26:24 PM] at appeng.core.AppEngClient.clientSetup(AppEngClient.java:177)
[08/01/2022 19:26:24 PM] at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientLifecycleEvents.lambda$static$0(ClientLifecycleEvents.java:38)
[08/01/2022 19:26:24 PM] at net.minecraft.client.MinecraftClient.handler$cin000$onStart(MinecraftClient:13008)
[08/01/2022 19:26:24 PM] at net.minecraft.client.MinecraftClient.run(MinecraftClient:712)
[08/01/2022 19:26:24 PM] at fudge.notenoughcrashes.mixinhandlers.InGameCatcher.handleClientCrash(InGameCatcher.java:37)
[08/01/2022 19:26:24 PM] at net.minecraft.client.MinecraftClient.modify$enb000$atTheEndOfSecondCatchBeforePrintingCrashReport(MinecraftClient:23046)
[08/01/2022 19:26:24 PM] at net.minecraft.client.MinecraftClient.run(MinecraftClient:760)
[08/01/2022 19:26:24 PM] at net.minecraft.client.main.Main.main(Main:238)
[08/01/2022 19:26:24 PM] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[08/01/2022 19:26:24 PM] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[08/01/2022 19:26:24 PM] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[08/01/2022 19:26:24 PM] at java.lang.reflect.Method.invoke(Method.java:568)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
[08/01/2022 19:26:24 PM] at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[08/01/2022 19:26:24 PM] [Render thread/ERROR] Unhandled game exception
[08/01/2022 19:26:24 PM] [Render thread/INFO] Stopping!
[08/01/2022 19:26:24 PM] [CullThread/INFO] [dev.tr7zw.entityculling.CullTask] Shutting down culling task!
[08/01/2022 19:26:25 PM] [Render thread/INFO] closing rrp chisel:blocks
[08/01/2022 19:26:25 PM] [Render thread/INFO] closing rrp ebe:pack
[08/01/2022 19:26:25 PM] [Render thread/INFO] closing rrp phonos:data
[08/01/2022 19:26:25 PM] [Render thread/INFO] closing rrp secretrooms:secret_rooms_data
[08/01/2022 19:26:25 PM] [Render thread/INFO] closing rrp phonos:assets
[08/01/2022 19:26:25 PM] [Render thread/INFO] closing rrp secretrooms:secret_rooms_assets
[08/01/2022 19:26:28 PM] Checking for updated files!

Black Splashes With Illuminations

The black splashes bug happens with Illuminations installed

Cascade water spawn out of nowhere

It spawn inside water, see nothing inside the cascade but water.

Screenshots:

Mods used:

Curseforge download does not work

When trying to download the mod from the curseforge page, the download redirects to a 404 page

Too many particle effects cause serious performance problem

The number of particle effects generated will increase over time. Used Optifine at the same time, maybe that's why.

Effective causing a game crash!

Something is happening with effective that is causing a game crash:

Crash Report:
https://paste.gg/p/anonymous/58521a75616841c398a638887744ee2c

If you need a mod list I can post it

[Feature Request] Cascade volume control

The cascade sound is quite loud, and it'd be nice if players had the option to turn it down to be more subtle / less distracting

Splash model not appearing

When a mob hits the water at high altitude the splash model wont appear and just the ripples appear

when combined with immersive portals, console is spammed with random numbers

something is logging in chat with random numbers,
tested with effective 1.1
fabric 0.12.12
mc 1.18.1
azul jdk 17
fabric api 0.46.4 for 1.18
and immersive portals 1.2.5
link to immserive portals github issue: #980

Request of a Feature. Transparency for the splashes.

Not sure if it is possible for to implement a config option to edit the transparency of slashes, but if it is, it could help with the jarring look of the slashes when using shaders.

Possible workaround for a distance requirement for when the waterfall effect starts

I noticed in the showcase video for this mod that all waterflow, no matter how small, would have the waterfall effects. I think that OreCruncher's Dynamic Surroundings mod (https://www.curseforge.com/minecraft/mc-mods/dynamic-surroundings-fabric-edition) may have the solution to the problem. Its waterfall sounds require the water flow to be falling from a certain height in order to create the sounds, and it is client side + server friendly. I don't know if there is some other limitation or something I am just not aware of, but I figured it would still be worth mentioning just in case.

Volume of Waterfalls don't decrease over distance & Too loud

Here's a video showing the issue (sorry for the bad quality but 10mb isn't much)

05.-.23.39.12.-.Wednesday.mp4

[Suggestion] Better lava splashes

The splashes of lava were in 50 first seconds of One trillion views on YouTube Minecraft video: https://youtu.be/YXY74kWderc?t=50 You can see some actual lava splashes, I think it would fit more to this great mod.

No cascade clouds in 1.18 using Sodium 0.4.0.alpha5

Well, that's it really. There are splashing water particles in waterfalls, but no cascade clouds (visual particles nor sound).

I came to this conclusion by isolating all the mods but Effective + Sodium.

Also, without Sodium, or using Optifabric (works properly), cascade sounds are EXTREMELY LOUD, with an obnoxiously far range.

Splashes appear as entirely black using Sodium and Iris

Large splashes from players and entities appear as transparent/black, no matter the graphics settings.

add a config

this mod is really good but the water fall particles lag my game and also are really loud so i would like the ability to disable them or just the sounds.

Waterfall Sound is way too loud

Random Crash

mod version 1.1

---- Minecraft Crash Report ----
// This doesn't make any sense!

Time: 10.02.2022, 11:16
Description: Unexpected error

java.util.ConcurrentModificationException
	at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597)
	at java.base/java.util.HashMap$KeyIterator.next(HashMap.java:1620)
	at ladysnake.effective.client.world.WaterfallCloudGenerators.tick(WaterfallCloudGenerators.java:34)
	at ladysnake.effective.client.Effective.lambda$onInitializeClient$2(Effective.java:121)
	at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$6(ClientTickEvents.java:111)
	at net.minecraft.class_638.handler$zhj000$tickWorldAfterBlockEntities(class_638.java:1600)
	at net.minecraft.class_1937.method_18471(class_1937.java:483)
	at net.minecraft.class_638.method_18116(class_638.java:251)
	at net.minecraft.class_310.method_1574(class_310.java:1751)
	at net.minecraft.class_310.method_1523(class_310.java:1086)
	at net.minecraft.class_310.method_1514(class_310.java:733)
	at net.minecraft.client.main.Main.main(Main.java:238)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597)
	at java.base/java.util.HashMap$KeyIterator.next(HashMap.java:1620)
	at ladysnake.effective.client.world.WaterfallCloudGenerators.tick(WaterfallCloudGenerators.java:34)
	at ladysnake.effective.client.Effective.lambda$onInitializeClient$2(Effective.java:121)
	at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$6(ClientTickEvents.java:111)
	at net.minecraft.class_638.handler$zhj000$tickWorldAfterBlockEntities(class_638.java:1600)
	at net.minecraft.class_1937.method_18471(class_1937.java:483)
	at net.minecraft.class_638.method_18116(class_638.java:251)

-- Affected level --
Details:
	All players: 1 total; [class_746['BoBkiNN_'/330, l='ClientLevel', x=-45.17, y=63.00, z=-16.50]]
	Chunk stats: 729, 428 F: 20 L: 0 U: 0
	Level dimension: minecraft:overworld
	Level spawn location: World: (-45,63,-14), Section: (at 3,15,2 in -3,3,-1; chunk contains blocks -48,-64,-16 to -33,319,-1), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1)
	Level time: 47169 game time, 1000 day time
	Server brand: Paper
	Server type: Non-integrated multiplayer server
Stacktrace:
	at net.minecraft.class_638.method_8538(class_638.java:517)
	at net.minecraft.class_310.method_1587(class_310.java:2402)
	at net.minecraft.class_310.method_1514(class_310.java:757)
	at net.minecraft.client.main.Main.main(Main.java:238)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Last reload --
Details:
	Reload number: 2
	Reload reason: manual
	Finished: Yes
	Packs: Default, 1.0.0v_VisualFireworks.zip, 3d-torches-v1-3-3.zip, HatStriders_v1.0_2.zip, fresh-pillagers-e280.zip, BetterCarpets.zip, Fabric Mods, Dark_Loading_Screen.zip, VanillaTweaks_r515123.zip, 1.17 panorama pack.zip, replaymod_lang

-- System Details --
Details:
	Minecraft Version: 1.18.1
	Minecraft Version ID: 1.18.1
	Operating System: Windows 7 (amd64) version 6.1
	Java Version: 17.0.1, Microsoft
	Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
	Memory: 2137765752 bytes (2038 MiB) / 2852126720 bytes (2720 MiB) up to 3154116608 bytes (3008 MiB)
	CPUs: 4
	Processor Vendor: GenuineIntel
	Processor Name: Intel(R) Core(TM) i3-2120 CPU @ 3.30GHz
	Identifier: Intel64 Family 6 Model 42 Stepping 7
	Microarchitecture: Sandy Bridge (Client)
	Frequency (GHz): 3,29
	Number of physical packages: 1
	Number of physical CPUs: 2
	Number of logical CPUs: 4
	Graphics card #0 name: NVIDIA GeForce GTX 1050 Ti
	Graphics card #0 vendor: NVIDIA (0x10de)
	Graphics card #0 VRAM (MB): 4095,00
	Graphics card #0 deviceId: 0x1c82
	Graphics card #0 versionInfo: DriverVersion=30.0.14.7212
	Memory slot #0 capacity (MB): 4096,00
	Memory slot #0 clockSpeed (GHz): 1,33
	Memory slot #0 type: Unknown
	Memory slot #1 capacity (MB): 8192,00
	Memory slot #1 clockSpeed (GHz): 1,60
	Memory slot #1 type: Unknown
	Virtual memory max (MB): 24531,10
	Virtual memory used (MB): 15875,89
	Swap memory total (MB): 12264,62
	Swap memory used (MB): 66,70
	JVM Flags: 10 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmn128M -Xmx3000M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
	Fabric Mods: 
		amecsapi: Amecs API 1.3.3+mc1.18-pre1
		architectury: Architectury 3.2.47
		betterf3: BetterF3 1.2.2
		blue_endless_jankson: jankson 1.2.1
		bobby: Bobby 3.1.0
		clickthrough: ClickThrough 1.18-fabric0.43.1-0.4
		cloth-basic-math: cloth-basic-math 0.6.0
		cloth-config: Cloth Config v6 6.0.45
		coat: Coat 1.0.0-beta.15
		com_moandjiezana_toml_toml4j: toml4j 0.7.2
		com_typesafe_config: config 1.4.1
		confabricate: confabricate 2.1.0-SNAPSHOT+4.1.1
		crowdin-translate: CrowdinTranslate 1.4+1.18
		detailab: Detail Armor Bar 2.6.1+1.18-fabric
		dynamicfps: Dynamic FPS 2.0.6
		effective: Effective 1.1
		fabric: Fabric API 0.44.0+1.18
		fabric-api-base: Fabric API Base 0.4.1+b4f4f6cdc8
		fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.4.0+16d92c47c8
		fabric-biome-api-v1: Fabric Biome API (v1) 6.0.1+ded849a9c8
		fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.9+3ac43d95c8
		fabric-command-api-v1: Fabric Command API (v1) 1.1.6+3ac43d95c8
		fabric-commands-v0: Fabric Commands (v0) 0.2.5+b4f4f6cdc8
		fabric-containers-v0: Fabric Containers (v0) 0.1.18+d154e2c6c8
		fabric-content-registries-v0: Fabric Content Registries (v0) 0.4.5+6f53a73dc8
		fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.1.8+3ac43d95c8
		fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.7+43d29571c8
		fabric-entity-events-v1: Fabric Entity Events (v1) 1.4.5+6b21378ac8
		fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.16+bfa23f17c8
		fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.6+b4f4f6cdc8
		fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.10+3ac43d95c8
		fabric-item-api-v1: Fabric Item API (v1) 1.3.0+691a79b5c8
		fabric-item-groups-v0: Fabric Item Groups (v0) 0.3.3+3ac43d95c8
		fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.8+c8aba2f3c8
		fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.6+b4f4f6cdc8
		fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 1.4.10+c15ca335c8
		fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.0.8+3ac43d95c8
		fabric-mining-level-api-v1: Fabric Mining Level API (v1) 1.0.3+3ac43d95c8
		fabric-mining-levels-v0: Fabric Mining Levels (v0) 0.1.7+b4f4f6cdc8
		fabric-models-v0: Fabric Models (v0) 0.3.3+3ac43d95c8
		fabric-networking-api-v1: Fabric Networking API (v1) 1.0.18+3ac43d95c8
		fabric-networking-v0: Fabric Networking (v0) 0.3.5+b4f4f6cdc8
		fabric-object-builder-api-v1: Fabric Object Builder API (v1) 1.11.0+3b82842ec8
		fabric-object-builders-v0: Fabric Object Builders (v0) 0.7.8+3ac43d95c8
		fabric-particles-v1: Fabric Particles (v1) 0.2.9+526dc1acc8
		fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.8.5+3ac43d95c8
		fabric-renderer-api-v1: Fabric Renderer API (v1) 0.4.9+3ac43d95c8
		fabric-renderer-indigo: Fabric Renderer - Indigo 0.4.12+3ac43d95c8
		fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.7+b4f4f6cdc8
		fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.4+7242e9d7c8
		fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 0.1.18+3ac43d95c8
		fabric-rendering-v0: Fabric Rendering (v0) 1.1.9+b4f4f6cdc8
		fabric-rendering-v1: Fabric Rendering (v1) 1.10.3+6b21378ac8
		fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.4.11+3ac43d9514
		fabric-screen-api-v1: Fabric Screen API (v1) 1.0.7+3ac43d95c8
		fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.1.11+3ac43d95c8
		fabric-structure-api-v1: Fabric Structure API (v1) 2.0.8+295197a7c8
		fabric-tag-extensions-v0: Fabric Tag Extensions (v0) 1.2.5+3ac43d95c8
		fabric-textures-v0: Fabric Textures (v0) 1.0.9+3ac43d95c8
		fabric-tool-attribute-api-v1: Fabric Tool Attribute API (v1) 1.3.4+7de09f55c8
		fabric-transfer-api-v1: Fabric Transfer API (v1) 1.5.5+b4f4f6cdc8
		fabricloader: Fabric Loader 0.12.12
		freelook: freelook 1.1.1
		gbfabrictools: GBfabrictools 1.3.4+1.18
		io_leangen_geantyref_geantyref: geantyref 1.3.11
		jankson: Jankson 4.0.0+j1.2.0
		java: OpenJDK 64-Bit Server VM 17
		kirin: Kirin UI 1.10.0-beta.2
		libgui: LibGui 5.0.0-beta.2+1.18-rc1
		libninepatch: LibNinePatch 1.1.0
		litematica: Litematica 0.0.0-dev.20211203.013300
		malilib: MaLiLib 0.10.0-dev.26
		mambience: MAmbience 3.2.0+1.18
		minecraft: Minecraft 1.18.1
		mm: Manningham Mills 2.3
		modmenu: Mod Menu 3.0.0
		mousewheelie: Mouse Wheelie 1.8.0+mc1.18-pre5
		optifabric: OptiFabric 1.12.10
		org_spongepowered_configurate-core: configurate-core 4.1.1
		org_spongepowered_configurate-extra-dfu4: configurate-extra-dfu4 4.1.1
		org_spongepowered_configurate-gson: configurate-gson 4.1.1
		org_spongepowered_configurate-hocon: configurate-hocon 4.1.1
		plasmo_voice: Plasmo Voice 1.2.9
		presencefootsteps: Presence Footsteps 1.4.0
		randomblockplacement: RandomBlockPlacement 1.18-fabric0.43.1-1.1.2
		replaymod: Replay Mod 1.18.1-2.6.3
		shulkerboxtooltip: Shulker Box Tooltip 3.0.5+1.18
		skinlayers: 3d Skin Layers 1.3.1
		sound_physics_remastered: Sound Physics Remastered 1.18.1-1.0.4
		stendhal: Stendhal 1.2.0-1.18
		tweed4_annotated: tweed4_annotated 1.2.0
		tweed4_base: tweed4_base 1.3.1
		tweed4_data: tweed4_data 1.2.0
		tweed4_data_hjson: tweed4_data_hjson 1.1.0
		tweed4_tailor_coat: tweed4_tailor_coat 1.0.2
		tweed4_tailor_screen: tweed4_tailor_screen 1.0.2
		waveycapes: WaveyCapes 1.0.4
		xaerominimap: Xaero's Minimap 21.22.3.1
		xaeroworldmap: Xaero's World Map 1.18.6.1
	Launched Version: Fabric 1.18.1
	Backend library: LWJGL version 3.2.2 build 10
	Backend API: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 GL version 3.2.0 NVIDIA 472.12, NVIDIA Corporation
	Window size: 1920x1018
	GL Caps: Using framebuffer using OpenGL 3.2
	GL debug messages: 
	Using VBOs: Yes
	Is Modded: Definitely; Client brand changed to 'fabric'
	Type: Client (map_client.txt)
	Graphics mode: fancy
	Resource Packs: vanilla, file/1.0.0v_VisualFireworks.zip (incompatible), file/3d-torches-v1-3-3.zip (incompatible), file/HatStriders_v1.0_2.zip (incompatible), file/fresh-pillagers-e280.zip (incompatible), file/BetterCarpets.zip (incompatible), Fabric Mods, file/Dark_Loading_Screen.zip (incompatible), file/VanillaTweaks_r515123.zip, file/1.17 panorama pack.zip (incompatible)
	Current Language: Русский (Россия)
	CPU: 4x Intel(R) Core(TM) i3-2120 CPU @ 3.30GHz
	OptiFine Version: OptiFine_1.18.1_HD_U_H4
	OptiFine Build: 20211212-175054
	Render Distance Chunks: 10
	Mipmaps: 2
	Anisotropic Filtering: 1
	Antialiasing: 0
	Multitexture: false
	Shaders: null
	OpenGlVersion: 3.2.0 NVIDIA 472.12
	OpenGlRenderer: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2
	OpenGlVendor: NVIDIA Corporation
	CpuCount: 4

-- OptiFabric --
Details:
	OptiFine jar designed for: 1.18.1
	OptiFine jar version: OptiFine_1.18.1_HD_U_H4
	OptiFine jar status: Valid OptiFine installer
	OptiFine remapped jar: D:/Users/Rob/AppData/Roaming/.minecraft/.optifine/OptiFine_1.18.1_HD_U_H4/Optifine-mapped.jar
	OptiFabric error: <None>

splashes dont work on waterlogged blocks

im not sure if this is a bug with other mods
heres my mod list

it doesnt work on blocks that can be walked through in the water mainly

Extreme lag with Sound-Physics-Fabric

vlad2305m/Sound-Physics-Fabric#39
I don't know exactly where the problem lies, but basically as soon as I come close to a waterfall with both mods enabled the game becomes unplayably slow, though it does not crash. Disabling Sound-Physics-Fabric from within its mod menu solves the issue and from the log it's clear that it simply has to deal with too many emitted sounds at once.
latest.log

Unexpected error I java.lang.NullPointerException: Cannot invoke "net.minecraft.class_761.method_8568(net.minecraft.class_2394, boolean, double, double, double, double, double, double)" because "this.field_17780" is null

Everytime when leaving server,a nd try to join again game crashes. Need to restart to join again.

https://pastebin.com/6cr5ZA91

Underwater Waterfalls?

Normal waterfalls work fine. However I came across an underwater waterfall...

Here are the other mods I have, just in case! They're all client-side.

• Blur by Motschen
• Chat Head by dzwdz
• Cloth Config API by shedaniel
• Dynamic Sound Filters by andre111_
• Eating Animation by theone_ss
• ExtraSounds by stashymane
• Illuminations by doctor4t
• Ok Zoomer by EnnuiLangeweile
• Visuality by PinkGoosik

Game crashes sometimes when getting in range of a waterfall

I'm running on 1.18 with optifabric and a sildurs shaders. Sometimes when I load in a waterfall in my server it crashes the whole game. It seems to be an issue at WaterfallCloudGenerators.tick(WaterfallCloudGenerators.java:30) as seen in the crash log below.

This mod is super awesome and have been looking for something like it for a long time and would love to see it be polished up nicely.

[17:03:16] [Render thread/FATAL]: Unreported exception thrown!
java.util.ConcurrentModificationException: null
at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1631) ~[?:?]
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
at ladysnake.effective.client.world.WaterfallCloudGenerators.tick(WaterfallCloudGenerators.java:30) ~[effective-1.0.jar:?]
at ladysnake.effective.client.Effective.lambda$onInitializeClient$2(Effective.java:121) ~[effective-1.0.jar:?]
at net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents.lambda$static$6(ClientTickEvents.java:111) ~[fabric-lifecycle-events-v1-1.4.10+c15ca33514-d830d5ce9751719.jar:?]
at net.minecraft.class_638.handler$zki000$tickWorldAfterBlockEntities(class_638.java:3100) ~[intermediary-fabric-loader-0.12.8-1.18.jar:?]
at net.minecraft.class_1937.method_18471(class_1937.java:483) ~[intermediary-fabric-loader-0.12.8-1.18.jar:?]
at net.minecraft.class_638.method_18116(class_638.java:251) ~[intermediary-fabric-loader-0.12.8-1.18.jar:?]
at net.minecraft.class_310.method_1574(class_310.java:1751) ~[intermediary-fabric-loader-0.12.8-1.18.jar:?]
at net.minecraft.class_310.method_1523(class_310.java:1086) ~[intermediary-fabric-loader-0.12.8-1.18.jar:?]
at net.minecraft.class_310.method_1514(class_310.java:733) [intermediary-fabric-loader-0.12.8-1.18.jar:?]
at net.minecraft.client.main.Main.main(Main.java:236) [intermediary-fabric-loader-0.12.8-1.18.jar:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:599) [fabric-loader-0.12.8.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) [fabric-loader-0.12.8.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.12.8.jar:?]
[17:03:17] [Render thread/INFO]: Clearing audio channels
[17:03:17] [Render thread/INFO]: Stopping microphone thread
[17:03:17] [Render thread/INFO]: Disconnecting voicechat
[17:03:17] [Render thread/INFO]: [STDOUT]: Minimap session finalized.
[17:03:17] [Render thread/INFO]: Removing the schematic world...
[17:03:18] [Thread-1/INFO]: Minecraft instance shutting down, starting the Illuminations uninstaller

Edit: Looking at the source code at that error, I think I see what's going on. A waterfallCloudGenerator is being modified while the lambda expression on line 30 is being executed. This could probably be fixed by using a standard for loop instead such as:

    List<WaterfallCloudGenerator> generatorsInDistance = new List<WaterfallCloudGenerator>();
    for(int i=0; i<generator.size(); i++){
        if(generators[i].world == MinecraftClient.getInstance().player.world &&
         Math.sqrt(generators[i].blockPos.getSquaredDistance(MinecraftClient.getInstance().player.getBlockPos())) 
     <= MinecraftClient.getInstance().options.viewDistance * 8f){
         generatorsInDistance.add(generators[i]);
     }
    }

There may be a good reason for it, but this looks sort of inefficient at first glance. All the generators in the view distance are being collected into a list, then that list is looped over as well to add the cloud effects to. Would it not be faster to simply loop over all the WaterfallGenerators in the main list 'generators' in one loop and check if it is within render distance all in one go rather than having multiple loops and lists to take up extra resources with. Something like this:

  for (WaterfallCloudGenerator waterfallCloudGenerator : generatorsInDistance) {
        if(generators[i].world == MinecraftClient.getInstance().player.world &&
         Math.sqrt(generators[i].blockPos.getSquaredDistance(MinecraftClient.getInstance().player.getBlockPos())) 
     <= MinecraftClient.getInstance().options.viewDistance * 8f){
        World world = waterfallCloudGenerator.world;
        BlockPos blockPos = waterfallCloudGenerator.blockPos;
        if (!(world.getBlockState(blockPos).getBlock() == Blocks.WATER && world.getBlockState(blockPos).getFluidState().isStill() && world.getBlockState(blockPos.add(0, 1, 0)).getBlock() == Blocks.WATER && !world.getBlockState(blockPos.add(0, 1, 0)).getFluidState().isStill() && world.getBlockState(blockPos.add(0, 1, 0)).getFluidState().getHeight() >= 0.77f)) {
            generatorsToRemove.add(waterfallCloudGenerator);
        }

        if (world.random.nextInt(1) == 0 && world.getBlockState(blockPos).getBlock() == Blocks.WATER && world.getBlockState(blockPos).getFluidState().isStill() && world.getBlockState(blockPos.add(0, 1, 0)).getBlock() == Blocks.WATER && !world.getBlockState(blockPos.add(0, 1, 0)).getFluidState().isStill() && world.getBlockState(blockPos.add(0, 1, 0)).getFluidState().getHeight() >= 0.77f) {
            double offsetX = world.random.nextGaussian() / 5f;
            double offsetZ = world.random.nextGaussian() / 5f;

            world.playSound(blockPos.getX(), blockPos.getY(), blockPos.getZ(), Effective.AMBIENCE_WATERFALL, SoundCategory.AMBIENT, 2.5f, 1.2f + world.random.nextFloat() / 10f, true);
            world.addParticle(Effective.WATERFALL_CLOUD, blockPos.getX() + .5 + offsetX, blockPos.getY() + 1 + world.random.nextFloat(), blockPos.getZ() + .5 + offsetZ, world.random.nextFloat() / 5f * Math.signum(offsetX), world.random.nextFloat() / 5f, world.random.nextFloat() / 5f * Math.signum(offsetZ));
        }
     }
    }

[Suggestion] Smoke particles when something "warm" is near water

Lava near water, furnaces, smokers, blast furnaces, campfires etc.

Black Splashes

I download the fabric 1.1v effective and the Textures are now black pls help
btw I remove sodium and some mods are forge

here are the mods
Edit I deleted mod that why you don't see it

[Feature Request] Only play sounds & particles for cascades that have an air block next to them

Currently, breaking blocks underwater results in a noisy cascade from the flowing water, when this should really be a quiet underwater current. It's a bit distracting, so a change like this (or something similar that also avoids this result) would be a very useful feature

(I noticed this when making a hole in the floor of a shipwreck, and again for making a hole in the floor of an ocean temple)

how do i change the volume of a cascade?

when i go to the config file there is no place to edit the volume of the cascades, I use fabric

1.16.5 - 1.17.1 support please

My client side modpack is 1.16.5 and its my personal favorite modpack
So I wanna add this mod to it but I cant
And another issue is most of the mod in Curseforge support 1.16.5

Sorry for bad language
Im new to github

Bug!

Terrible noise and a visual effect that can only be seen underwater.

Just waterfall and ripples

Mod seem to have no spash model of water nor lava showing up when it should like showcased in video of this mod, its just ripples and little water particles. Waterfall is extreamly loud and has no water particles going down but it has those particles which look like camp smoke. But it's still amazing keep up.. Would this work for shaders?

[Feature Request] Add option to turn off sounds

Hi,

When building underground you often run into underwater spring caves which can be an annoyance to repair to prevent underground waterfalls from deafening you. If an option could be added to opt-out of the waterfall sound effect as a work around for not being able to stop waterfalls generating underground

Black Splash Textures and no Cascades

Splashes appear black and there is no cascade visual and sound effects, only droplet particles

Here is my Mods List: