laksjdjf/attention-couple-comfyui

ComfyUI custom node for Attention Couple

• 👋 Hi, I’m @laksjdjf
• 👀 I’m interested in machine learning
• 🌱 I’m currently learning generative ai
• 📫 How to reach me: you can find me in 🗾

attention-couple-comfyui's Issues

Example workflow results in exception

When running the example workflow with the base SD 1.5 checkpoint there is an exception.

  File "/Users/jrabek/work/ComfyUI/comfy/ldm/modules/attention.py", line 463, in _forward
    n = attn2_replace_patch[block_attn2](n, context_attn2, value_attn2, extra_options)
  File "/Users/jrabek/work/ComfyUI/custom_nodes/attention-couple-ComfyUI/attention_couple.py", line 109, in patch
    q_uncond, q_cond = q.chunk(2) # uncond, condの分割

ValueError: not enough values to unpack (expected 2, got 1)

Note that I did have to change device="cuda" to the following for it to work on a Mac M1

from comfy.model_management import (    
    get_torch_device_name,
    get_torch_device
)
 
  ...

       device = get_torch_device_name(get_torch_device())

masking

hey @laksjdjf when working on the mask for the IPAdapter I had the same idea of doing a dedicated node 😄 Glad you had the same idea and actually did it!

did you see how I resize the mask on the IPAdapter? https://github.com/cubiq/ComfyUI_IPAdapter_plus/blob/main/IPAdapterPlus.py#L279

I'm not 100% sure it covers all the cases but I believe it's more flexible and allows any mask size. Maybe can be improved with a for/else statement.

Keep up the great work, you are a true hero 😄

PS: do you want me to write the English doc for this?