laminlabs/lamindb-docker

Sample docker stacks for LaminDB.

lamindb-docker's Issues

Replace explicit passwords with secrets

Currently, we have the passwords for login explicitly in the Dockerfile which is really bad. laminci would require a nox session which we don't have either.

How to solve

• Create 2 Github Actions secrets: user1password
• Update our login code to: RUN lamin login [email protected] --password $user1password
• Adapt the Dockerfile push workflow section to

- name: Build and push Docker image
  uses: docker/build-push-action@v4
  with:
    context: .
    file: ${{ matrix.dockerfile }}
    push: true
    tags: ${{ steps.meta.outputs.tags }}
    labels: ${{ steps.meta.outputs.labels }}
    build-args: LAMIN_PASSWORD=${{ secrets.user1password }}
  env:
    DOCKER_BUILDKIT: 1

Trigger release workflow when lamindb gets released

• Brainstorm about triggering the workflow when lamindb gets released. Ensure that the lamindb versions would be upgraded here
• Implement a POC

Reduce redundancy

Ideally, the containers with AWS + GCP would eventually build on top of a container that has all other things already set up. This could also speed up the docker-compose setup. Moreover, we'd have less repetition in our Dockerfiles for easier maintenance.

For now this is premature optimization since our builds are very quick.

Add a tiny test for the workflow

Just import lamindb and maybe create an instance or something

Add GCP container

Automate building and pushing container to a proper registry

• Figure out which container registry is free and still easily accessible/usable (look at Dockerhub + Github container registry first)
• Create Github workflow that builds and pushes the container

Add graphviz

ExecutableNotFound: failed to execute PosixPath('dot'), make sure the Graphviz executables are on your systems' PATH