Giter Site home page Giter Site logo

Comments (5)

andreluizmorita avatar andreluizmorita commented on September 26, 2024

#58

from laravel-5-generators-extended.

tabacitu avatar tabacitu commented on September 26, 2024

@EHLOVader are you still using this package, and want it to support SoftDeletes? I now have write access and would love SoftDeletes too.

I know Jeffrey passed on it, but it was probably due to him not wanting to maintain it, rather than feeling it's not a good idea. If we have a good PR for it, I think it's very much worth including in v2 #170. The package is finally getting the love it needs - no better time to work on this feature than now 😄

Let me know if you are able to help with this, I'd love to have SoftDeletes support in v2.

Cheers!

from laravel-5-generators-extended.

eightyfive avatar eightyfive commented on September 26, 2024

I think this feature should include all possible special column types.

These are the types that don't specify a column name:

$table->timestamps();
$table->rememberToken();
$table->softDeletes();
// ...

So they would be pretty easy to identify in SchemaParser:: parseSegments.

Validation should use something like method_exists(Blueprint::class, $field[0]), not checking for names.

I can have a go at it. Let me know.

PS: Is there already some kind of validation of all columns types in place?

from laravel-5-generators-extended.

tabacitu avatar tabacitu commented on September 26, 2024

Please take a stab at it, if you can, @eightyfive . Personally I see it as a flag, rather than the previous implementation. Something like:

php artisan make:migration:schema create_groups_table --schema="name:string:unique,description:string" --softDeletes

from laravel-5-generators-extended.

eightyfive avatar eightyfive commented on September 26, 2024

Hi,

I took a different approch in another package:
https://github.com/eightyfive/laravel-exodus/blob/master/src/Exodus.php#L118

I basically allow any "special" column types: id(), rememberToken(), timestamps(), softDeletes(), etc...

Let me know @tabacitu if this is something you would like to see implemented in the generators.

Cheers.

from laravel-5-generators-extended.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.