larapack/voyager-hooks

Hooks system integrated into Voyager.

voyager-hooks's Issues

I can modify an existing hook locally ??

Description:

Hi, I can modify an existing hook locally.

Thank you!!!

Steps To Reproduce:

[Feature Request] Show popular hooks

When clicking Add Hook it should show the most popular hooks, and it should be able to search for hooks.

Requires that larapack/hooks#3 is done first.

Voyager-hooks menu-item isn't visible and/or not working

Version information

Laravel 5.6.33
Voyager 1.1.9 (latest)
PHP 7.1.16
MySQL 5.7.21

Details

After installation the menu-item isn't visible in Admin menu. When I go in the Menu Builder, the menu-item is visible. When I click on it, in 'Route for the menu item' the URL is voyager.hooks. When I add index to it, the menu-item is visible in Admin menu, but on clicking nothing happens.
I've installed after that voyager-polls, but this makes no difference.

Trying to obtain code coverage on Laravel 5.5 fails if this package is used

• Hooks Version: 1.0.0
• Laravel Version: 5.5.28
• PHP Version: 7.0

Description:

Following the change in https://laravel.com/docs/5.5/packages#package-discovery the VoyagerHooksServiceProvider included runs at the App intialisation, which means that by default xdebug will get disabled, and trying to run any functionality dependant on it (in my case - phpunit to obtain code coverage) will fail just because larapack/voyager-hooks is installed.

I've created a SO question for this issue: https://stackoverflow.com/questions/48118973/different-php-ini-file-loaded-dependant-upon-the-code-content/ as well as reported this on Laravel bugtracker: laravel/framework#22782

Steps To Reproduce:

• install clean version of Laravel 5.5
• install larapack\voyager-hooks
• run phpunit tests/unit/atest for tests/unit/ATest.php with following content:

<?php

use Tests\TestCase;

class A extends TestCase
{
    public function testA()
    {
        echo( get_cfg_var('cfg_file_path')); exit;
    }
}

Output: C:\Users[user]\AppData\Local\Temp\F2A5.tmp
Expected output: C:\server\php\php.ini

Could not find package "test_hook" when add "test_hook"

• Hooks Version: 1.0.9
• voyager-hooks: 1.2.2
• Voyager Version: 1.x-dev c9dd5a8
• Laravel Version: 6.0.4
• PHP Version: 7.2.20

Description:

After enable the "browse_hooks" permission, I can see the "hooks" menu, however, I cannot create any hook.

Steps To Reproduce:

1. laravel new hooks
2. cd hooks
3. composer require tcg/voyager
4. php artisan voyager:install --with-dummy
5. add "browse_hooks" permission to database to make the menu visible
6. "Add hook"

Error message:

InvalidArgumentException
Could not find package test_hook. Did you mean one of these? yipl/hookah pxn/hooktest appventus/hooks dam1r89/test-hooks thecrypticace/hooks

Add `browse_hooks` permission to Voyager

Hooks menu item is not being displayed because permission is missing.

(edit)
I've found out that menu item is being added on Voyager repo. We should be adding Menu + Permission from the same repo.
Ping @marktopper.

Solution

Add permission browse_hooks on Voyager and assign it to any existing admin on the system.

[Feature Request] Hook creation documentation

I would love to collaborate by creating and publishing hooks. I wonder if the documentation on how to create hooks is already in place.

After uninstall hook tables still in database

• Hooks Version: #.#.#
• Laravel Version: #.#.#
• PHP Version:

Description:

After uninstall hook tables still in database. For example voyager-polls

Route [voyager.theme.index] not defined.

• Hooks Version: ^1.0
• Voyager Version: 1.1.10
• Laravel Version: 5.7.24
• PHP Version: >=7.1.3

Description:

Themes and redirect hooks give the same error:

Route [voyager.theme.index] not defined.

Steps To Reproduce:

Try and access admin after logging in and the system gives a 500 error message.

NOTE:

Hooks Version: ^1.0
Voyager Version: 1.1
Laravel Version: 5.7.24
PHP Version: >=7.1.3

I have another project on the same local system running earlier versions of voyager and the two hook packages that work with Laravel 5.7.24.

UPDATE:

I updated the working project from Voyager 1.1 to 1.1.10 and this issue appeared.

Hooks documentations

Hook installation documentation

Hello, can you please add some documentation about actions while the instaltion of a hook in runing?
And some more about the execution of custom scripts into the hook meanwhile the instalation and unintallation. (Similar of the composer script post-install)
Thank you so much!
Cheers!

Can't create hooks [require.model-log is invalid, it should have a vendor name]

• Hooks Version: 1.2.3
• Voyager Version: 1.4.2
• Laravel Version: 6.2
• PHP Version: 7.2

Description:

I can't create hooks. always the same error with many hooks
require.model-log is invalid, it should have a vendor name,

Steps To Reproduce:

1. composer require tcg/voyager
2. php artisan voyager:install
3. "Add hook"
   

Hooks are removed from voyager

• Hooks Version: latest
• Voyager Version: 1.5.*
• Laravel Version: 8.*
• PHP Version: 7.4

Description:

Hooks are removed from voyager 1.5.*. How can we use them now?

Steps To Reproduce:

Installing Local Hooks

I understand the workflow of uploading and installing a hook. However, there is a genuine case where you may be developing a hook that is specific to your application and will not be of any use if you open it to the public(post on larapack). Other than use, there could also be licensing, confidentiality issues etc.

In such a case, is there a way to install a hook locally? So far, I have been able to setup composer and install the hook package locally but have hit a dead-end regarding the local hook install in Voyager.

How to use it?

Hi,

after command
$ php artisan hook:install voyager-themes I got a message

[JsonSchema\Exception\ResourceNotFoundException] file_get_contents(file://): failed to open stream: No such file or directory

Could You explain me, how to use Hooks?

Laravel tinker does not show prompt, works incorrectly

• Hooks Version: v1.0.4
• Voyager Version: 1.0.10
• Laravel Version: 5.5.28
• PHP Version: 7.1.12-3+ubuntu16.04.1+deb.sury.org+1

Description:

After a clean install of laravel and larapack/voyager-hooks:v1.0.4, the command php artisan tinker does not show the prompt ">>>" and works incorrectly. Autocompletion doesn't work, arrow keys throws escape characters.

It seems like voyager-hooks is interfering with tinker or Psy Shell.

Steps To Reproduce:

1. Install last version of laravel with laravel new test
2. Run php artisan tinker. You will see the prompt ">>>"
3. Run composer require larapack/voyager-hooks:v1.0.4
4. Run php artisan tinker. You will see Psy Shell's welcome message and NOT the prompt ">>>"