larryhastings/pyweek26

Dynamite Valley

pyweek26's Issues

Remove HUD when level complete

I made a function for you called Level.hide_hud(). Please give it a body.

We need images of frozen bombs

Frozen versions of every type of bomb, and in both floating and not-floating aspects.

We need images for remote-detonate bombs

They're in and working! Oh purty please!

Game is playing while the Intro screen is displayed

The timer is running while the intro screen is displayed.

This means that the level can be in a different state depending on how long the player viewed the intro text.

T for triggering remote-control bombs isn't documented anywhere

Ripples not rendering on Mac

Another issue from the reviews:

The water waves (that indicate the flow) did not render on my machine (running osx 10.12, python 3.6.2, pygame 1.9.3)

Bombs don't start moving if skipped into the flow

If you skip one bomb off another bomb, and it lands in the flow, it doesn't start moving.

Make properly triumphant Game Won screen

I tried to make a GameWonScreen in dynamite.titles but I didn't know what I was doing. I made it overlay text. Please do a proper job!

Being blasted on a log doesn't killing you

Being blasted on a log should kill you, but doesnt.

I just fixed this (hastily) for Dams, but this should be fixed using a refactor and a common base class.

Moving off a floating bomb onto a dam leaves you in mid-air

I think I'm actually standing on the dam here, but I got moved into this mid-air spot:

KeyError: remote-bomb

User asrp reported a crash as part of the ratings feedback:

Traceback (most recent call last):
File "game.py", line 2590, in <module>
main(sys.argv[1:])
File "game.py", line 2584, in main
pyglet.app.run()
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/app/__init__.py", line 138, in run
event_loop.run()
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/app/base.py", line 142, in run
self._run()
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/app/base.py", line 155, in _run
platform_event_loop.step(timeout)
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/app/xlib.py", line 125, in step
device.select()
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/canvas/xlib.py", line 168, in select
dispatch(e)
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/window/xlib/__init__.py", line 917, in dispatch_platform_event
event_handler(e)
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/window/xlib/__init__.py", line 1108, in _event_key
return self._event_key_view(ev)
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/window/xlib/__init__.py", line 1089, in _event_key_view
self.dispatch_event('on_key_press', symbol, modifiers)
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/window/__init__.py", line 1232, in dispatch_event
if EventDispatcher.dispatch_event(self, *args) != False:
File "/tmpfs/venv3.6/lib/python3.6/site-packages/pyglet/event.py", line 357, in dispatch_event
if handler(*args):
File "game.py", line 2529, in on_key_press
return game.on_key_press(k, modifiers)
File "game.py", line 444, in on_key_press
r2 = send_message(self.key_handler, "on_key", k)
File "game.py", line 377, in send_message
return fn(*a)
File "game.py", line 1416, in on_key
bomb.detonate()
File "game.py", line 1949, in detonate
self.occupant.on_blasted(self, position)
File "game.py", line 1217, in on_blasted
self.drown()
File "game.py", line 1225, in drown
self.on_died()
File "game.py", line 1202, in on_died
gravity=-400,
File "/tmpfs/dynamite-valley-1.0.2/src/dynamite/scene.py", line 83, in spawn_particles
gravity
File "/tmpfs/dynamite-valley-1.0.2/src/dynamite/scene.py", line 492, in __init__
super().__init__(scene, position, sprite_name)
File "/tmpfs/dynamite-valley-1.0.2/src/dynamite/scene.py", line 204, in __init__
self.sprites[sprite_name],
KeyError: 'remote-bomb'

Log in current moves partway onto dam

Launch final game with -O

There are lots of asserts, including in OpenGL code, and maybe players will have a better experience if we turn them off.

If player wins and dies on the same frame, both happen

If there's only one dam left in a level, and you blow up that dam and die in the same logical frame, e.g.:

• you're standing on an bomb that blows up the dam
• you're standing next to the bomb that blows up the dam
• you're standing on the dam when it blows up

Then you both die and win the level simultaneously. The game displays both "You Won!" and "Oops!", one on top of the other. In my experience the game always behaves as if you won, and pressing Space goes on to the next level / title screen.

If you have three logs in a row in moving water, only the first one moves

if on a map you have
>>>XXX>>>

Legend:
> MapWaterMovingRight
X MapWaterMovingRight + Log

only the first log moves. the others never move. if it's a loop, the moving one eventually bumps into the last one and now they're all stuck.

Log in moving water stuck against dam may not start moving when the dam is blasted

The log below the red floating bomb is on water moving down. Once you destroy the dam, the log should move. But once that red floating bomb goes off, the log will never move again.

If I had dropped the bomb to the left of the floating log, instead of above it, the log would have been fine. It would have started moving once the dam was destroyed.

You can continue a game that you've already won

If you win a game, then at the main menu press Space to continue playing, you replay the final level in that sequence ("tutorialX" or "levelX"). When you win a game, it should blow away the savegame file.

If you complete the level after you get blasted / frozen / drown, you still proceed to the next level

Ensure labels are in front of other graphics

I added Labels for Level Compete etc. They're drawn behind some level stuff / entities. I thought it was going to be "group" but that didn't fix it.

Player can place bombs onto bombs

When skipping bombs, if there's no place for the bomb to go, the bomb stops atop the other bomb:

Perhaps this makes sense, but the floating bomb might explode, leaving a bomb in mid-air:

Or it might flow out of the way, with the same result:

I would expect not to be able to throw a bomb in this case, or for the bomb to explode, or for it to actually sit atop the bomb, move with it, etc.

Late stepping onto a bomb causes Claim to stay with bomb

If you lay a bomb that is moving away, and step onto it very late, you step out into the water but do not move with the bomb.

When the bomb explodes, you die:

Floating objects can be swept onto the land

Objects in current can be swept onto the land:

Bisecting shows the bad commit is b96d92a.

Feature request: use speech bubbles for level complete / player died

Instead of a big label over the screen, it'd be more in theme to have a speech bubble appear, in the same way that we have dialog at the beginning, for level complete or player death.

Maybe something like:

Level complete:
<( GOOD JOB! )

Player death:
<( WHAT JUST HAPPENED, JIM? )

Bombs that are pushed into the water don't start to float

Launcher issue with relative paths

The run_game.py launcher seems to have a bug where the 'src' path is considered absolute instead of relative to the launcher script itself.

On Windows:

py -3 run_game.py
Traceback (most recent call last):
File "run_game.py", line 26, in
os.chdir(srcdir)
FileNotFoundError: [WinError 2] The system cannot find the file specified: 'C:\src'

On something Posixey:

Traceback (most recent call last):
File "run_game.py", line 26, in
os.chdir(srcdir)
FileNotFoundError: [Errno 2] No such file or directory: '/src'