larrywang0701/pe

pe's Issues

Internal error is shown

Run mark -1 and get internal error message
[index] should be greater than or equal to 1

`set` command give wrong error message

When I run the command set semesterDays_extra_string 1, the application give me the error message Could not parse an integer. For input string: "_extra_string 1". But it should be a command format error since semesterDays_extra_string is not a valid setting parameter. It seems that the application recognizes _extra_string 1 as an integer as a whole instead of recognize semesterDays_extra_string as the provided setting parameter name.

Allowing multiple instances of the application from the same JAR running together lead to overwritten of the same data file

Currently the application allows multiple instances from the same JAR running at the same time on the same device. This will lead to data being overwritten between each instances. Should disallow user from opening multiple instances of the application, or make a auto-sync feature to make sure that when the data file is modified outside one instance of the application, the application will automatically reload the data file.

For example, first I open two instances of the application, with empty data. First I add one task task 1 in the first instance, then I add another task task 2 in another instance. Then close both instances and restart the application. After the application is restartedm only task 2 presents while task 1 is lost. A directly view on the JSON data file also suggest the lost of task 1

This would lead to a lost of users' data.

`add`, `edit` and `filter` commands accepts invalid date

• Run add n/submit quiz p/2 d/31-02-2023 recur/weekly t/quiz t/graded l/www.quiz.com des/for mod cs0000 with invalid due date 31-02-2023 results in New task added: submit quiz; Priority: 2; Status: undone; Tags: [quiz][Weekly][graded]; DueDate: 28-02-2023; Link: www.quiz.com. The task is successfully added, and the due date is automatically changed to 28-02-2023.
• Then run edit 1 n/Updated task p/3 d/30-02-2023 t/newTag l/www.newlink.com also with the invalid date 31-02-2023 will result in a successful editing Edited Task: Updated task; Priority: 3; Status: undone; Tags: [newTag][Weekly]; DueDate: 28-02-2023; Link: www.newlink.com. Like what happened to add command, the edited due date is also automatically set to 28-02-2023.
• Run filter d/31-02-2023 results in Here are your tasks that are: Due before: 28-02-2023 (omitted new line here)
  Which also automatically set the filter date to 28-02-2023.
• But, actually because the user input an invalid date, there should be an error message instead of directly "correcting" the date for the user.

In UG: wrong JAR file name

In the user guide, it require the user to download and run the java -jar command with the JAR file profplan.jar, but actually the latest version's file name should be profplanv14.jar, not profplan.jar that can be found in the older releases.

Missing diagrams in DG

Missing diagrams that are supposed to be there described in DG

For example:

Can't find the the class and state UML diagrams mentioned in the text in the range of +/- 3 pdf pages

Can't find the sequence diagram that you are talking about here in the range of +/- 3 pdf pages

`clear`, `list_week` and `list_month` commands accpets extra command contents without command format error

• The clear, list_week and list_month commands can run with any extra things after clear and a space, with the success message All Tasks Deleted Successfully Prof!. But it should give the user a command format error message.
• Try run command: clear 1234567 abcdefg !@#$%^&*(), list_week 1234567 abcdefg !@#$%^&*() and list_month 1234567 abcdefg !@#$%^&*()
• I think this is a bug because when I run list 1234567 abcdefg !@#$%^&*(), the application correctly gives me the error message Did you mean the 'list' command? Please enter 'list' only.

`Completion Rate: NaN%` when using `stats` command on an empty ProfPlan

How to reproduce:

• First run clear or delete all to get an empty ProfPlan
• Then run stats
  Will get:

Here are your statistics Prof!
Completion Rate: NaN%

Which the completion rate is not meaningful under this context. Maybe in the application internal somewhere is divided by zero (total task number)?