larshp / updownci Goto Github PK

View Code? Open in Web Editor NEW

25.0 9.0 11.0 111 KB

Upload and download SAP Code Inspector variants in XML format - ABAP

License: MIT License

ABAP 100.00%

sap-code-inspector abap-test-cockpit abap-code-inspector

updownci's Introduction

upDOWNci

Upload and download SAP Code Inspector variants in XML format

Version requirement: 702
MIT License

Installation

Install via abapGit.

Use

Download and upload single variants

You can utilize program ZUPDOWNCI to download and upload single check variants.

Leave username blank for global variants.

Upload will create or add checks to the specified variant.

Mass-download of variants

You can utilize program ZUPDOWNCI_MASS_DOWNLOAD to download multiple variants as a single ZIP file. User-specific variants are stored in a folder named after the user.

If an error occurs for a specific check variant, then it is excluded from the ZIP file and an error is displayed.

updownci's People

Contributors

Stargazers

Watchers

Forkers

srinu3366 gaudinulkor gauravangrass lorbe opesus gabmarian larsip developer-lk buettnerjulian lhdias vnermakov

updownci's Issues

doesnt work when attributes_ok = false

when uploading to invalid variant it doesnt seem to work

dump when importing CL_SAUNIT_LEGACY_CI_CHECK

test what happens on overwriting of variant

perhaps have a warning popup, to overwrite or not

Short Dump Downloading Variant

Hi,
I get short dump when downloading a test variant in test mode. (Note quite sure if it is because of the fact that I changed some of the check's priority from Warning to Error).
This is the first time that I'm trying to download a check variant.

SAP_BASIS 750 0006 SAPK-75006INSAPBASIS SAP Basis Component

Dump with CL_CI_TEST_METRIC_PROC

Exporting configuration from CL_CI_TEST_METRIC_PROC causes a dump.

The problem is because it is trying to determine an incorrect type for an attribute in create_structure for the types with_hdi, with_hvo and with_hef:

In the method find_types is getting the type of DO_HALSTEAD instead of specific field:

remove slash from default filename

Hey Lars,

maybe you can add this line to your code, to fix the issue if some uses variants with slashes.

Best regards,
Julian

CL_CI_TEST_ABAP_NAMING_NEW dump, type T_S_OPTION

Dump with CL_CI_TEST_PRETTY_PRINT

Short text from dump: Length error in the IMPORT statement.

Code:
METHOD download_attributes.

DATA: lt_import TYPE ty_parameter_tt,
      lr_data   TYPE REF TO data.

FIELD-SYMBOLS: <lg_data> TYPE data.


IF iv_attributes IS INITIAL.
  go_xml->write_variant( iv_testname = iv_class
                         iv_version  = iv_version ).
ELSE.
  build_memory(
    EXPORTING
      iv_class  = iv_class
    IMPORTING
      er_data   = lr_data
      et_memory = lt_import ).
  ASSIGN lr_data->* TO <lg_data>.

  IMPORT (lt_import) FROM DATA BUFFER iv_attributes.
  IF sy-subrc <> 0.
    RAISE EXCEPTION TYPE zcx_updownci_exception EXPORTING iv_text = 'IMPORT error'.
  ENDIF.

  go_xml->write_variant( iv_testname = iv_class
                         iv_version  = iv_version
                         ig_data     = <lg_data> ).
ENDIF.

ENDMETHOD.
IMPORT_WRONG_END_POS_20231027_130025.zip

fix for CL_WDY_CI_TEST_CONVENTIONS

the settings type is defined directly in the class, and kind set directly in QUERY_ATTRIBUTES.

perhaps hardcode a fix for this class, it seems to be the only check with this approach?

Is not supporting checks from "code pal for ABAP"

Have exported a ATC variant containing "code pal for ABAP (open source plugin)" - "CALL METHOD Usage". Program ZUPDOWNCI is dumping because the tool is not supporting that the test class is not implementing method PUT_ATTRIBUTES directly in the class. Class Y_CHECK_CALL_METHOD_USAGE method PUT_ATTRIBUTES is inherit from superclass Y_CHECK_BASE.