larttyler/mhwdb-contrib

Source code for the contribution system used by the Monster Hunter: World API project (https://contrib.mhw-db.com)

Contributing

Feel free to open an issue with any requests or issues. If you'd like to submit pull requests, they'd be more than welcome! For a list of pending and in-progress items, please check out the Trello board.

If you'd like to discuss anything related to the project, or if you just wanna say hi, feel free to join the project's Gitter chat.

Getting Started

To start up a local dev environment, run the commands below.

$ git clone https://github.com/LartTyler/MHWDB-Contrib.git
$ cd MHWDB-Contrib/
$ yarn install
$ yarn start

mhwdb-contrib's Issues

Cannot filter items with modal opened

Description
Letters cannot be typed to filter/search items while a modal is opened.

To Reproduce
Steps to reproduce the behavior:

1. Go to "Objects > Armor"
2. Click on "Add New" button
3. Click on "Add Skill", "Add Item", or "Add Slot" button
4. Click on "Make a selection..." button
5. Try to type

Expected behavior
Letters should show up and the items should be filtered correspondingly when the user types.

Screenshots

Environment

• OS: macOS Mojave 10.14.6
• Browser: Safari 12.1.2 & Vivaldi 2.7.1628.33

Additional context
This issue also happens when trying to select and add a skill to a decoration. However, things work fine when a modal is not opened (e.g., when picking an armor's type, rank, or armor set).

Decorations with Level 4 Slot

Description
When i want to create a Level 4 Decorations then i can not save it. I can selected the Level 4 but when i want to save it always this message occurred under the level selection: "This value should be 3 or less."

Preferred solution
I can save the decorations.

Cannot add new armor

Description
A new armor couldn't be added after submitting the form.
Got "Internal Server Error" message instead.

To Reproduce
Steps to reproduce the behavior:

1. Go to "Objects > Armor"
2. Click on "+ Add New" button
3. Fill out the form
4. Click on "Save" button

Expected behavior
A new armor should be added to the armor list.

Screenshots

Environment

• OS: macOS Mojave 10.14.6
• Browser: Safari 12.1.2 & Vivaldi 2.7.1628.33

Level 4 decoration slots needed

Description
When adding/editing the slots of an armor, there are only 3 options available. Since Iceborne introduces level 4 decoration slots (see the screenshot in Notes), it would be great if the same option could be provided.

Preferred solution
The level 4 decoration slot option should be provided when adding or editing an armor.

Screenshots

Notes

Safari shows "Invalid Date" in Events page

Description
The date format in Events page cannot be parsed correctly by Safari. Expected to show date strings but got "Invalid Date" instead.

Screenshots

Environment

• OS: macOS Mojave 10.14.6
• Browser: Safari 13.0 (14608.1.49)

Notes
It's probably Safari's own weird behavior (couldn't recognize the date format 2019-07-05T00:00:00+0000 from the API). Chrome, Firefox, and Vivaldi work totally fine otherwise.

Blank screen when skill rank added

Description
The entire screen goes blank when a new rank is added to a skill.

To Reproduce
Steps to reproduce the behavior:

1. Go to "Objects > Skills"
2. Click on "+ Add New" button or "Edit" button
3. Click on "+ Add Rank" button
4. Fill in the description
5. Click on "Save" button

Expected behavior
A new rank should be added to the skill.

Screenshots

Environment

• OS: macOS Mojave 10.14.6
• Browser: Safari 12.1.2 & Vivaldi 2.7.1628.33

Add charm ranks

Description
I can not save new Ranks from Charms or create Charms. Everytime i want to create a new Charm rank i get the following error: "Request failed with status code 500"

Preferred solution
The exception which is thrown on server site should be fixed.

Item's rarity cannot be set over 8

Description
When adding/editing an item, the rarity cannot be set over 8. Any value greater than 8 would be automatically replaced with 8. I guess there is some kind of max-limit? Since literally like everything in Iceborne has a rarity greater than 8, it would be nice if that max-limit setting could be removed (if any).

To Reproduce
Steps to reproduce the behavior:

1. Go to "Objects > Items"
2. Click on "Add New" or "Edit" button
3. Type something greater than 8 (e.g., two-digit numbers or 9) in the "Rarity" field

Expected behavior
Any value greater than 8 should be entered without being replaced with the number 8.

Screenshots

Environment

• OS: macOS Mojave 10.14.6
• Browser: Safari 13.0.1 & Vivaldi 2.8.1664.43

Lack of options for complex resistances/weaknesses cases

There are some monsters that have conditions that changes its resistances/weaknesses. Usually these conditions make a resistance a weakness and viceversa, but there are monsters that these conditions just change the value of one resistance/weakness for another value that is not exactly the opposite. See Water Element from the information in-game of a Lavasioth as an example:

There are no options to reflect these cases in the Contrib tool, as each element can only appear once on each column when setting both Resistances or Weaknesses.

Editing from Charms

Description
I can not save new Ranks from Charms or create Charms. Everytime i want to create a new Charm rank i get the following error: "Could not update: You must provide a value for the following field(s): [ranks[3].name]"

Preferred solution
I can add new charm ranks to old charms and can create new charm ranks.

Screenshots:

Blank screen when adding skills to armor

Description
While adding or editing an armor, the entire screen will go blank if "Add Skill" button is clicked before the data are fetched.

To Reproduce
Steps to reproduce the behavior:

1. Go to "Objects > Armor"
2. Click on "Add New" button
3. Click on "Add Skill" while the spinner icon is spinning

Screenshots

Environment

• OS: macOS Mojave 10.14.6
• Browser: Safari 13.0.2 & Vivaldi 2.8.1664.44

Notes
I think this one may be related to issue #26.

Master Rank needed

Description
When adding/editing an armor, there are only 2 rank options available: "High" and "Low". Since Monster Hunter World: Iceborne introduces the "Master" rank, it would be great if the same option could be provided.

Preferred solution
The "Master" rank should be provided when adding or editing an armor.

Screenshots

Blank screen when adding rank to armor set bonus

Description
The entire screen goes blank when a new rank is added to an armor set bonus.

To Reproduce
Steps to reproduce the behavior:

1. Go to "Objects > Armor Set Bonuses"
2. Click on "Add New" button
3. Click on "Add Rank" button

Expected behavior
A new rank should be added to the armor set bonus.

Screenshots

Environment

• OS: macOS Mojave 10.14.6
• Browser: Safari 12.1.2 & Vivaldi 2.7.1628.33