On Windows Vista, slimerjs.bat syntax error

[laurentj]

On Windows Vista, slimerjs.bat syntax error

[Bartvds]

I'm not sure what is going on with the 5 clauses but I quick fixed my file by adding some quotes:

Changed three occurences of this:

if not exist %SLIMERJSLAUNCHER% (

Into this:

if not exist "%SLIMERJSLAUNCHER%" (

And now I see the window. After I close it I also the console.log() output from my javascript.

[laurentj]

Thanks for your report. We should check if this fix is compatible in other windows version. (I'm not an expert in dos shell :) ))

[Bartvds]

Well, me neither, but I picked the idea for this fix from a few lines further along so I'm confident it's valid :)

https://github.com/laurentj/slimerjs/blob/master/src/slimerjs.bat#L96

Do you know on what Windows version this .bat was originally tested?

FYI; if you need a Windows VM there is this official repo: http://www.modern.ie/en-us/virtualization-tools

[laurentj]

I tested with Windows 7 64bits, it works without modification and it seems to work with quotes.

Could you provide a patch containing all modifications?

[Bartvds]

Note I'm implementing a node.js wrapper and I am reaching the point where I'm adding options-passing support to it.

Once I have tests setup for those I can verify a bit more on the other .bat options and if they match with the linux and mac script, but this may take a bit longer.

[laurentj]

Fixed by the pull request #63