lawrence-laz/extensions.configuration.object

A simple way to do configuration using POCO objects.

Hi there 👋

extensions.configuration.object's Issues

Enums are loaded as value, but should be loaded as name

When IOptions are loaded from Configuration they can read enum settings, but they need to be entered by name, rather than by value. Current implementation loads it as value, which results in all enum values defaulting to first one.

StackOverflowException in LoadRecursively when serialising a Record

C# Records have a compiler generated Type EqualityContract property, once they get compiled into classes. When loading such a class, LoadRecursively fails with a StackOverflowException.

The property should not be loaded, I would say, but currently only fields are ignored when they have the CompilerGenerated attribute. I propose to check properties in the same way, and I will make a PR with this implemented.

For reference, here is a new unit test case that fails in the current implementation:

    public class RecordObjectTest
    {
        internal record MyConfiguration
        {
            public SubRecordConfiguration SubRecord;
            public string MyKey;
        }

        internal record SubRecordConfiguration
        {
            public string Title;
            public string Name;
            public int Age;
        }

        [Fact]
        public void AddObject_WithClassObject_ShouldLoadFieldsIntoConfiguration()
        {
            var configuration = new ConfigurationBuilder()
                .AddObject(new MyConfiguration
                {
                    SubRecord = new SubRecordConfiguration
                    {
                        Title = "Editor",
                        Name = "Joe Smith",
                        Age = 33
                    },
                    MyKey = "My appsettings.json Value",
                })
                .Build();

            configuration["SubRecord:Title"].Should().Be("Editor");
            configuration["SubRecord:Name"].Should().Be("Joe Smith");
            configuration["SubRecord:Age"].Should().Be("33");
            configuration["MyKey"].Should().Be("My appsettings.json Value");
        }
    }

Missing authors tag in package

Add tag in Extensions.Configuration.Object.csproj.

<Authors>Laurynas Lazauskas</Authors>