Giter Site home page Giter Site logo

createnumismatics's Introduction

Create Numismatics

discord-plural

License

Create Numismatics is licensed under the LGPL license. See LICENSE for more information.

Certain sections of the code are from the Create mod, which is licensed under the MIT license. See Create's license for more information.

Most of the code for annotation based conditional mixins is based on Neruina's Conditional Mixins, which is licensed under the MIT license. See Neruina's license for more information.

createnumismatics's People

Contributors

ithundxr avatar techno-sam avatar violet-scarelli avatar spottytheturtle avatar renovate[bot] avatar vladiscrafter avatar banna12345bob avatar crowdin-bot avatar daudeuf avatar dmytr0gamer avatar luffypirat avatar thelegendofsaram avatar github-actions[bot] avatar

Stargazers

Wooferz avatar ArchangelTheGod avatar G'lek Tarssza avatar aw avatar ninjæon avatar  avatar Tulpen avatar Adam K avatar Edgar Onghena avatar Jordan C avatar  avatar NoaW avatar Samuel Hulme avatar Junior avatar  avatar  avatar Drew avatar Jay Turner avatar  avatar Ginger avatar

Watchers

Lucian avatar  avatar

createnumismatics's Issues

Numismatics Becoming Invisible

Describe the Bug

I'm using create numismatics and its dependencies on a fabric server and when the numismatics in the machine exceeds 128, it will vanish (become invisible) and when you try to take one, it will reappear again. though if you have lots of stacks that exceeds 128, you need to take more until it became less than 128. It works normally on singleplayer, this is probably a server side bug. fyi I don't have any mods installed on the fabric server other than numismatics and its dependencies.

Reproduction Steps

  1. Get 128+ items of any coins
  2. put it on machines like depositor or vendor.
  3. Try to put 127 coin and increase it until it disappear

Expected Result

It will disappear visually, you can take some stacks until it became less than 128 to appear again but you won't know until you try to click on it.

Screenshot 2024-05-26 170613

This has 128 cogs on it thus disappears
Screenshot 2024-05-26 170643

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

1.0.4

Create Mod Version

0.5.1f

Minecraft Version

1.20.1

ModLoader and Version

Fabric 0.15.11 (latest)

Other Mods

Create and it's dependencies only also fabric mod

Additional Context

No response

Make coins data-driven

Describe the Suggestion

Instead of using a Class called CoinItem, use json files to define what items can be coins and how much they are worth. The benefit would be that the value-relationship of the current coins can be changed and it would allow currency from other mods to fit into the system.

Screenshots and Videos

No response

Additional Context

No response

Make an "incomplete" version of coins

Describe the Suggestion

Add incomplete versions of coins that could be used in datapacks as a transitional item in a for example sequenced assembly

Screenshots and Videos

No response

Additional Context

currently there's no good way to do this if you don't make a mod

Universal Tag

Describe the Suggestion

As directed via Discord, any chance a universal tag could be applied to all items/blocks from this mod? Would make whitelisting them for safe use with claim mods, such as Open Parties & Claims, much easier. Plus, no doubt it'd have other benefits for future integrations, too...

Screenshots and Videos

No response

Additional Context

No response

Make vendors a display source

Describe the Suggestion

Vendors should be a display source that shows the price of the item they're selling/buying.

Screenshots and Videos

No response

Additional Context

No response

[suggestion] Gambling

Describe the Suggestion

Where there's money, there's gambling.

Honestly I think the implementation for this could vary. It could be a redstone component that outputs a random value from 1 to 15 when given a redstone input, or even full slot machine blocks.

Basically I want some redstone/numismatic blocks to add gambling to my server.

Screenshots and Videos

No response

Additional Context

No response

Question: Can someone explain to me what the register is?

Describe the Suggestion

For some reason, I saw textures for the register in the files, but I cannot obtain it through the creative menu or see it on the mod description. Is this a feature soon to be added?

Screenshots and Videos

No response

Additional Context

No response

Vendor wrongly displaying insufficient funds when connected to a banker account via card

Describe the Bug

A normal [non-creative] shop set to BUY items from players, and linked to a Banker account with a card that has money in it, still wrongly displays "No funds available, contact [my name]" - even tho the funds are on the account, and selling items to it DOES work.

Reproduction Steps

  1. Make a Banker account and link Card to it
  2. Put funds in the account
  3. Make a normal Vendor
  4. Set it to BUY an item, and put in the Card connected to the account which has money in it

Expected Result

The shop will function and buy items, the money disappears from the linked Banker account as expected, but the Vendor block keeps displaying "No funds, contact [playername]"

Screenshots and Videos

image
image
image

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

1.0.6

Create Mod Version

0.5.1f

Minecraft Version

1.20.1

ModLoader and Version

Forge 47.3.3

Other Mods

No response

Additional Context

We're running a modpack of over 280 mods. Project page for reference:
https://www.curseforge.com/minecraft/modpacks/arcanum-dei-reforged

Creative Vendors can't be placed or accessed in survival mode

Describe the Suggestion

Please make it so Creative Vendors can't be placed or accessed in survival mode after having obtained them in creative mode. So after you've changed from creative to survival and have allready created a Creative Vendor, you won't be able to change it in survival.

Screenshots and Videos

No response

Additional Context

I'm an admin and player on a small private server where we use this mod. I've made a Creative Vendor so diamonds can be exchanged for currency, but when I'm playing on the server I'm able to change the content even though It's a Creative Vendor and I'm in survival mode.

Virtual item in tarde item slot

Describe the Suggestion

Allow Virtual item in trade-item slot so users don't need to store at least one to buy the item. Also add JEI support so they can drag items to that slot.

Screenshots and Videos

image

Additional Context

No response

Please 1.19.2 Forge <3

Describe the Suggestion

Please 1.19.2 Forge <3

Screenshots and Videos

No response

Additional Context

No response

[suggestion] Coin Auto-Conversion at vendors

Describe the Suggestion

Basically a server config that allows for coin auto-conversion at vendors. Basically allowing you to buy an item that costs 16 spurs with a sprocket.

It could either be a server config, or a vendor config that needs to be put by the vendor owner.

Screenshots and Videos

No response

Additional Context

No response

Make a value of the coin a separate string

Describe the Suggestion

Just inserting the name and adding s to the end doesn't work for most languages : |

(example attached: "шестерёнкаs" should be translated as "шестерёнок" in this case, but the s seems to be hardcoded to be here)

Screenshots and Videos

image

Additional Context

No response

Unexpexed error when using command on nonexistent banker

Describe the Bug

When running /numismatics deduct banker <random position> 1 you get "An unexpected error occurred trying to execute that command"

Reproduction Steps

  1. Run /numismatics deduct banker 0 0 0 1 on newly, normally generated world
  2. See an error

...

Expected Result

"There's no banker on this position"

Screenshots and Videos

No response

Crash Report or Log

n/a

Operating System

Nobara 39

Mod Version

1.0.4

Create Mod Version

0.5.1f

Minecraft Version

1.20.1

ModLoader and Version

Fabric 0.15.7 api 0.92

Other Mods

No response

Additional Context

No response

[Feature Request] 's' on other languages

Describe the Suggestion

I'm translating this mod in Korean, however in korean, there is no 's' for plural meaning. is it possible to make 's' in language key, not in code?

Screenshots and Videos

image

Additional Context

No response

Vendor Wont Open With A Totem In Offhand

Describe the Bug

When attempting to open a vendow with a totem in my offhand, it does not open. After removing items from my offhand and main hand and shift clicking it, it opens fine.

Reproduction Steps

1.Place down a vendor
2.Put an item in your offhand (or main hand for some rclick items)
3.Shift click the vendor
It does not open

Expected Result

It to open even with a totem or shield in offhand. Also should work even if there is an item in main hand but offhand is more annoying.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

1.0.4

Create Mod Version

0.5.1f

Minecraft Version

1.20.1

ModLoader and Version

Forge most recent

Other Mods

AntiXray (Forge)

AppleSkin

Architectury API (Fabric/Forge/NeoForge)

Botarium

Chunk Loaders

Create

Create : Misc & Things

Create Confectionery

Create Enchantment Industry

Create Ore Excavation

Create Stuff & Additions

Create: Balanced Flight (Angel Ring)

Create: Connected

Create: New Age

Create: Numismatics

Create: Steam 'n' Rails

Curios API (Forge/NeoForge)

Deeper and Darker

Easy Anvils [Forge & Fabric]

End Respawn Anchor

Enhanced Mob Spawners

Flux Networks

GeckoLib

GraveStone Mod

Iceberg [Forge]

Jade

Jade Addons (Forge)

JourneyMap

Just Enough Items (JEI)

Just Enough Resources (JER)

Kotlin for Forge

libIPN

Lithostitched

Not Enough Animations

Pufferfish's Skills [Forge & Fabric]

Puzzles Lib [Forge & Fabric]

Scarecrows' Territory

Security Craft

Sophisticated Backpacks

Sophisticated Core

SuperMartijn642's Config Lib

SuperMartijn642's Core Lib

Tool Belt

Valkyrien Skies (Forge/Fabric)

Vein Mining (Fabric/Forge/Quilt)

YUNG's API (Forge)

YUNG's Better Desert Temples (Forge)

YUNG's Better End Island (Forge)

YUNG's Better Jungle Temples (Forge)

YUNG's Better Mineshafts (Forge)

YUNG's Better Nether Fortresses (Forge)

YUNG's Better Ocean Monuments (Forge)

YUNG's Better Strongholds (Forge)

YUNG's Better Witch Huts (Forge)

YUNG's Bridges (Forge)

Client Crafting

Entity Culling Fabric/Forge

Durability Tooltip

Inventory Profiles Next

WorldEdit (For Creative testing worlds)

Additional Context

I was using a custom totem texture pack but I dont think that matters.

Any side of a Vendor should be able to extract/input stock

Describe the Suggestion

Current intended design is that the bottom side of a Vendor is used to extract stock when buying, and every other side is used to input stock when selling.

This is a problem because:
a) No other Create block works like this. Basins, Vaults, Depots, Belts, etc, all of them allow you to input and output from any side of the block.
b) It makes it impossible to insert stock into a selling Vendor without having a funnel or chute exposed to the person buying. This means that there is no way to prevent people from stealing your stock by right-clicking whatever is inputting. Being able to insert stock from the bottom using funnels or a fanned Chute would solve this.
c) It's not mentioned in any in-game documentation
d) It changes the way the Vendor works depending if its selling or buying, which I guess would make sense if the Vendor automatically took stuff from nearby inventories, but it doesn't. Funnels, chutes and belts already have a direction when you put them on a block. Why overwrite that direction arbitrarily?

In my mind there are two options to fix this:

  • Let any side input or output
    OR
  • Let Vendors automatically take stock from Vaults/inventories underneath them.

The former makes more sense game-design wise but the latter could probably be more useful and easy to use, as setting up chutes with fans under any vendor you had could get a bit annoying. The latter would be especially useful when combining it with Item Silos from Create: Connected as they place vertically.
Personally I'd just prefer letting any side input/output but it could be a more interesting way to do it.

Screenshots and Videos

image
My design for a stock input, that currently does not work :(

Additional Context

No response

Confusing UI and Why it Should be Changed (Among Other Things)

Describe the Suggestion

The current UI is quite confusing, as it is not clear where or when you are able to place or remove items.

Of course, this might be blamed on a player being new to the mod, but it is bad design that players are consequently expected to ask how the system works. Players should be able to easily learn it themselves in a minimal amount of time, as in some cases, this may cause players to start avoiding it entirely because they do not want to place in the effort.


Things I'd like to see changed:

Blaze Banker:

  • Bank Card Slot should at least outline WHY the card isn't fitting if not blank.

(Both) Depositors:

  • Should not be limited to singular coins, but a customizable amount. (Why isn't this like the Vendor block???)
  • If a coin of a higher or lower value is inputted, the resulting message should be something along the lines of ' Depositor only accepts {amount}!'
  • Configuration GUI should clearly outline whether a field is the price or held stock.

Bank Terminal:

  • GUI should clearly outline whether a field is the input or the output.
  • GUI should be left-oriented or at least can be changed.
  • Bank Card Slot should actually HOLD the card. Current system is unintuitive and causes confusion.

Cards and ID Cards:

  • Tooltips should clearly state that they may only be used when bound either to a player or blaze banker.
  • Tooltips should clearly state HOW they can be bound to a blaze banker.
  • Tooltips should clearly state that they can be dyed.

New ID System:

  • Instead of the limited inventory GUI, the trust list should use NBT to store player IDs or UUIDs onto the tile entity.
  • For example, a bound ID can be placed in a slot, and then one of two buttons: 'Remove' or 'Add' can be pressed to update the list.
  • Using this new system, the player should be able to input an item such as a 'Trust List' that holds many player IDs with which they can update the system.

Vendor Block:

  • Coin selection should not surround the Stock Slots, keep them organsied to the left of Stock.
  • Held coins should actually be labeled 'Held Coins'
  • (Opinion) have the capability to add dyes
  • When in Buy mode, Stock slots should either be greyed-out or removed.
  • Creative vendors should not have Stock slots.
  • Block should look different if in BUY or SELL mode, and should display Sale or Buy price on the block.

Creative Tab:

  • Should be populated with dyed cards.

General:

  • Remove the 'Tick' button from all GUIs. Redundant because escape key.
  • Use that valuable space to ADD LABELS and organise the GUI more effectively.
  • If Blaze Banker can be renamed, why not everything else?
  • Different GUIs are offset from the inventory GUI by varying amounts which is annoying.
  • Why does each different on-screen block renderer that appears when a GUI is opened mess with JEI differently??

Vendor Tooltip Issue (Likely due to either Create or Legendary Tooltips):

(Screenshot in the bottom)

Screenshots and Videos

Screenshot 2024-05-29 193656

Additional Context

1.19.2?

Will this be ported to 1.19.2?

Admin-mode for servers

Describe the Suggestion

When owner of a server/op-ed, all shops and depositors can be accessed without being trusted whatsoever, even in survival mode. I recommend adding a specific admin mode toggle to allow the same experience as with all other players. As of now, to test things you need to actually deop yourself and have another admin then redo it.

Screenshots and Videos

No response

Additional Context

No response

The Sprocket complicates money conversion

Describe the Suggestion

Strange value
The sprocket fits strangely into the denominations of the coins. Bevels, Cogs, Crowns and Suns are all 8x the previous coin if you ignore the sprocket, but the sprocket takes that chain from x8-x8-x8-x8 to x8-x2-x4-x8-x8

Repeated initials
The names of the coins share a lot of the same initials, making it slightly inconvenient to mark prices on signs with just a letter, even if you use upper and lower case: s b S c C S. The sprocket even shares the same two initials to the spurs, so removing the sprocket would allow you to use two letters without confusion: sp, be, sp, co, cr, su

Screenshots and Videos

No response

Additional Context

No response

Unbreakable Blaze Bankers

Describe the Bug

When you shift to break a blaze banker it just replaces the block, making it unbreakable unless blown up.

Reproduction Steps

[These can only be recreated in creative on Forge 47.2.0]

Blaze Banker

  1. Place down a lit blaze burner.
  2. Equip the blaze burner with a banking guide.
  3. Attempting to break it when shift clicking will fail.

Expected Result

Blaze Banker
It will be unbreakable even while shift clicking unless blown up.

Screenshots and Videos

N/A or [Didn't Crash]

Crash Report or Log

N/A or [Didn't Crash]

Operating System

Windows 11

Mod Version

1.0.4

Create Mod Version

0.5.1f

Minecraft Version

1.20.1

ModLoader and Version

Forge 47.2.0

Other Mods

N/A or [Didn't Crash]

Additional Context

There is no conflict of mods involved in this bug

Config to Limit Breaking Vendors to Owners

Describe the Suggestion

Title is relatively explanatory. While vendors are a great way to trade items between players, there is always going to be that small group that would rather just steal the resources, preventing vendors from being broken by non-owners by default is likely overkill however, it would be nice to have a config option to prevent their destruction from whoever didn't place them, similar to a claim except only extending to the vendors.

Screenshots and Videos

No response

Additional Context

No response

Shift + Right Click to sell / buy whole stack.

Describe the Suggestion

Please let us use shift + right click (with the applicable item) to buy or sell a whole stack, currently doing things like selling stacks of gold (or anything) for coins is very laborious.

Screenshots and Videos

No response

Additional Context

No response

German translation

I saw that the mod Numismatics doesn't have a German translation. Since I am German myself, I could help you with this.

Configurable starting amount in bank per player

Describe the Suggestion

It would be convenient to add a setting in config that determines how much currency each player's bank account starts with.

Screenshots and Videos

No response

Additional Context

No response

Vendor Breaking

Describe the Suggestion

When breaking the vendor its coded to say press shift to break it. However some people (such as my self) use other buttons like control to crouch so it would be nice to change it so instead the "Hold (Player Set Crouch Keybind) to break this block.

Screenshots and Videos

2024-05-30_13 27 49

Additional Context

do you like ferrets?

[Feature request] Computer craft compatibility

It would be nice, if it had computer craft compatibility (for example, be able to set coins amount in brass depositor, or ability to transfer money between Banker peripherals / transfer money between banker and storage), for more sophisticated trading.

But to maintain security, there should be some way to "allow" peripherals, so that money could not be stolen with attaching peripheral and transferring money...

Translatability of coin values

  • Names can be properly translated, however the Value string of coins are hard coded into printing "cog/s" regardless of language, and cannot be translated. ✔️

    • Assuming Spanish translation, labeling "Cog" as "Tuerca", and "Sun" as "Sol" prints correctly, but the Value string for one Sol prints "Valor: 64 cogs", when it should be "Valor: 64 Tuercas". ✔️
  • Summary tooltips have a lang string, but don't actually translate in-game.

  • Coin value tooltips within GUI are hardcoded and cannot be translated. ✔️

[Feature Request]: Vendors allowing seleting item to do this

Describe the Suggestion

So I don't know what to name the title better, but in the "Screenshots and Videos," I have shown how a create item filter allows for you to keep the item, but in vendors, it does not do that. It would be really useful so you don't need two items to sell/buy

Screenshots and Videos

2024-04-26.10-44-12.mp4

Additional Context

The suggestion was also mentioned in [ They Added Money to Create? by Shalz (mentioned there)

[Feature Request]: Add a "government" controled banking.

Many servers have factions, groups, etc that want to control their own independent economy from other factions. I propose the following:

  1. Existing bank accounts will become international bank accounts (for compatibility). It should be possible to create new international bank accounts.
  2. Add a currency card these will be used to identify currencies from each other.
  3. Add a currency controller (or a better name). The owner of the controller will be able to assign an interest rate (and other options a government should control), there should be a trusted menu like the other blocks. Multiple currency controllers can control the same currency if they have the same currency card
  4. Bank terminals (and blaze bankers) can be assigned to a currency by giving it a currency card.

Nothing loads (Fixed)

I downloaded the mod from modrinth, and the only thing from the mod that exists is the crown. Nothing else. Not even the creative menu tab!

Crash on start

Whenever I start Minecraft it crashes before getting to the main menu. Would this be due to the version of create I'm using? I have tried every version of Numismatics but none have worked.
Screenshot 2024-04-22 015253

https://paste.ee/p/SdB6S#

ID Card Reader

Describe the Suggestion

A block that would emit a redstone signal when someone right-clicks it with their ID card, provided they are in the block's whitelist. Could not be activated if using someone else's card (configurable?).

Screenshots and Videos

No response

Additional Context

No response

[Feature Request] Have depositors function as partial blocks for redstone purposes.

At the moment, you can place a button/lever on depositors to power them with redstone the exact same way it does when coins are inserted. I think it would be a good idea for them to function similar to how stairs work, where the sides count as full blocks, but the actual stair block can't be powered by redstone. Obviously the depositors have a few more solid sides than stairs do, so it would have to be adjusted slightly. That way a singular button can't break an entire depositor system.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.